Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include /etc/cni/net.d/k8s.conf in rootfs by default #2907

Closed
brb opened this issue Jun 16, 2018 · 5 comments
Closed

Do not include /etc/cni/net.d/k8s.conf in rootfs by default #2907

brb opened this issue Jun 16, 2018 · 5 comments
Labels
area/guest-vm General configuration issues with the minikube guest VM kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@brb
Copy link
Contributor

brb commented Jun 16, 2018

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

FEATURE REQUEST

Currently, minikube ships with /etc/cni/net.d/k8s.conf in rootfs.

When using minikube with other CNI network providers, e.g. Weave Net, kubelet might use the config when starting pods till the provider has provisioned its CNI config, which results in some pods being attached to mybridge instead of the weave bridge. Some manual steps are required to prevent from this happening: weaveworks/weave#3124 (comment).

Instead of shipping k8s.conf inside rootfs, I suggest to add a param to minikube start which would trigger provisioning of k8s.conf.

If this makes sense to you, I'm happy to open a PR.

@brb brb changed the title Proposal: do not include /etc/cni/net.d/k8s.conf into rootfs by default Proposal: do not include /etc/cni/net.d/k8s.conf in rootfs by default Jun 16, 2018
@dlorenc
Copy link
Contributor

dlorenc commented Jun 16, 2018

This sgtm. Let me know when you send the PR!

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 14, 2018
@tstromberg tstromberg changed the title Proposal: do not include /etc/cni/net.d/k8s.conf in rootfs by default Do not include /etc/cni/net.d/k8s.conf in rootfs by default Sep 19, 2018
@tstromberg tstromberg added area/guest-vm General configuration issues with the minikube guest VM kind/bug Categorizes issue or PR as related to a bug. labels Sep 19, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 19, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/guest-vm General configuration issues with the minikube guest VM kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants