-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not include /etc/cni/net.d/k8s.conf in rootfs by default #2907
Comments
This sgtm. Let me know when you send the PR! |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
FEATURE REQUEST
Currently, minikube ships with /etc/cni/net.d/k8s.conf in rootfs.
When using minikube with other CNI network providers, e.g. Weave Net, kubelet might use the config when starting pods till the provider has provisioned its CNI config, which results in some pods being attached to
mybridge
instead of theweave
bridge. Some manual steps are required to prevent from this happening: weaveworks/weave#3124 (comment).Instead of shipping
k8s.conf
inside rootfs, I suggest to add a param tominikube start
which would trigger provisioning ofk8s.conf
.If this makes sense to you, I'm happy to open a PR.
The text was updated successfully, but these errors were encountered: