Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Kubernetes 1.12 #3164

Closed
robrich opened this issue Sep 26, 2018 · 12 comments · Fixed by #3402
Closed

Support for Kubernetes 1.12 #3164

robrich opened this issue Sep 26, 2018 · 12 comments · Fixed by #3402
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@robrich
Copy link
Contributor

robrich commented Sep 26, 2018

Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST

K8s v. 1.11 and 1.12 in minikube please?

Please provide the following details:

Environment:

Minikube version (use minikube version): 0.28.2

  • OS (e.g. from /etc/os-release): Windows 10
  • VM Driver (e.g. cat ~/.minikube/machines/minikube/config.json | grep DriverName): hyperv
  • ISO version (e.g. cat ~/.minikube/machines/minikube/config.json | grep -i ISO or minikube ssh cat /etc/VERSION): v0.28.1
  • Install tools:
  • Others:
@geerlingguy
Copy link

I'm also wondering—is there any way to get a 1.10 version later than 1.10.0? It has a fairly annoying bug (kubernetes/kubernetes#54870) that causes my minikube cluster to kill itself when testing lots of jobs that fail.

@geerlingguy
Copy link

See also: #2988

It looks like 1.11 at least is already there, it's just kinda hidden?

@geerlingguy
Copy link

Examples:

minikube start --kubernetes-version v1.10.7
minikube start --kubernetes-version v1.11.3

@tamalsaha
Copy link
Member

I tried the same approach for 1.12.0-rc.2 and it did not work.

$ minikube delete; minikube start --kubernetes-version=v1.12.0-rc.2
Deleting local Kubernetes cluster...
Machine deleted.
Starting local Kubernetes v1.12.0-rc.2 cluster...
Starting VM...
Getting VM IP address...
Moving files into cluster...
Downloading kubelet v1.12.0-rc.2
Downloading kubeadm v1.12.0-rc.2
Finished Downloading kubeadm v1.12.0-rc.2
Finished Downloading kubelet v1.12.0-rc.2
Setting up certs...
Connecting to cluster...
Setting up kubeconfig...
Starting cluster components...
E0926 15:34:09.552031   16740 start.go:300] Error starting cluster:  kubeadm init error 
sudo /usr/bin/kubeadm init --config /var/lib/kubeadm.yaml --ignore-preflight-errors=DirAvailable--etc-kubernetes-manifests --ignore-preflight-errors=DirAvailable--data-minikube --ignore-preflight-errors=Port-10250 --ignore-preflight-errors=FileAvailable--etc-kubernetes-manifests-kube-scheduler.yaml --ignore-preflight-errors=FileAvailable--etc-kubernetes-manifests-kube-apiserver.yaml --ignore-preflight-errors=FileAvailable--etc-kubernetes-manifests-kube-controller-manager.yaml --ignore-preflight-errors=FileAvailable--etc-kubernetes-manifests-etcd.yaml --ignore-preflight-errors=Swap --ignore-preflight-errors=CRI  &&
sudo /usr/bin/kubeadm alpha phase addon kube-dns
 running command: : running command: 
sudo /usr/bin/kubeadm init --config /var/lib/kubeadm.yaml --ignore-preflight-errors=DirAvailable--etc-kubernetes-manifests --ignore-preflight-errors=DirAvailable--data-minikube --ignore-preflight-errors=Port-10250 --ignore-preflight-errors=FileAvailable--etc-kubernetes-manifests-kube-scheduler.yaml --ignore-preflight-errors=FileAvailable--etc-kubernetes-manifests-kube-apiserver.yaml --ignore-preflight-errors=FileAvailable--etc-kubernetes-manifests-kube-controller-manager.yaml --ignore-preflight-errors=FileAvailable--etc-kubernetes-manifests-etcd.yaml --ignore-preflight-errors=Swap --ignore-preflight-errors=CRI  &&
sudo /usr/bin/kubeadm alpha phase addon kube-dns

.: Process exited with status 1
================================================================================
An error has occurred. Would you like to opt in to sending anonymized crash
information to minikube to help prevent future errors?
To opt out of these messages, run the command:
	minikube config set WantReportErrorPrompt false
================================================================================
Please enter your response [Y/n]: 

@outcoldman
Copy link
Contributor

I have found several incompatibility issues in minikube with Kubernetes v1.12

  1. It uses kubeadm.k8s.io/v1alpha1 for kubeadm. Kubernetes 1.12 does not support version v1alpha1. Only v1alpha2. The recommended version is v1alpha3.

  2. This addon is not available /usr/bin/kubeadm alpha phase addon kube-dns, I guess it should use coredns instead

  3. The argument cadvisor-port is not available in k8s-1.12

After I have fixed these issues I could bootstrap kube 1.12 with minikube.

I have a patch ready in https://github.com/outcoldman/minikube/tree/k8s-1.12, you can test it with (instructions are for macOS, for other OS change the make target out/minikube-darwin-amd64)

git clone git@github.com:outcoldman/minikube.git
cd minikube
git checkout k8s-1.12
docker run --rm -v "$PWD":/go/src/k8s.io/minikube -w /go/src/k8s.io/minikube -e IN_DOCKER=1 golang:stretch  make out/minikube-darwin-amd64
./out/minikube-darwin-amd64 start --kubernetes-version v1.12.0

@tstromberg tstromberg changed the title K8s v. 1.11 and 1.12 in minikube please? Support for Kubernetes 1.12 Sep 28, 2018
@afbjorklund
Copy link
Collaborator

We found some v1.11.0 CRI-O issues in #3153, I guess these would also apply to 1.12

@robpblake
Copy link

Examples:

minikube start --kubernetes-version v1.10.7
minikube start --kubernetes-version v1.11.3

Building on @geerlingguy's comment. If you're forgetful like me, you can alternatively use

minikube config set kubernetes-version <kubernetes_version>
e.g. 
minikube config set kubernetes-version v1.11.3

Which stores your desired version of Kubernetes more persistently into ~/.minikube/config/config.json and works across multiple restarts of your minikube environment.

@pnpavlov
Copy link

hey @robrich, just checked that "minikube start --kubernetes-version=v1.12.0" works with minikube version: v0.30.0. Maybe this issue could be closed?

@psura
Copy link

psura commented Oct 29, 2018

Same here. With minikube v0.30.0, kuvernetes-version v.1.12.0 worked for me and not v1.12.1
For those the latest v1.12.1 works, it could be the mac OS version in the mix as well. My Mac OS Version High Sierra 10.13.6 (17G65) My Colleague with mac OS version El Capitana, the latest minikube v1.12.1 worked fine.

@robrich
Copy link
Contributor Author

robrich commented Oct 30, 2018

@pnpavlov: Not sure. Maybe we need #3180 and #3262 and #3164 (comment) to land before it's good enough for mortals?

@tstromberg tstromberg self-assigned this Oct 30, 2018
@tstromberg tstromberg added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 30, 2018
@tstromberg tstromberg added this to the v0.31.0 milestone Oct 30, 2018
@tstromberg
Copy link
Contributor

CI is in somewhat stable state (<15% failures), so I've finally proposed to make v1.12.3 the default: #3402

@robrich
Copy link
Contributor Author

robrich commented Dec 7, 2018

Reopen this now that #3402 is unmerged via #3423? Or close in favor of #3386 leading the charge towards v 1.12?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants