-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide solution message for unnecessary sudo #4420
Comments
@medyagh I would like to work on this. |
@djmgit I suggest using golang "os/user" std lib package:
important thing is make sure it works on both windows and mac and linux ( the go package seems to be working on all but make sure ) |
@djmgit one more detail is, the sudo is required for --vm-driver hyperv so the message should not warn users who are using hyperv |
@medyagh thanks a lot for the pointers, I will send a PR ASAP |
Fixes kubernetes#4420. If minikue is started with root privilege and vm-driver is not hyperv, then a warning message is displayed.
Fixes kubernetes#4420. If minikue is started with root privilege and vm-driver is not hyperv, then a warning message is displayed.
@medyagh I have submitted a PR for this. Let me know what changes need to be made. |
Running minikube with "sudo" privileges is not necessary in some cases causes issues. (such as host env vars)
We need to provide a solution message (warning) not to run minikube in sudo:
"Please don't run minikube as root or with "sudo" privileges. It isn't necessary."
The text was updated successfully, but these errors were encountered: