Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gvisor integration test missing testing failed event #4943

Closed
medyagh opened this issue Aug 1, 2019 · 1 comment
Closed

gvisor integration test missing testing failed event #4943

medyagh opened this issue Aug 1, 2019 · 1 comment
Assignees
@medyagh
Labels
area/testing help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@medyagh
Copy link
Member

medyagh commented Aug 1, 2019 •
edited
Loading

we have a func

waitForFailedCreatePodSandBoxEvent which is unused ! and currently we don't test gvisor failed event in case of disabling it.

minikube/test/integration/util/util.go

Line 405 in 9916d7a

func WaitForFailedCreatePodSandBoxEvent() error {

We need improve the gvisor integration test
@medyagh medyagh added area/testing help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 1, 2019
@tstromberg tstromberg added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 1, 2019
@ianlewis
Copy link
Contributor

@medyagh I'm not sure this part of the test was all that important anyway. I cleaned up the integration tests a bit in #4494 and removed this bit. Do you think anything more is needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@medyagh medyagh

Labels
area/testing help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ianlewis @tstromberg @medyagh