Update gvisor runsc version #4494

ianlewis · 2019-06-15T04:44:34Z

Updates the gvisor addon to use containerd shim v2
Updates the version of runsc
Auto-installs a gvisor RuntimeClass

k8s-ci-robot · 2019-06-15T04:44:35Z

Welcome @ianlewis!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

minikube-bot · 2019-06-15T04:45:02Z

Can one of the admins verify this patch?

ianlewis · 2019-06-15T04:47:26Z

/assign @sharifelgamal

ianlewis · 2019-06-15T04:51:47Z

cc @medyagh

ianlewis · 2019-06-15T04:53:44Z

Currently using anything newer than the 2019-01-14 version of runsc is blocked by #3512 because runsc uses pivot_root on newer versions.

ianlewis · 2019-06-15T04:58:18Z

Also cc @priyawadhwa since she did the original gvisor addon.

medyagh · 2019-06-15T05:33:59Z

@minikube-bot OK to test

medyagh · 2019-06-15T07:45:53Z

/retest this please

ianlewis · 2019-06-17T01:14:18Z

These Jenkins test failures don't seem to be related to this change. Not sure if there's any action I can take.

medyagh · 2019-06-18T18:19:11Z

/retest this please

priyawadhwa

Took a quick look and this makes sense to me! Could you also add runtimeClassName: gvisor to nginx-untrusted.yaml to test this in the integration tests?

tstromberg · 2019-06-19T23:21:30Z

@minikube-bot OK to test

tstromberg · 2019-06-24T02:36:35Z

It's probably a flake, but some of the gvisor tests failed:

--- FAIL: TestFunctionalContainerd (1098.68s)
    --- FAIL: TestFunctionalContainerd/Gvisor (654.05s)
        addons_test.go:198: waiting for gvisor controller to come up
        addons_test.go:262: creating pod with untrusted workload annotation
        addons_test.go:205: making sure untrusted workload is Running
        addons_test.go:207: waiting for nginx to be up: waiting for nginx pods: timed out waiting for the condition

tstromberg · 2019-06-24T02:36:43Z

@minikube-bot OK to test

medyagh · 2019-06-25T20:21:51Z

/retest this please

medyagh · 2019-06-25T22:49:56Z

@ianlewis the integration test fail for gvisor consistently on different platforms.
do we need to update the test data for this ?

--- FAIL: TestFunctionalContainerd (1424.10s)
    --- FAIL: TestFunctionalContainerd/Gvisor (687.88s)
        addons_test.go:198: waiting for gvisor controller to come up
        addons_test.go:262: creating pod with untrusted workload annotation
        addons_test.go:205: making sure untrusted workload is Running
        addons_test.go:207: waiting for nginx to be up: waiting for nginx pods: timed out waiting for the condition

ianlewis · 2019-06-27T01:13:36Z

@medyagh I missed the tests, thanks for pointing them out. I modified the test data and added new tests, but I still can't get the tests to pass locally. Since the gVisor addon was modified I need the integration tests to use my updated version of the gvisor-addon image but I can't find a way to do that. I guess I should push all the images to my own repo and load from there?

ianlewis · 2019-06-27T02:23:49Z

@minikube-bot OK to test

medyagh · 2019-06-27T07:34:15Z

/retest this please

k8s-ci-robot · 2019-08-25T20:01:13Z

New changes are detected. LGTM label has been removed.

TravisBuddy · 2019-08-25T20:09:06Z

Travis tests have failed

Hey @ianlewis,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.17.1'
golangci/golangci-lint info found version: 1.17.1 for v1.17.1/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
test/integration/containerd_test.go:222:17: undeclared name: `commonutil` (typecheck)
	client, err := commonutil.GetClient()
	               ^
test/integration/containerd_test.go:186:16: undeclared name: `path` (typecheck)
	gvisorPath := path.Join(curdir, "testdata", "nginx-gvisor.yaml")
	              ^
test/integration/containerd_test.go:124:41: too many arguments (typecheck)
	if err := waitForUntrustedNginxRunning(p); err != nil {
	                                       ^
Makefile:323: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ok  	k8s.io/minikube/cmd/minikube/cmd	0.079s	coverage: 15.6% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.060s	coverage: 18.9% of statements
ok  	k8s.io/minikube/pkg/drivers	0.035s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.028s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	0.040s	coverage: 61.8% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	4.225s	coverage: 72.9% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.107s	coverage: 29.5% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.583s	coverage: 54.2% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.026s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.013s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.008s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.075s	coverage: 75.6% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.034s	coverage: 1.5% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	0.033s	coverage: 12.0% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.034s	coverage: 77.8% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.009s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.005s	coverage: 42.9% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.011s	coverage: 67.3% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.045s	coverage: 81.8% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.047s	coverage: 35.9% of statements
ok  	k8s.io/minikube/pkg/minikube/sshutil	0.372s	coverage: 75.0% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.005s	coverage: 8.4% of statements
ok
Makefile:229: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: 2d5acd10-c774-11e9-854a-5595b23fa18a

TravisBuddy · 2019-08-26T03:32:01Z

Travis tests have failed

Hey @ianlewis,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.17.1'
golangci/golangci-lint info found version: 1.17.1 for v1.17.1/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
test/integration/containerd_test.go:53:15: Error return value of `mk.RunCommand` is not checked (errcheck)
	mk.RunCommand("addons enable gvisor", true)
	             ^
test/integration/containerd_test.go:75:15: Error return value of `mk.RunCommand` is not checked (errcheck)
	mk.RunCommand("addons enable gvisor", true)
	             ^
test/integration/containerd_test.go:156:6: `deleteGvisorWorkload` is unused (deadcode)
func deleteGvisorWorkload(t *testing.T, profile string) {
     ^
test/integration/containerd_test.go:180:6: `waitForGvisorControllerDeleted` is unused (deadcode)
func waitForGvisorControllerDeleted(p string) error {
     ^
Makefile:323: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ok  	k8s.io/minikube/cmd/minikube/cmd	0.063s	coverage: 15.6% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.055s	coverage: 18.9% of statements
ok  	k8s.io/minikube/pkg/drivers	0.011s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.068s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	0.035s	coverage: 61.8% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	3.415s	coverage: 72.9% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.082s	coverage: 29.5% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.368s	coverage: 54.2% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.024s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.009s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.009s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.040s	coverage: 75.6% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.038s	coverage: 1.5% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	0.035s	coverage: 12.0% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.020s	coverage: 77.8% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.012s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.012s	coverage: 42.9% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.008s	coverage: 67.3% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.013s	coverage: 81.8% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.054s	coverage: 35.9% of statements
ok  	k8s.io/minikube/pkg/minikube/sshutil	0.156s	coverage: 75.0% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.009s	coverage: 8.4% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.950s	coverage: 64.5% of statements
ok  	k8s.io/minikube/pkg/util	0.691s	coverage: 61.6% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.009s	coverage: 0.0% of statements
ok
Makefile:229: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: 0b9e9880-c7b2-11e9-854a-5595b23fa18a

TravisBuddy · 2019-08-26T03:42:41Z

Travis tests have failed

Hey @ianlewis,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.17.1'
golangci/golangci-lint info found version: 1.17.1 for v1.17.1/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
test/integration/containerd_test.go:156:6: `deleteGvisorWorkload` is unused (deadcode)
func deleteGvisorWorkload(t *testing.T, profile string) {
     ^
test/integration/containerd_test.go:180:6: `waitForGvisorControllerDeleted` is unused (deadcode)
func waitForGvisorControllerDeleted(p string) error {
     ^
test/integration/containerd_test.go:53:15: Error return value of `mk.RunCommand` is not checked (errcheck)
	mk.RunCommand("addons enable gvisor", true)
	             ^
test/integration/containerd_test.go:75:15: Error return value of `mk.RunCommand` is not checked (errcheck)
	mk.RunCommand("addons enable gvisor", true)
	             ^
Makefile:323: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ok  	k8s.io/minikube/cmd/minikube/cmd	0.070s	coverage: 15.6% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.043s	coverage: 18.9% of statements
ok  	k8s.io/minikube/pkg/drivers	0.009s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.062s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	0.034s	coverage: 61.8% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	2.728s	coverage: 72.9% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.074s	coverage: 29.5% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.257s	coverage: 54.2% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.029s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.010s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.013s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.046s	coverage: 75.6% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.034s	coverage: 1.5% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	0.030s	coverage: 12.0% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.030s	coverage: 77.8% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.011s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.027s	coverage: 42.9% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.009s	coverage: 67.3% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.013s	coverage: 81.8% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.037s	coverage: 35.9% of statements
ok  	k8s.io/minikube/pkg/minikube/sshutil	0.165s	coverage: 75.0% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.004s	coverage: 8.4% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	2.054s	coverage: 64.5% of statements
ok  	k8s.io/minikube/pkg/util	1.796s	coverage: 61.6% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.002s	coverage: 0.0% of statements
ok
Makefile:229: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: 8cbf6e20-c7b3-11e9-854a-5595b23fa18a

TravisBuddy · 2019-08-26T04:55:33Z

Travis tests have failed

Hey @ianlewis,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.17.1'
golangci/golangci-lint info found version: 1.17.1 for v1.17.1/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
test/integration/containerd_test.go:156:6: `deleteGvisorWorkload` is unused (deadcode)
func deleteGvisorWorkload(t *testing.T, profile string) {
     ^
test/integration/containerd_test.go:180:6: `waitForGvisorControllerDeleted` is unused (deadcode)
func waitForGvisorControllerDeleted(p string) error {
     ^
test/integration/containerd_test.go:53:15: Error return value of `mk.RunCommand` is not checked (errcheck)
	mk.RunCommand("addons enable gvisor", true)
	             ^
test/integration/containerd_test.go:75:15: Error return value of `mk.RunCommand` is not checked (errcheck)
	mk.RunCommand("addons enable gvisor", true)
	             ^
Makefile:323: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ok  	k8s.io/minikube/cmd/minikube/cmd	0.074s	coverage: 15.6% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.044s	coverage: 18.9% of statements
ok  	k8s.io/minikube/pkg/drivers	0.009s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.036s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	0.027s	coverage: 61.8% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	2.609s	coverage: 72.9% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.059s	coverage: 29.5% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	1.021s	coverage: 54.2% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.027s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.015s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.007s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.068s	coverage: 75.6% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.022s	coverage: 1.5% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	0.029s	coverage: 12.0% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.029s	coverage: 77.8% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.014s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.006s	coverage: 42.9% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.014s	coverage: 67.3% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.018s	coverage: 81.8% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.038s	coverage: 35.9% of statements
ok  	k8s.io/minikube/pkg/minikube/sshutil	0.495s	coverage: 75.0% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.014s	coverage: 8.4% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	2.059s	coverage: 64.5% of statements
ok  	k8s.io/minikube/pkg/util	1.512s	coverage: 61.6% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.002s	coverage: 0.0% of statements
ok
Makefile:229: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: b704c400-c7bd-11e9-854a-5595b23fa18a

tstromberg · 2019-08-26T04:56:49Z

func deleteGvisorWorkload(t *testing.T, profile string) {

     ^

test/integration/containerd_test.go:180:6: `waitForGvisorControllerDeleted` is unused (deadcode)

func waitForGvisorControllerDeleted(p string) error {

     ^

test/integration/containerd_test.go:53:15: Error return value of `mk.RunCommand` is not checked (errcheck)

	mk.RunCommand("addons enable gvisor", true)

	             ^

test/integration/containerd_test.go:75:15: Error return value of `mk.RunCommand` is not checked (errcheck)

	mk.RunCommand("addons enable gvisor", true)

	             ^

Makefile:323: recipe for target 'lint-ci' failed

make[1]: *** [lint-ci] Error 1

- Updates the gvisor addon to use containerd shim v2 - Updates the version of runsc - Auto-installs a gvisor RuntimeClass Issue kubernetes#4482

ianlewis · 2019-08-26T05:03:16Z

Yeah, I wasn't pushing the changes I thought I was pushing.

ianlewis · 2019-08-26T17:58:17Z

The failing tests all seem to be failing in different ways and look like it may be flakes, but I can't tell. They don't seem to me to be related to my changes.

ianlewis · 2019-08-26T21:29:30Z

/retest please

tstromberg · 2019-08-30T04:12:11Z

@minikube-bot OK to test

ianlewis · 2019-09-04T04:45:03Z

Containerd tests seem to be failing.... will take a look.

ianlewis · 2019-09-04T09:15:42Z

I'm finding the integration tests to be pretty flaky when run in parallel. Opened #5255

ianlewis · 2019-09-04T10:18:06Z

@tstromberg
I think this should be ok to merge. Integration tests are failing but they seem to be flaky anyway and if I run the gvisor integration tests individually they pass for me (at least on KVM).

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 15, 2019

ianlewis changed the title ~~[WIP] Update gvisor runsc version (refs #4482)~~ Update gvisor runsc version (refs #4482) Jun 15, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2019

k8s-ci-robot requested review from afbjorklund and balopat June 15, 2019 04:44

ianlewis force-pushed the gvisor-containerd-shim_v0.0.2 branch from 1bce451 to 07b842a Compare June 15, 2019 04:45

k8s-ci-robot assigned sharifelgamal Jun 15, 2019

medyagh requested a review from priyawadhwa June 15, 2019 05:33

priyawadhwa reviewed Jun 18, 2019

View reviewed changes

ianlewis force-pushed the gvisor-containerd-shim_v0.0.2 branch from 07b842a to f641bcc Compare June 27, 2019 02:19

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2019

ianlewis force-pushed the gvisor-containerd-shim_v0.0.2 branch from cc42069 to 594e99e Compare August 26, 2019 03:24

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 26, 2019

ianlewis changed the title ~~Update gvisor runsc version (refs #4482)~~ Update gvisor runsc version Aug 26, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2019

ianlewis force-pushed the gvisor-containerd-shim_v0.0.2 branch from 594e99e to f856177 Compare August 26, 2019 03:35

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 26, 2019

ianlewis force-pushed the gvisor-containerd-shim_v0.0.2 branch from f856177 to e217128 Compare August 26, 2019 04:47

Update gvisor runsc version

d14bdbc

- Updates the gvisor addon to use containerd shim v2 - Updates the version of runsc - Auto-installs a gvisor RuntimeClass Issue kubernetes#4482

ianlewis force-pushed the gvisor-containerd-shim_v0.0.2 branch from e217128 to d14bdbc Compare August 26, 2019 05:02

This was referenced Aug 26, 2019

gvisor integration test missing testing failed event #4943

Closed

Upgrade containerd to 1.2.8. #5194

Merged

Merge branch 'master' into gvisor-containerd-shim_v0.0.2

d8c380d

Update gVisor tests to actually start a cluster.

1598a28

sharifelgamal merged commit cb5ebed into kubernetes:master Sep 5, 2019

ianlewis deleted the gvisor-containerd-shim_v0.0.2 branch September 6, 2019 01:37

tstromberg mentioned this pull request Sep 18, 2019

Update runsc version used by gVisor addon #4482

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update gvisor runsc version #4494

Update gvisor runsc version #4494

ianlewis commented Jun 15, 2019 •

edited

Loading

k8s-ci-robot commented Jun 15, 2019

minikube-bot commented Jun 15, 2019

ianlewis commented Jun 15, 2019

ianlewis commented Jun 15, 2019

ianlewis commented Jun 15, 2019

ianlewis commented Jun 15, 2019

medyagh commented Jun 15, 2019

medyagh commented Jun 15, 2019

ianlewis commented Jun 17, 2019

medyagh commented Jun 18, 2019

priyawadhwa left a comment

tstromberg commented Jun 19, 2019

tstromberg commented Jun 24, 2019

tstromberg commented Jun 24, 2019

medyagh commented Jun 25, 2019

medyagh commented Jun 25, 2019 •

edited

Loading

ianlewis commented Jun 27, 2019

ianlewis commented Jun 27, 2019

medyagh commented Jun 27, 2019

k8s-ci-robot commented Aug 25, 2019

TravisBuddy commented Aug 25, 2019

TravisBuddy commented Aug 26, 2019

TravisBuddy commented Aug 26, 2019

TravisBuddy commented Aug 26, 2019

tstromberg commented Aug 26, 2019

ianlewis commented Aug 26, 2019

ianlewis commented Aug 26, 2019

ianlewis commented Aug 26, 2019

tstromberg commented Aug 30, 2019

ianlewis commented Sep 4, 2019

ianlewis commented Sep 4, 2019

ianlewis commented Sep 4, 2019

Update gvisor runsc version #4494

Update gvisor runsc version #4494

Conversation

ianlewis commented Jun 15, 2019 • edited Loading

k8s-ci-robot commented Jun 15, 2019

minikube-bot commented Jun 15, 2019

ianlewis commented Jun 15, 2019

ianlewis commented Jun 15, 2019

ianlewis commented Jun 15, 2019

ianlewis commented Jun 15, 2019

medyagh commented Jun 15, 2019

medyagh commented Jun 15, 2019

ianlewis commented Jun 17, 2019

medyagh commented Jun 18, 2019

priyawadhwa left a comment

Choose a reason for hiding this comment

tstromberg commented Jun 19, 2019

tstromberg commented Jun 24, 2019

tstromberg commented Jun 24, 2019

medyagh commented Jun 25, 2019

medyagh commented Jun 25, 2019 • edited Loading

ianlewis commented Jun 27, 2019

ianlewis commented Jun 27, 2019

medyagh commented Jun 27, 2019

k8s-ci-robot commented Aug 25, 2019

TravisBuddy commented Aug 25, 2019

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 2d5acd10-c774-11e9-854a-5595b23fa18a

TravisBuddy commented Aug 26, 2019

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 0b9e9880-c7b2-11e9-854a-5595b23fa18a

TravisBuddy commented Aug 26, 2019

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 8cbf6e20-c7b3-11e9-854a-5595b23fa18a

TravisBuddy commented Aug 26, 2019

Travis tests have failed

1st Build

TravisBuddy Request Identifier: b704c400-c7bd-11e9-854a-5595b23fa18a

tstromberg commented Aug 26, 2019

ianlewis commented Aug 26, 2019

ianlewis commented Aug 26, 2019

ianlewis commented Aug 26, 2019

tstromberg commented Aug 30, 2019

ianlewis commented Sep 4, 2019

ianlewis commented Sep 4, 2019

ianlewis commented Sep 4, 2019

ianlewis commented Jun 15, 2019 •

edited

Loading

medyagh commented Jun 25, 2019 •

edited

Loading