Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to see that the node is a minikube node #6715

Closed
balopat opened this issue Feb 20, 2020 · 2 comments · Fixed by #6717
Closed

Ability to see that the node is a minikube node #6715

balopat opened this issue Feb 20, 2020 · 2 comments · Fixed by #6717
Assignees
@medyagh
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@balopat
Copy link
Contributor

balopat commented Feb 20, 2020

It would be great if minikube could add a standard annotation to the node, e.g. k8s.minikube.io/version=1.7.3 so that tools like skaffold can rely on that.
@balopat balopat added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 20, 2020
@medyagh medyagh self-assigned this Feb 20, 2020
@balopat balopat mentioned this issue Feb 20, 2020
Closed
@medyagh medyagh added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 20, 2020
@medyagh
Copy link
Member

medyagh commented Feb 20, 2020

we could and should do that !

@medyagh medyagh mentioned this issue Feb 22, 2020
Merged
@medyagh
Copy link
Member

medyagh commented Feb 22, 2020

closed by #6717

@medyagh medyagh closed this as completed Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@medyagh medyagh

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

label minikube nodes medyagh/minikube
2 participants
@balopat @medyagh