Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

label minikube nodes #6717

Merged
merged 7 commits into from
Feb 22, 2020
Merged

label minikube nodes #6717

merged 7 commits into from
Feb 22, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Feb 20, 2020 •
edited
Loading

After this PR minikube nodes will be annonated with a label,
would help to identify this was created by minikube
here are the labels after this PR:

medya@~/workspace/minikube (annotate_node) $ kubectl get nodes --show-labels
NAME       STATUS   ROLES    AGE   VERSION   LABELS
minikube   Ready    master   17m   v1.17.3   
beta.kubernetes.io/arch=amd64,
beta.kubernetes.io/os=linux,
kubernetes.io/arch=amd64,
kubernetes.io/hostname=minikube,
kubernetes.io/os=linux,
minikube.k8s.io/commit=e6535896b4cbd78f679ea016458ba93abb182b2a,
minikube.k8s.io/name=minikube,
minikube.k8s.io/updated_at=2020_02_21T17_08_46_0700,
minikube.k8s.io/version=v1.7.3,
node-role.kubernetes.io/master=

minikube added labels are :

https://github.com/kubernetes/minikube/pull/6717

closes #6715

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2020
@medyagh medyagh changed the title label minikube nodes wip: label minikube nodes Feb 20, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2020
tstromberg
tstromberg suggested changes Feb 20, 2020
View reviewed changes
pkg/minikube/bootstrapper/kubeadm/kubeadm.go Outdated Show resolved Hide resolved
pkg/minikube/bootstrapper/kubeadm/kubeadm.go Outdated Show resolved Hide resolved
pkg/minikube/bootstrapper/kubeadm/kubeadm.go Outdated
// based on ISO 8601 (RFC 3339) except converting - and : to _ because of kubernetes label restriction
createdAtLbl := "k8s.minikube.io/updated_at=" + start.Format("2006_01_02T15_04_05_0700")
verLbl := "k8s.minikube.io/version=" + version.GetVersion()
commitLbl := "k8s.minikube.io/commit=" + version.GetGitCommitID()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we omit the commit id? At least until someone declares a use case for it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the use case for it is, if I am developing locally, I wanna know my developoing-code created this cluster not the minikube stable

@medyagh medyagh changed the title wip: label minikube nodes label minikube nodes Feb 21, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2020
@medyagh
Copy link
Member Author

medyagh commented Feb 21, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 21, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@minikube-pr-bot
Copy link

All Times minikube: [ 92.072002 91.539810 93.371427]
All Times Minikube (PR 6717): [ 91.301111 92.125086 93.100859]

Average minikube: 92.327746
Average Minikube (PR 6717): 92.175685

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6717) |
+----------------------+-----------+--------------------+
| minikube v           |  0.199153 |           0.189480 |
| Creating kvm2        | 19.837342 |          20.239156 |
| Preparing Kubernetes | 50.416809 |          49.171837 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.175095 |          20.734206 |
| Waiting for cluster  |  0.058588 |           0.055741 |
+----------------------+-----------+--------------------+

@minikube-pr-bot
Copy link

All Times minikube: [ 93.988561 93.214564 95.807677]
All Times Minikube (PR 6717): [ 92.058942 94.224536 93.165321]

Average minikube: 94.336934
Average Minikube (PR 6717): 93.149600

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6717) |
+----------------------+-----------+--------------------+
| minikube v           |  0.195321 |           0.201228 |
| Creating kvm2        | 20.200187 |          21.082382 |
| Preparing Kubernetes | 50.517320 |          49.073712 |
| Pulling images       |           |                    |
| Launching Kubernetes | 21.124922 |          20.686738 |
| Waiting for cluster  |  0.064626 |           0.227391 |
+----------------------+-----------+--------------------+

@medyagh medyagh merged commit 44e7cb2 into kubernetes:master Feb 22, 2020
@medyagh medyagh mentioned this pull request Feb 22, 2020
Closed
@medyagh medyagh deleted the annotate_node branch May 2, 2020 22:31
@gsquared94 gsquared94 mentioned this pull request Aug 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg requested changes

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to see that the node is a minikube node
4 participants
@medyagh @k8s-ci-robot @minikube-pr-bot @tstromberg