registry-creds: Add support for Google Artifact Registry

[jonjohnsonjr]

I'd love to have Artifact Registry included in the registry-creds addon.

Authentication generally works the same way as GCR: https://cloud.google.com/artifact-registry/docs/docker/quickstart#auth

I'm not sure how registry-creds works or how one might go about adding this. If it's not too difficult, I may be able to contribute given some pointers/guidance.

[medyagh]

@jonjohnsonjr would be a great feature, I would happy accept a PR that would implements this. creating an addon for minikube is documented here, and could also look at one of the addon PRs.

https://minikube.sigs.k8s.io/docs/contrib/addons/

[jonjohnsonjr]

I have some questions :)

It looks like this is what prompts the user to configure GCR credentials with the registry-creds addon. Does this only allow one URL for GCR? It appears to be impossible to configure both e.g. gcr.io and asia.gcr.io using this addon. Is that true?

If the above is true, would it be reasonable to just update some strings to indicate that you can supply an Artifact Registry URL instead of a GCR URL?

[tstromberg]

@jonjohnsonjr - This code was added 4 years ago, so your guess is as good as anyone else's on the project at the moment. It seems bizarre to me that we wouldn't allow credentials to be provided for all GCR & AR endpoints.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[medyagh]

@jonjohnsonjr we added GCR support for GCP-Auth addon recently, (on HEAD) #10853

[medyagh]

@jonjohnsonjr we added GCR support for GCP-Auth addon #10853

do u mind trying with minikube 1.20.0beta ? and see if that fixes ? we believe we added this feature with integration tests

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

[sharifelgamal]

the gcp-auth addon supports artifact registry now.