GCP-Auth addon: Add support for GCR creds #10853

sharifelgamal · 2021-03-17T02:18:55Z

Fixes #9002

This PR is dependent on GoogleContainerTools/gcp-auth-webhook#11 and a new release of the gcp-auth-webhook image.

…-auth

ilya-zuyev

lgtm

sharifelgamal · 2021-03-19T21:59:08Z

/ok-to-test

cmd/minikube/cmd/config/profile_list.go

minikube-pr-bot · 2021-03-22T15:50:41Z

kvm2 Driver
Times for minikube: 66.6s 63.4s 65.2s
Average time for minikube: 65.1s

Times for Minikube (PR 10853): 65.4s 65.6s 67.3s
Average time for Minikube (PR 10853): 66.1s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.1s     | 0.1s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 40.0s    | 40.2s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 2.1s     | 9.2s                |
| on Docker 20.10.3 ...                      |          |                     |
|   - Generating certificates                | 4.3s     | 2.8s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 15.6s    | 10.4s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.2s     | 1.3s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.2s     | 1.3s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.5s     | 1.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 31.6s 33.9s 32.8s
Average time for minikube: 32.8s

Times for Minikube (PR 10853): 38.9s 28.6s 28.4s
Average time for Minikube (PR 10853): 32.0s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 14.0s    | 13.2s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 17.1s    | 16.9s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.1s     | 1.4s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

minikube-pr-bot · 2021-03-23T22:01:31Z

kvm2 Driver
Times for minikube: 67.1s 69.5s 64.3s
Average time for minikube: 67.0s

Times for Minikube (PR 10853): 71.6s 66.3s 70.6s
Average time for Minikube (PR 10853): 69.5s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.1s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 41.1s    | 42.0s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 2.0s     |                     |
| on Docker 20.10.4 ...                      |          |                     |
|   - Generating certificates                | 4.8s     | 4.5s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 15.5s    | 16.7s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.4s     | 1.5s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.3s     | 1.4s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.7s     | 1.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 33.8s 27.2s 32.6s
Average time for minikube: 31.2s

Times for Minikube (PR 10853): 32.0s 28.4s 30.5s
Average time for Minikube (PR 10853): 30.3s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 12.6s    | 11.1s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 16.8s    | 17.2s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.3s     | 1.4s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

minikube-pr-bot · 2021-03-23T23:04:55Z

kvm2 Driver
Times for minikube: 71.7s 68.1s 69.5s
Average time for minikube: 69.8s

Times for Minikube (PR 10853): 64.4s 71.8s 68.0s
Average time for Minikube (PR 10853): 68.1s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.1s     | 0.1s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 42.1s    | 40.4s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 2.2s     | 17.1s               |
| on Docker 20.10.4 ...                      |          |                     |
|   - Generating certificates                | 4.2s     | 1.6s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 16.7s    | 5.5s                |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.7s     | 0.9s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.6s     | 1.4s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 1.0s     | 1.4s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 31.8s 29.8s 31.3s
Average time for minikube: 31.0s

Times for Minikube (PR 10853): 32.8s 39.1s 37.0s
Average time for Minikube (PR 10853): 36.3s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 1.4s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.7s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 11.0s    | 13.6s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 18.0s    | 17.5s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.3s     | 2.7s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

minikube-pr-bot · 2021-03-23T23:32:43Z

kvm2 Driver
Times for minikube: 72.9s 69.3s 67.9s
Average time for minikube: 70.0s

Times for Minikube (PR 10853): 67.1s 70.6s 69.6s
Average time for Minikube (PR 10853): 69.1s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.1s     | 0.1s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 42.4s    | 41.6s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 17.3s    | 2.3s                |
| on Docker 20.10.4 ...                      |          |                     |
|   - Generating certificates                | 1.5s     | 4.3s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 5.4s     | 16.5s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 0.9s     | 1.5s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.6s     | 1.5s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.6s     |                     |
| default-storageclass,                      |          |                     |
| storage-provisioner                        |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 30.9s 46.7s 39.5s
Average time for minikube: 39.0s

Times for Minikube (PR 10853): 39.6s 30.8s 40.1s
Average time for Minikube (PR 10853): 36.8s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 16.1s    | 17.1s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 17.9s    | 17.7s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 4.5s     | 1.4s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

sharifelgamal · 2021-03-23T23:42:20Z

/ok-to-test

minikube-pr-bot · 2021-03-24T02:13:05Z

kvm2 Driver
Times for minikube: 70.6s 66.1s 66.7s
Average time for minikube: 67.8s

Times for Minikube (PR 10853): 70.6s 69.7s 65.2s
Average time for Minikube (PR 10853): 68.5s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.1s     | 0.1s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 40.5s    | 41.1s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 1.9s     | 9.8s                |
| on Docker 20.10.4 ...                      |          |                     |
|   - Generating certificates                | 5.1s     | 3.2s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 16.2s    | 10.6s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.5s     | 1.3s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.6s     | 1.5s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.9s     |                     |
| default-storageclass,                      |          |                     |
| storage-provisioner                        |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 27.2s 42.4s 42.0s
Average time for minikube: 37.2s

Times for Minikube (PR 10853): 31.9s 30.2s 33.7s
Average time for Minikube (PR 10853): 31.9s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.5s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 13.9s    | 12.3s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 19.4s    | 17.7s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 3.3s     | 1.0s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

medyagh

lets add an integration test for this, when only running the test in GCP to try to pull an image from a private GCR that k8s-minikube project has access to .
and skip the imge if not running in GCP

minikube-pr-bot · 2021-03-24T21:01:54Z

kvm2 Driver
Times for minikube: 69.9s 69.5s 67.1s
Average time for minikube: 68.8s

Times for Minikube (PR 10853): 68.5s 67.6s 68.0s
Average time for Minikube (PR 10853): 68.0s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.1s     | 0.1s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 40.5s    | 41.3s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 2.2s     | 2.2s                |
| on Docker 20.10.4 ...                      |          |                     |
|   - Generating certificates                | 4.7s     | 4.0s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 17.0s    | 17.0s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.6s     | 1.4s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.6s     | 1.5s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 1.3s     | 0.5s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 31.5s 38.3s 31.6s
Average time for minikube: 33.8s

Times for Minikube (PR 10853): 41.5s 36.9s 31.0s
Average time for Minikube (PR 10853): 36.5s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.9s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 13.1s    | 15.2s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 17.8s    | 18.0s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.5s     | 2.5s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

minikube-pr-bot · 2021-03-24T23:02:05Z

kvm2 Driver
Times for minikube: 64.0s 66.4s 68.9s
Average time for minikube: 66.4s

Times for Minikube (PR 10853): 65.3s 65.5s 63.8s
Average time for Minikube (PR 10853): 64.9s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.0s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 40.8s    | 39.8s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 9.1s     | 15.1s               |
| on Docker 20.10.4 ...                      |          |                     |
|   - Generating certificates                | 3.1s     | 1.3s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 10.1s    | 5.2s                |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.2s     | 0.9s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.3s     | 1.5s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.4s     |                     |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 26.4s 26.7s 28.3s
Average time for minikube: 27.1s

Times for Minikube (PR 10853): 26.2s 27.2s 30.6s
Average time for Minikube (PR 10853): 28.0s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 9.6s     | 11.0s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.7s    | 15.5s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.3s     | 1.1s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

minikube-pr-bot · 2021-03-24T23:30:53Z

kvm2 Driver
Times for minikube: 68.1s 70.0s 68.1s
Average time for minikube: 68.7s

Times for Minikube (PR 10853): 68.9s 68.8s 63.9s
Average time for Minikube (PR 10853): 67.2s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.1s     | 0.1s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 41.4s    | 41.3s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 9.2s     | 2.1s                |
| on Docker 20.10.4 ...                      |          |                     |
|   - Generating certificates                | 2.8s     | 4.0s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 11.1s    | 15.9s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.3s     | 1.6s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.7s     | 1.4s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 1.0s     | 1.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 28.7s 28.4s 28.5s
Average time for minikube: 28.5s

Times for Minikube (PR 10853): 31.8s 26.7s 30.2s
Average time for Minikube (PR 10853): 29.6s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 10.7s    | 12.0s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 16.1s    | 15.9s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.2s     | 1.1s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

minikube-pr-bot · 2021-03-25T00:11:03Z

kvm2 Driver
Times for minikube: 70.1s 67.4s 67.0s
Average time for minikube: 68.2s

Times for Minikube (PR 10853): 68.0s 64.8s 66.6s
Average time for Minikube (PR 10853): 66.4s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.1s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 41.1s    | 40.5s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 2.0s     | 16.3s               |
| on Docker 20.10.4 ...                      |          |                     |
|   - Generating certificates                | 4.6s     | 1.2s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 15.8s    | 5.2s                |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.6s     | 0.9s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.6s     | 1.3s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 1.3s     | 0.6s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 29.0s 29.3s 28.1s
Average time for minikube: 28.8s

Times for Minikube (PR 10853): 29.4s 31.0s 32.9s
Average time for Minikube (PR 10853): 31.1s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 10.4s    | 13.6s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 16.6s    | 15.5s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.2s     | 1.4s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

test/integration/addons_test.go

minikube-pr-bot · 2021-03-25T00:30:14Z

kvm2 Driver
Times for minikube: 64.7s 65.9s 65.8s
Average time for minikube: 65.5s

Times for Minikube (PR 10853): 63.6s 65.4s 63.2s
Average time for Minikube (PR 10853): 64.0s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.1s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 39.9s    | 39.9s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 1.9s     | 2.1s                |
| on Docker 20.10.4 ...                      |          |                     |
|   - Generating certificates                | 4.6s     | 4.1s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 15.3s    | 14.5s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.5s     | 1.4s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.3s     | 1.4s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.5s     | 0.6s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 27.6s 26.7s 27.4s
Average time for minikube: 27.2s

Times for Minikube (PR 10853): 27.7s 26.8s 25.9s
Average time for Minikube (PR 10853): 26.8s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10853) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 9.7s     | 9.8s                |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.9s    | 15.2s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.1s     | 1.3s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

sharifelgamal · 2021-03-25T17:25:46Z

/ok-to-test

k8s-ci-robot · 2021-03-25T18:39:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilya-zuyev, medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ilya-zuyev,medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sharifelgamal added 5 commits March 10, 2021 15:16

Merge branch 'auth-gce' of github.com:sharifelgamal/minikube into gcr…

1537bac

…-auth

Merge branch 'master' of github.com:kubernetes/minikube into gcr-auth

2e3c797

add creds for docker pull to gcp-auth

294f044

Merge branch 'master' of github.com:kubernetes/minikube into gcr-auth

cfd9556

use token source instead of json directly

24457b1

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 17, 2021

k8s-ci-robot requested review from afbjorklund and tstromberg March 17, 2021 02:19

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 17, 2021

sharifelgamal added 2 commits March 17, 2021 13:39

delete secret on disable

da1477f

remove namespace mutator

419db88

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2021

sharifelgamal added 2 commits March 18, 2021 23:12

lint

bd71b3d

switch gcp-auth pull policy back to ifnotpresent

bcd8867

sharifelgamal changed the title ~~WIP: create registry credentials when gcp-auth addon is enabled~~ create registry credentials when gcp-auth addon is enabled Mar 19, 2021

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2021

ilya-zuyev approved these changes Mar 19, 2021

View reviewed changes

update gcp-auth-webhook to v0.0.5

103e0e9

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 19, 2021

medyagh reviewed Mar 21, 2021

View reviewed changes

cmd/minikube/cmd/config/profile_list.go Outdated Show resolved Hide resolved

revert unrelated change

020c2f1

kubernetes deleted a comment from minikube-pr-bot Mar 22, 2021

allow tests to pass with dummy creds

36deb4c

don't fail if token isn't valid

1767631

Merge branch 'master' of github.com:kubernetes/minikube into gcr-auth

afccdd2

Merge branch 'master' of github.com:kubernetes/minikube into gcr-auth

3b43d8e

sharifelgamal added 3 commits March 24, 2021 13:47

account for new API, add extra checks for stability

af57dbc

remove unnecessary exits

03b3113

break

73641d2

medyagh requested changes Mar 24, 2021

View reviewed changes

allow access to artifact registry as well

63b43cc

add integration test for pulling private image

0bfee47

sharifelgamal added 2 commits March 24, 2021 16:52

fix up tests for GCE

c7a4605

actual valid yaml would be nice

4791950

fix lint

df4224a

medyagh reviewed Mar 25, 2021

View reviewed changes

test/integration/addons_test.go Show resolved Hide resolved

medyagh approved these changes Mar 25, 2021

View reviewed changes

sharifelgamal merged commit 700ff6a into kubernetes:master Mar 25, 2021

ilya-zuyev changed the title ~~create registry credentials when gcp-auth addon is enabled~~ GCP-Auth addon: Add support for GCR creds Apr 5, 2021

medyagh mentioned this pull request Apr 5, 2021

registry-creds: Add support for Google Artifact Registry #9259

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GCP-Auth addon: Add support for GCR creds #10853

GCP-Auth addon: Add support for GCR creds #10853

sharifelgamal commented Mar 17, 2021 •

edited

Loading

ilya-zuyev left a comment

sharifelgamal commented Mar 19, 2021

minikube-pr-bot commented Mar 22, 2021

minikube-pr-bot commented Mar 23, 2021

minikube-pr-bot commented Mar 23, 2021

minikube-pr-bot commented Mar 23, 2021

sharifelgamal commented Mar 23, 2021

minikube-pr-bot commented Mar 24, 2021

medyagh left a comment

minikube-pr-bot commented Mar 24, 2021

minikube-pr-bot commented Mar 24, 2021

minikube-pr-bot commented Mar 24, 2021

minikube-pr-bot commented Mar 25, 2021

minikube-pr-bot commented Mar 25, 2021

sharifelgamal commented Mar 25, 2021

k8s-ci-robot commented Mar 25, 2021

GCP-Auth addon: Add support for GCR creds #10853

GCP-Auth addon: Add support for GCR creds #10853

Conversation

sharifelgamal commented Mar 17, 2021 • edited Loading

ilya-zuyev left a comment

Choose a reason for hiding this comment

sharifelgamal commented Mar 19, 2021

minikube-pr-bot commented Mar 22, 2021

minikube-pr-bot commented Mar 23, 2021

minikube-pr-bot commented Mar 23, 2021

minikube-pr-bot commented Mar 23, 2021

sharifelgamal commented Mar 23, 2021

minikube-pr-bot commented Mar 24, 2021

medyagh left a comment

Choose a reason for hiding this comment

minikube-pr-bot commented Mar 24, 2021

minikube-pr-bot commented Mar 24, 2021

minikube-pr-bot commented Mar 24, 2021

minikube-pr-bot commented Mar 25, 2021

minikube-pr-bot commented Mar 25, 2021

sharifelgamal commented Mar 25, 2021

k8s-ci-robot commented Mar 25, 2021

sharifelgamal commented Mar 17, 2021 •

edited

Loading