Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for systemd cgroup to containerd runtime #10100

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Add support for systemd cgroup to containerd runtime #10100

merged 2 commits into from
Jan 7, 2021

Conversation

priyawadhwa
Copy link

The --force-systemd flag will now work with the containerd runtime.

Tested on Cloud Shell, started in ~45 seconds, comparable to other runtimes.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 6, 2021
@priyawadhwa
Copy link
Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 6, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2021
medyagh
medyagh approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,priyawadhwa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@priyawadhwa priyawadhwa merged commit 857e0a2 into kubernetes:master Jan 7, 2021
@priyawadhwa priyawadhwa deleted the force-systemd-containerd branch January 7, 2021 19:26
@priyawadhwa priyawadhwa changed the title Add support for systemd cgroup to containerd runtime integration testing: Add support for systemd cgroup to containerd runtime Feb 19, 2021
@priyawadhwa priyawadhwa changed the title integration testing: Add support for systemd cgroup to containerd runtime Add support for systemd cgroup to containerd runtime Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@ilya-zuyev ilya-zuyev Awaiting requested review from ilya-zuyev

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@priyawadhwa @k8s-ci-robot @medyagh