-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoreDNS early scale down to 1 replica #10656
Conversation
Can one of the admins verify this patch? |
/ok-to-test |
/ok-to-test |
kvm2 Driver Times for Minikube (PR 10656): 72.0s 68.3s 71.9s Averages Time Per Log
docker Driver Times for Minikube (PR 10656): 28.2s 26.7s 28.1s Averages Time Per Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, prezha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #10655
this pr proposes to scale down the number of CoreDNS replica to 1 immediately after the master node is initialised, thus stabilising the whole system faster
also, metrics got a bit better (-5sec; both pr's
out
and releasedminikube-rls
are based on the latest v1.18.0-beta.0):