Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore kube-cross build image and bump go to version 1.16 #10691

Merged
merged 9 commits into from
Mar 4, 2021
Merged

restore kube-cross build image and bump go to version 1.16 #10691

merged 9 commits into from
Mar 4, 2021

Conversation

ilya-zuyev
Copy link
Contributor

@ilya-zuyev ilya-zuyev commented Mar 2, 2021 •
edited
Loading

closes #10276

This PR restores BUILD_IMAGE to us.gcr.io/k8s-artifacts-prod/build-image/kube-cross:v1.16.0-1 and updates go.mod file and CI scripts to use 1.16 version

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 2, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2021
@ilya-zuyev
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 2, 2021
@ilya-zuyev
Copy link
Contributor Author

/ok-to-build-image

@ilya-zuyev ilya-zuyev changed the title Bump go version to 1.16 restore kube-cross build image Mar 2, 2021
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10691): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10691/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10691/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10691): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10691/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10691/minikube: exec format error

medyagh
medyagh requested changes Mar 2, 2021
View reviewed changes
Makefile Show resolved Hide resolved
go.mod Show resolved Hide resolved
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10691): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10691/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10691/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10691): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10691/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10691/minikube: exec format error

@sharifelgamal
Copy link
Collaborator

ok-to-build-image

@medyagh
Copy link
Member

medyagh commented Mar 2, 2021

failed on jenkins
https://a646c87040050000000000000000001.proxy.googleprod.com/job/Build_Cross/17003/console

@minikube-bot
Copy link
Collaborator

Hi @ilya-zuyev, building a new kicbase image failed, please try again.

@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10691): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10691/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10691/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10691): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10691/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10691/minikube: exec format error

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 71.5s 70.7s 70.6s
Average time for minikube: 70.9s

Times for Minikube (PR 10691): 71.2s 68.9s 69.5s
Average time for Minikube (PR 10691): 69.9s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10691) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.0 on Debian               | 0.0s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 44.5s    | 43.3s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 16.6s    | 9.3s                |
| on Docker 20.10.3 ...                      |          |                     |
|   - Generating certificates                | 1.0s     | 2.5s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 5.4s     | 10.8s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 0.9s     | 1.3s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.7s     | 1.7s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.8s     | 0.9s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 27.7s 27.6s 26.1s
Average time for minikube: 27.1s

Times for Minikube (PR 10691): 27.7s 27.6s 28.3s
Average time for Minikube (PR 10691): 27.8s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10691) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.0 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 9.7s     | 10.3s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.8s    | 15.9s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.0s     | 1.1s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

medyagh
medyagh requested changes Mar 3, 2021
View reviewed changes
Makefile Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 3, 2021
@ilya-zuyev ilya-zuyev mentioned this pull request Mar 3, 2021
Closed
@ilya-zuyev ilya-zuyev changed the title restore kube-cross build image restore kube-cross build image and bump go to version 1.16 Mar 3, 2021
@ilya-zuyev ilya-zuyev requested a review from medyagh March 3, 2021 22:20
@medyagh
Copy link
Member

medyagh commented Mar 3, 2021

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilya-zuyev, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 79.6s 68.8s 68.7s
Average time for minikube: 72.4s

Times for Minikube (PR 10691): 69.1s 71.7s 71.2s
Average time for Minikube (PR 10691): 70.7s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10691) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.0 on Debian               | 1.8s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 44.2s    | 43.3s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 23.7s    | 2.4s                |
| on Docker 20.10.3 ...                      |          |                     |
|   - Generating certificates                | 0.0s     | 4.5s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 0.0s     | 16.0s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 0.5s     | 1.7s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.7s     | 1.7s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.5s     | 0.8s                |
| default-storageclass,                      |          |                     |
| storage-provisioner                        |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 26.6s 27.3s 26.1s
Average time for minikube: 26.7s

Times for Minikube (PR 10691): 26.3s 27.3s 26.6s
Average time for Minikube (PR 10691): 26.7s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10691) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.0 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 9.7s     | 9.9s                |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.4s    | 15.4s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.0s     | 0.9s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

@medyagh medyagh merged commit bdd50a4 into kubernetes:master Mar 4, 2021
@fmotrifork fmotrifork mentioned this pull request Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@RA489 RA489 Awaiting requested review from RA489

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. pr_verified size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore BUILD_IMAGE value to 'kube-cross'
6 participants
@ilya-zuyev @minikube-pr-bot @sharifelgamal @medyagh @minikube-bot @k8s-ci-robot