-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install losetup from util-linux in the ISO to enable support for VolumeMode=Block PVCs #10704
Conversation
Hi @nixpanic. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
@nixpanic, can you rebase against upstream? Once you do, we can properly run our iso tests. |
The losetup tool is used by Kubernetes to setup BlockMode volumes. BusyBox provides a version, but it does not have the `-j` option.
d5d54d2
to
631e45a
Compare
Done, thanks. |
ok-to-build-iso |
Hi @nixpanic, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
/ok-to-test |
kvm2 Driver |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, nixpanic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thank you @nixpanic this will be included on the next release meanwhile feel free to use the latest binary on the head https://storage.googleapis.com/minikube/latest/minikube-linux-amd64 |
The losetup tool is used by Kubernetes to setup BlockMode volumes.
BusyBox provides a version, but it does not have the
-j
option.This was approved and merged earlier through #10255, until #10286 reverted it for unclear reasons.
Fixes: #8284 (again)