-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker-env & podman-env: silent output when talking to a shell #10763
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If the output is not a terminal, then assume that we are running docker-env or podman-env under "eval" or similar shell construct. So don't output all the interactive information, but only return the actual exit code for some further troubleshooting (perhaps).
6c54200
to
5e566d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afbjorklund could u plz post the before and after this PR in description ?
I think this worth an integration test, how about adding one in the DockerEnv Test?
Already done, see #10761 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding an integraiton test will ensure we will never break this
how about adding one here in validateDockerEnv
https://github.com/medyagh/minikube/blob/8da592988da45acfc93cef2637e79a8bfa4ad570/test/integration/functional_test.go#L216
/ok-to-test |
kvm2 Driver |
If the output is not a terminal, then assume that we are running
docker-env or podman-env under "eval" or similar shell construct.
So don't output all the interactive information, but only return
the actual exit code for some further troubleshooting (perhaps).
Closes #10761
BEFORE
or, even worse:
AFTER