-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix driver.IndexFromMachineName() #10821
fix driver.IndexFromMachineName() #10821
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prezha, spowelljr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
kvm2 Driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, lgtm
fixes #10820
as detailed in the issue's description, this pr fixes driver.IndexFromMachineName() and extends the tests to cover for noted edge cases