Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new flag --ssh for minikube kubectl to allow running it over the ssh connection #10844

Merged
merged 6 commits into from
Mar 23, 2021
Merged

new flag --ssh for minikube kubectl to allow running it over the ssh connection #10844

merged 6 commits into from
Mar 23, 2021

Conversation

afbjorklund
Copy link
Collaborator

Closes #10843

@afbjorklund
Don't use the generic path name for a variable
eec6f05 
It conflicts with the system "path" in module
@afbjorklund
Allow running kubectl over the ssh connection
78bc248 
The default is to run kubernetes client locally
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 16, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 16, 2021
medyagh
medyagh requested changes Mar 16, 2021
View reviewed changes
cmd/minikube/cmd/kubectl.go Outdated Show resolved Hide resolved
@afbjorklund
Make --help work when running minikube as kubectl
e7f568a 
Avoid the "magic" cobra.Command parsing of --help,
and pass all flags as-is to the kubectl command.

Use "minikube kubectl" if you want to set flags,
and "kubectl" if you just want to run Kubernetes.
@afbjorklund
Generate docs for commands to make test happy
15e422d
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2021
@medyagh medyagh merged commit 7a47f16 into kubernetes:master Mar 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh changed the title Allow running kubectl over the ssh connection new flag --sh for minikube kubectl to allow running kubectl over the ssh connection Mar 23, 2021
@medyagh medyagh changed the title new flag --sh for minikube kubectl to allow running kubectl over the ssh connection new flag --ssh for minikube kubectl to allow running it over the ssh connection Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for running kubectl remotely as an alternative
3 participants
@afbjorklund @k8s-ci-robot @medyagh