Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: return error on invalid function name in extract.TranslatableStrings #11454

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

janisz
Copy link
Contributor

@janisz janisz commented May 19, 2021

Wrap returns an error annotating err with a stack trace at the point Wrap is called,
and the supplied message. If err is nil, Wrap returns nil.
https://pkg.go.dev/github.com/pkg/errors#Wrap

97e2cd1#r51011973

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 19, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @janisz!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 19, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @janisz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 19, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@janisz
Copy link
Contributor Author

janisz commented May 19, 2021

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 19, 2021
@janisz
Copy link
Contributor Author

janisz commented May 21, 2021

@prasadkatti @sharifelgamal Can you take a look?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janisz, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2021
@medyagh
Copy link
Member

medyagh commented May 21, 2021

nice catch @janisz look forward to see more PRs from you

@sharifelgamal
Copy link
Collaborator

@janisz fix the lint error and we can get this merged. thanks again!

> Wrap returns an error annotating err with a stack trace at the point Wrap is called,
 and the supplied message. If err is nil, Wrap returns nil.
https://pkg.go.dev/github.com/pkg/errors#Wrap
@janisz
Copy link
Contributor Author

janisz commented May 24, 2021

@sharifelgamal I fiexd it. Could you run tests again.

@janisz
Copy link
Contributor Author

janisz commented May 28, 2021

@medyagh @sharifelgamal Can you rerun the CI

@sharifelgamal sharifelgamal merged commit 47dbbd5 into kubernetes:master Jun 2, 2021
@janisz janisz deleted the fix_extract_error branch June 3, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants