Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)" #2 #11632

ilya-zuyev · 2021-06-11T02:23:40Z

Another attempt to update containerd config (previous one: #11561)

no_pivot_root option removed: [plugins.cri.containerd.default_runtime.options] NoPivotRoot = true
cgroups configuration changed according to how to configure systemd cgroup with 1.3.X how to configure systemd cgroup with 1.3.X containerd/containerd#4203 (comment)
KillMode for containerd systemd service changed from process to mixed. The previous value lead to 90 sec delay on minikube stop for kvm driver (SIGTERM wasn't sent to ctrd shim processes)
PollWait added when checking for kubeapi server status on minikube restart. We restart containerd service, it lead to restart of all pods, including apiserver. Later we check its status and there is a chance, that apiserver restart is not complete yet. (timing for the new runc is different)

ilya-zuyev · 2021-06-11T02:23:54Z

ok-to-build-iso

minikube-bot · 2021-06-11T03:28:03Z

Hi @ilya-zuyev, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

ilya-zuyev · 2021-06-11T04:27:15Z

/ok-to-test

minikube-pr-bot · 2021-06-11T05:11:24Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 48.2s    | 48.3s               |
| enable ingress | 35.6s    | 40.0s               |
+----------------+----------+---------------------+

Times for minikube start: 49.0s 47.3s 47.8s 49.4s 47.5s
Times for minikube (PR 11632) start: 46.8s 48.2s 48.3s 50.4s 47.5s

Times for minikube ingress: 37.2s 35.7s 34.2s 33.8s 37.3s
Times for minikube (PR 11632) ingress: 42.7s 42.3s 36.2s 36.2s 42.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 21.8s               |
| enable ingress | 35.7s    | 35.7s               |
+----------------+----------+---------------------+

Times for minikube start: 22.0s 21.9s 21.6s 22.3s 23.4s
Times for minikube (PR 11632) start: 21.9s 22.1s 21.5s 21.8s 21.6s

Times for minikube ingress: 32.5s 37.4s 35.0s 35.5s 38.0s
Times for minikube (PR 11632) ingress: 35.5s 34.5s 38.5s 36.5s 33.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 40.6s    | 44.9s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.8s 42.1s 43.0s 42.7s 43.3s
Times for minikube (PR 11632) start: 47.3s 43.1s 46.9s 43.8s 43.5s

…imeout' into ilyaz/fix_vm_ctrd_timeout

minikube-pr-bot · 2021-06-11T07:01:36Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 47.0s    | 46.6s               |
| enable ingress | 34.2s    | 34.1s               |
+----------------+----------+---------------------+

Times for minikube start: 47.5s 46.6s 47.1s 46.4s 47.5s
Times for minikube (PR 11632) start: 47.1s 47.2s 46.4s 45.5s 47.0s

Times for minikube ingress: 35.3s 33.1s 34.3s 34.7s 33.7s
Times for minikube (PR 11632) ingress: 33.2s 34.8s 33.7s 33.7s 35.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 21.2s               |
| enable ingress | 40.6s    | 30.7s               |
+----------------+----------+---------------------+

Times for minikube start: 22.4s 21.5s 21.5s 21.6s 21.6s
Times for minikube (PR 11632) start: 21.1s 21.4s 21.4s 21.4s 20.7s

Times for minikube ingress: 29.5s 27.5s 28.0s 30.0s 88.0s
Times for minikube (PR 11632) ingress: 32.0s 29.0s 30.5s 32.5s 29.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 41.5s    | 45.5s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.4s 46.8s 43.1s 43.2s 43.1s
Times for minikube (PR 11632) start: 47.1s 43.4s 46.9s 43.1s 46.9s

minikube-pr-bot · 2021-06-11T22:25:29Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 50.3s    | 48.5s               |
| enable ingress | 35.0s    | 33.9s               |
+----------------+----------+---------------------+

Times for minikube start: 53.5s 47.7s 50.1s 53.4s 46.6s
Times for minikube (PR 11632) start: 48.7s 48.0s 49.4s 47.2s 49.2s

Times for minikube ingress: 33.8s 36.3s 33.4s 35.9s 35.7s
Times for minikube (PR 11632) ingress: 34.8s 33.2s 33.8s 34.3s 33.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 21.8s               |
| enable ingress | 30.3s    | 29.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 11632) start: 22.3s 21.8s 22.4s 20.7s 21.7s
Times for minikube start: 21.8s 22.1s 22.3s 23.0s 21.8s

Times for minikube ingress: 31.0s 32.5s 30.0s 29.0s 29.0s
Times for minikube (PR 11632) ingress: 28.5s 27.0s 34.0s 29.0s 29.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 45.2s    | 46.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 44.1s 43.6s 48.0s 43.3s 47.1s
Times for minikube (PR 11632) start: 43.3s 47.7s 48.1s 43.5s 47.8s

minikube-pr-bot · 2021-06-12T00:13:10Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 48.1s    | 48.1s               |
| enable ingress | 36.5s    | 37.8s               |
+----------------+----------+---------------------+

Times for minikube start: 48.0s 49.3s 47.3s 46.3s 49.4s
Times for minikube (PR 11632) start: 46.4s 51.1s 47.4s 47.7s 47.9s

Times for minikube ingress: 34.2s 34.7s 35.8s 36.3s 41.7s
Times for minikube (PR 11632) ingress: 41.2s 34.8s 43.2s 34.7s 35.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 22.0s               |
| enable ingress | 35.3s    | 35.7s               |
+----------------+----------+---------------------+

Times for minikube start: 23.8s 22.3s 22.0s 21.6s 21.8s
Times for minikube (PR 11632) start: 22.3s 21.6s 22.8s 22.4s 21.2s

Times for minikube ingress: 35.5s 33.0s 33.0s 33.5s 41.5s
Times for minikube (PR 11632) ingress: 33.0s 36.0s 33.5s 41.5s 34.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 41.6s    | 44.9s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 30.8s 43.2s 43.7s 43.3s 46.9s
Times for minikube (PR 11632) start: 47.1s 43.1s 43.8s 47.5s 43.2s

minikube-pr-bot · 2021-06-12T02:05:39Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 47.8s    | 48.4s               |
| enable ingress | 35.3s    | 33.4s               |
+----------------+----------+---------------------+

Times for minikube start: 48.3s 46.3s 46.5s 46.6s 51.3s
Times for minikube (PR 11632) start: 49.2s 47.6s 47.8s 50.2s 47.2s

Times for minikube ingress: 35.2s 34.3s 34.7s 37.7s 34.7s
Times for minikube (PR 11632) ingress: 32.7s 33.7s 32.7s 34.2s 33.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.5s               |
| enable ingress | 31.4s    | 29.8s               |
+----------------+----------+---------------------+

Times for minikube start: 22.0s 21.7s 21.3s 21.3s 21.6s
Times for minikube (PR 11632) start: 20.5s 21.7s 21.9s 21.6s 21.9s

Times for minikube (PR 11632) ingress: 29.5s 29.0s 32.0s 29.0s 29.5s
Times for minikube ingress: 30.9s 36.5s 27.5s 32.0s 30.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 42.2s    | 44.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 30.6s 43.1s 47.4s 43.0s 46.8s
Times for minikube (PR 11632) start: 43.1s 47.4s 43.0s 47.5s 43.0s

sharifelgamal · 2021-06-14T17:48:42Z

Might fix #11512

ilya-zuyev · 2021-06-14T21:59:26Z

/ok-to-test

minikube-pr-bot · 2021-06-14T23:02:39Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 46.9s    | 46.8s               |
| enable ingress | 36.8s    | 36.9s               |
+----------------+----------+---------------------+

Times for minikube start: 47.3s 47.2s 47.7s 46.4s 45.8s
Times for minikube (PR 11632) start: 48.1s 46.0s 47.1s 46.5s 46.4s

Times for minikube ingress: 35.2s 36.1s 35.3s 35.2s 42.2s
Times for minikube (PR 11632) ingress: 35.2s 37.8s 35.7s 42.3s 33.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 21.8s               |
| enable ingress | 34.5s    | 35.4s               |
+----------------+----------+---------------------+

Times for minikube start: 21.2s 21.3s 20.6s 22.3s 22.2s
Times for minikube (PR 11632) start: 22.2s 21.4s 21.9s 21.6s 21.9s

Times for minikube ingress: 35.0s 37.5s 33.5s 32.9s 33.5s
Times for minikube (PR 11632) ingress: 35.5s 33.0s 37.0s 34.0s 37.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 45.5s    | 44.4s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 46.8s 46.7s 43.7s 43.2s 47.1s
Times for minikube (PR 11632) start: 43.3s 43.7s 44.1s 47.3s 43.3s

ilya-zuyev · 2021-06-15T00:40:36Z

integration tests Test*BinaryUpgrade are failing:

Jun 15 00:37:47 test-foo containerd[28515]: time="2021-06-15T00:37:47.951529929Z" level=error msg="RunPodSandbox for &PodSandboxMetadata{Name:kube-apiserver-test -foo,Uid:022743265a20fd457df0a34731943068,Namespace:kube-system,Attempt:0,} failed, error" error="failed to create containerd task: runtime "io.containerd.runc.v 2" binary not installed "containerd-shim-runc-v2": file does not exist: unknown"

minikube-pr-bot · 2021-06-15T02:09:08Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 48.0s    | 47.4s               |
| enable ingress | 33.4s    | 34.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 33.7s 34.2s 33.7s 32.8s 32.8s
Times for minikube (PR 11632) ingress: 35.7s 33.3s 33.8s 36.7s 35.2s

Times for minikube (PR 11632) start: 46.6s 49.1s 46.3s 46.9s 48.0s
Times for minikube start: 52.2s 46.5s 47.4s 46.6s 47.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.7s               |
| enable ingress | 29.7s    | 29.9s               |
+----------------+----------+---------------------+

Times for minikube start: 22.4s 21.1s 21.7s 22.1s 21.5s
Times for minikube (PR 11632) start: 20.7s 22.1s 21.3s 22.4s 21.9s

Times for minikube (PR 11632) ingress: 30.0s 30.0s 31.5s 28.0s 30.0s
Times for minikube ingress: 29.5s 28.5s 30.5s 32.5s 27.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 42.2s    | 45.5s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.2s 43.0s 47.2s 46.9s 42.8s
Times for minikube (PR 11632) start: 46.3s 47.2s 43.3s 43.3s 47.6s

minikube-bot · 2021-06-22T20:49:55Z

These are the flake rates of all failed tests on Docker_Linux_containerd.

Failed Tests	Flake Rate (%)
TestPause/serial/SecondStartNoReconfiguration	1.19 (chart)
TestFunctional/parallel/InternationalLanguage	8.33 (chart)

minikube-bot · 2021-06-22T21:05:56Z

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests	Flake Rate (%)
TestPause/serial/SecondStartNoReconfiguration	1.22 (chart)
TestFunctional/parallel/InternationalLanguage	8.33 (chart)

minikube-pr-bot · 2021-06-23T00:26:09Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 49.4s    | 50.0s               |
| enable ingress | 34.7s    | 34.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 35.4s 34.7s 32.7s 34.8s 35.8s
Times for minikube (PR 11632) ingress: 33.3s 35.2s 33.3s 34.8s 34.3s

Times for minikube start: 53.0s 48.1s 47.4s 50.5s 47.8s
Times for minikube (PR 11632) start: 50.7s 50.5s 49.8s 47.7s 51.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 22.4s    | 22.4s               |
| enable ingress | 29.3s    | 29.6s               |
+----------------+----------+---------------------+

Times for minikube start: 22.3s 21.7s 23.1s 22.4s 22.6s
Times for minikube (PR 11632) start: 22.4s 22.4s 22.9s 22.4s 21.8s

Times for minikube ingress: 28.0s 29.0s 30.5s 29.5s 29.5s
Times for minikube (PR 11632) ingress: 29.0s 27.0s 33.5s 29.0s 29.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 45.6s    | 46.9s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube (PR 11632) start: 48.2s 48.3s 47.1s 44.0s 47.1s
Times for minikube start: 45.9s 48.9s 42.6s 47.3s 43.3s

minikube-bot · 2021-06-23T00:40:04Z

These are the flake rates of all failed tests on Docker_Linux.

Failed Tests	Flake Rate (%)
TestPause/serial/SecondStartNoReconfiguration	0.00 (chart)

minikube-bot · 2021-06-23T00:46:44Z

These are the flake rates of all failed tests on Docker_Linux_containerd.

Failed Tests	Flake Rate (%)
TestPause/serial/SecondStartNoReconfiguration	1.15 (chart)

minikube-bot · 2021-06-23T00:56:05Z

These are the flake rates of all failed tests on KVM_Linux.

Failed Tests	Flake Rate (%)
TestPause/serial/SecondStartNoReconfiguration	0.00 (chart)

minikube-bot · 2021-06-23T00:58:54Z

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests	Flake Rate (%)
TestPause/serial/SecondStartNoReconfiguration	1.20 (chart)

minikube-bot · 2021-06-23T02:18:40Z

These are the flake rates of all failed tests on Docker_Linux.

Failed Tests	Flake Rate (%)
TestPause/serial/SecondStartNoReconfiguration	0.00 (chart)

minikube-pr-bot · 2021-06-23T02:22:14Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 50.3s    | 52.7s               |
| enable ingress | 39.4s    | 36.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 41.8s 43.5s 42.8s 34.4s 34.3s
Times for minikube (PR 11632) ingress: 34.7s 35.0s 42.8s 34.3s 34.8s

Times for minikube start: 48.1s 48.8s 51.5s 51.1s 51.8s
Times for minikube (PR 11632) start: 51.0s 54.4s 56.3s 49.7s 52.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 22.4s               |
| enable ingress | 31.8s    | 33.8s               |
+----------------+----------+---------------------+

Times for minikube (PR 11632) ingress: 33.5s 38.6s 31.6s 34.0s 31.5s
Times for minikube ingress: 32.1s 32.5s 30.5s 33.0s 31.0s

Times for minikube (PR 11632) start: 21.9s 22.1s 23.0s 22.2s 23.0s
Times for minikube start: 23.1s 22.1s 22.1s 22.6s 22.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 41.5s    | 44.9s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.8s 43.8s 43.5s 44.1s 43.5s
Times for minikube (PR 11632) start: 47.4s 43.9s 43.4s 45.0s 45.0s

minikube-bot · 2021-06-23T02:25:55Z

These are the flake rates of all failed tests on Docker_Linux_containerd.

Failed Tests	Flake Rate (%)
TestPause/serial/SecondStartNoReconfiguration	1.16 (chart)

minikube-bot · 2021-06-23T02:35:12Z

These are the flake rates of all failed tests on KVM_Linux.

Failed Tests	Flake Rate (%)
TestPause/serial/SecondStartNoReconfiguration	0.00 (chart)

minikube-bot · 2021-06-23T02:47:10Z

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests	Flake Rate (%)
TestPause/serial/SecondStartNoReconfiguration	1.19 (chart)

minikube-pr-bot · 2021-06-23T06:06:00Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 48.2s    | 48.2s               |
| enable ingress | 35.3s    | 34.2s               |
+----------------+----------+---------------------+

Times for minikube start: 48.5s 47.1s 49.8s 45.2s 50.5s
Times for minikube (PR 11632) start: 49.2s 48.1s 50.1s 46.6s 47.2s

Times for minikube ingress: 34.9s 34.7s 35.7s 35.2s 35.8s
Times for minikube (PR 11632) ingress: 35.3s 34.2s 33.7s 33.7s 34.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 22.2s               |
| enable ingress | 29.2s    | 29.4s               |
+----------------+----------+---------------------+

Times for minikube start: 23.1s 21.2s 21.4s 21.8s 22.4s
Times for minikube (PR 11632) start: 22.9s 21.4s 22.4s 23.3s 21.1s

Times for minikube ingress: 32.0s 27.5s 28.5s 30.0s 28.0s
Times for minikube (PR 11632) ingress: 29.0s 28.0s 28.5s 31.0s 30.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 42.0s    | 41.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.5s 47.7s 43.7s 43.7s 43.3s
Times for minikube (PR 11632) start: 31.4s 43.2s 43.3s 43.4s 47.2s

minikube-bot · 2021-06-23T06:20:15Z

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests	Flake Rate (%)
TestPause/serial/SecondStartNoReconfiguration	1.16 (chart)
TestPause/serial/PauseAgain	16.28 (chart)

minikube-pr-bot · 2021-06-23T19:19:11Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 48.1s    | 46.9s               |
| enable ingress | 34.6s    | 34.5s               |
+----------------+----------+---------------------+

Times for minikube start: 47.4s 48.2s 46.0s 47.7s 51.1s
Times for minikube (PR 11632) start: 48.6s 47.5s 46.0s 46.2s 46.1s

Times for minikube ingress: 34.7s 34.8s 35.2s 33.8s 34.4s
Times for minikube (PR 11632) ingress: 34.7s 36.7s 34.3s 33.7s 33.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.8s               |
| enable ingress | 30.5s    | 29.9s               |
+----------------+----------+---------------------+

Times for minikube start: 21.9s 21.1s 21.9s 21.3s 21.9s
Times for minikube (PR 11632) start: 21.6s 21.4s 21.8s 22.4s 21.5s

Times for minikube (PR 11632) ingress: 31.0s 28.5s 29.5s 29.0s 31.5s
Times for minikube ingress: 31.0s 33.1s 30.5s 29.5s 28.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 45.7s    | 45.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 47.7s 47.2s 43.4s 47.4s 42.9s
Times for minikube (PR 11632) start: 47.5s 43.3s 46.8s 43.1s 47.2s

minikube-bot · 2021-06-23T19:31:28Z

These are the flake rates of all failed tests on Docker_Linux_containerd.

Failed Tests	Flake Rate (%)
TestAddons/parallel/Olm	2.17 (chart)
TestFunctional/parallel/LogsCmd	4.35 (chart)
TestFunctional/parallel/LogsFileCmd	4.35 (chart)

medyagh · 2021-06-23T19:32:58Z

@ilya-zuyev api health failure is saying 500 error I dont think increasing time limit would fix

consider rebasing the 40 commits for a cleaner history, only keep the relevant commits that actually made it it to the PR and remove debug ones

minikube-bot · 2021-06-23T19:38:43Z

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests	Flake Rate (%)
TestPause/serial/SecondStartNoReconfiguration	1.11 (chart)

minikube-pr-bot · 2021-06-23T21:29:33Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 47.3s    | 46.7s               |
| enable ingress | 36.1s    | 35.7s               |
+----------------+----------+---------------------+

Times for minikube start: 48.0s 47.7s 46.0s 48.5s 46.2s
Times for minikube (PR 11632) start: 47.9s 46.8s 46.7s 45.5s 46.8s

Times for minikube ingress: 34.7s 34.3s 42.7s 34.2s 34.7s
Times for minikube (PR 11632) ingress: 42.3s 34.2s 34.2s 34.2s 33.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.7s               |
| enable ingress | 34.8s    | 36.5s               |
+----------------+----------+---------------------+

Times for minikube start: 22.8s 21.2s 20.6s 22.4s 21.8s
Times for minikube (PR 11632) start: 21.5s 21.6s 21.7s 21.5s 22.4s

Times for minikube ingress: 38.5s 32.5s 37.9s 32.5s 32.5s
Times for minikube (PR 11632) ingress: 33.0s 37.4s 41.5s 35.1s 35.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11632) |
+----------------+----------+---------------------+
| minikube start | 42.3s    | 45.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube (PR 11632) start: 47.0s 43.7s 43.5s 47.8s 43.6s
Times for minikube start: 31.0s 42.9s 46.7s 42.8s 48.2s

pkg/minikube/cluster/pause.go

medyagh

Thank you for the persistence that went through making this work !

good work !

k8s-ci-robot · 2021-06-24T21:09:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilya-zuyev, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ilya-zuyev,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ilya-zuyev added 2 commits June 10, 2021 19:21

Use KillMode=mixed for iso containerd

6dfbd6f

Restore containerd config

e6cd1d5

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 11, 2021

k8s-ci-robot requested review from sharifelgamal and spowelljr June 11, 2021 02:23

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2021

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 11, 2021

Updating ISO to v1.21.0-1623378770-11632

9d94dcb

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 11, 2021

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 11, 2021

ilya-zuyev added 2 commits June 10, 2021 23:03

fix int test

e50e9de

Merge remote-tracking branch 'refs/remotes/origin/ilyaz/fix_vm_ctrd_t…

c8a9cfa

…imeout' into ilyaz/fix_vm_ctrd_timeout

Add debug log

78a07e7

more debug stuff

9d64921

more debug stuff

9d65d85

check container runtime version for upgrades

dd5d8a3

cleanup

88ade35

temp change: increase apiServerHealthz timeout

8222cf9

revert debug timeout; fix state value

20e0783

try to increase api healthz wait timeout

829da69

try to increase api healthz wait timeout

f04da67

medyagh requested changes Jun 24, 2021

View reviewed changes

pkg/minikube/cluster/pause.go Show resolved Hide resolved

medyagh self-requested a review June 24, 2021 20:23

medyagh approved these changes Jun 24, 2021

View reviewed changes

medyagh merged commit cb2e8e1 into kubernetes:master Jun 24, 2021

sharifelgamal mentioned this pull request Jun 28, 2021

new containerd config causes KVM Containerd test to time out and Docker Containerd test addons to fail #11512

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)" #2 #11632

Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)" #2 #11632

ilya-zuyev commented Jun 11, 2021 •

edited

Loading

ilya-zuyev commented Jun 11, 2021

minikube-bot commented Jun 11, 2021

ilya-zuyev commented Jun 11, 2021

minikube-pr-bot commented Jun 11, 2021

minikube-pr-bot commented Jun 11, 2021

minikube-pr-bot commented Jun 11, 2021

minikube-pr-bot commented Jun 12, 2021

minikube-pr-bot commented Jun 12, 2021

sharifelgamal commented Jun 14, 2021

ilya-zuyev commented Jun 14, 2021

minikube-pr-bot commented Jun 14, 2021

ilya-zuyev commented Jun 15, 2021

minikube-pr-bot commented Jun 15, 2021

minikube-bot commented Jun 22, 2021

minikube-bot commented Jun 22, 2021

minikube-pr-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-pr-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-pr-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-pr-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

medyagh commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-pr-bot commented Jun 23, 2021

medyagh left a comment

k8s-ci-robot commented Jun 24, 2021

Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)" #2 #11632

Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)" #2 #11632

Conversation

ilya-zuyev commented Jun 11, 2021 • edited Loading

ilya-zuyev commented Jun 11, 2021

minikube-bot commented Jun 11, 2021

ilya-zuyev commented Jun 11, 2021

minikube-pr-bot commented Jun 11, 2021

minikube-pr-bot commented Jun 11, 2021

minikube-pr-bot commented Jun 11, 2021

minikube-pr-bot commented Jun 12, 2021

minikube-pr-bot commented Jun 12, 2021

sharifelgamal commented Jun 14, 2021

ilya-zuyev commented Jun 14, 2021

minikube-pr-bot commented Jun 14, 2021

ilya-zuyev commented Jun 15, 2021

minikube-pr-bot commented Jun 15, 2021

minikube-bot commented Jun 22, 2021

minikube-bot commented Jun 22, 2021

minikube-pr-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-pr-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-pr-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-pr-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

medyagh commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

minikube-pr-bot commented Jun 23, 2021

medyagh left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jun 24, 2021

ilya-zuyev commented Jun 11, 2021 •

edited

Loading