-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add addon support for portainer #11933
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @balasu! |
Hi @balasu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
Hi there! Thanks for contributing to minikube! Can you explain what the portainer addon is for in your PR description? You will also need to sign the CLA before we go forward with testing. |
|
Hi, please note i have signed the CLA for Portainer.io and Bala is a nominated member of our Org. |
Is your org the maintainer of the images being used? If so, can you add your org's name in the string after the addon name? |
Hi updated organization name, its pulling latest image from dockerhub repo and image update is maintained by portainer. users can raise the issues or queries related to add-on on portainer github or portainer community slack |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andriyDev, balasu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 56.5s 51.7s 53.6s 51.2s 50.0s Times for minikube ingress: 38.9s 32.8s 31.9s 38.8s 40.4s docker driver with docker runtime
Times for minikube ingress: 35.0s 37.1s 36.0s 30.0s 35.0s Times for minikube start: 22.6s 22.4s 22.8s 23.3s 22.6s docker driver with containerd runtime
Times for minikube start: 27.8s 45.8s 44.0s 44.0s 43.7s |
Portainer is a free, open source toolset for managing containerized applications. It works with Kubernetes, Docker, Docker Swarm, Azure ACI in both data centres and at the edge.
Portainer removes the complexity associated with orchestrators so developers can deploy apps quickly, easily and accurately. In addition to managing apps, it can be used to observe the behavior of containers, manage the underlying platform and provide the security and governance necessary for organization to deploy containers widely.
This add-on service will be enabled on nodeport 30777 and internally runs on 9000 port.