Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addon support for portainer #11933

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

balasu
Copy link
Contributor

@balasu balasu commented Jul 8, 2021

Portainer is a free, open source toolset for managing containerized applications. It works with Kubernetes, Docker, Docker Swarm, Azure ACI in both data centres and at the edge.

Portainer removes the complexity associated with orchestrators so developers can deploy apps quickly, easily and accurately. In addition to managing apps, it can be used to observe the behavior of containers, manage the underlying platform and provide the security and governance necessary for organization to deploy containers widely.
This add-on service will be enabled on nodeport 30777 and internally runs on 9000 port.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 8, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @balasu!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 8, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @balasu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@sharifelgamal
Copy link
Collaborator

Hi there! Thanks for contributing to minikube! Can you explain what the portainer addon is for in your PR description?

You will also need to sign the CLA before we go forward with testing.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 8, 2021
@balasu
Copy link
Contributor Author

balasu commented Jul 9, 2021

Hi there! Thanks for contributing to minikube! Can you explain what the portainer addon is for in your PR description?

You will also need to sign the CLA before we go forward with testing.
Hi Description is included and CLA is signed

@ncresswell
Copy link

Hi, please note i have signed the CLA for Portainer.io and Bala is a nominated member of our Org.

@andriyDev
Copy link
Contributor

Is your org the maintainer of the images being used? If so, can you add your org's name in the string after the addon name?

@balasu
Copy link
Contributor Author

balasu commented Jul 12, 2021

Is your org the maintainer of the images being used? If so, can you add your org's name in the string after the addon name?

Hi updated organization name, its pulling latest image from dockerhub repo and image update is maintained by portainer. users can raise the issues or queries related to add-on on portainer github or portainer community slack
https://github.com/portainer/portainer/issues

@andriyDev
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andriyDev, balasu
To complete the pull request process, please assign ilya-zuyev after the PR has been reviewed.
You can assign the PR to them by writing /assign @ilya-zuyev in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 12, 2021
@sharifelgamal sharifelgamal changed the title for portainer add-on Add addon support for portainer Jul 12, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11933) |
+----------------+----------+---------------------+
| minikube start | 52.6s    | 51.4s               |
| enable ingress | 36.5s    | 34.7s               |
+----------------+----------+---------------------+

Times for minikube start: 56.5s 51.7s 53.6s 51.2s 50.0s
Times for minikube (PR 11933) start: 53.9s 50.0s 54.0s 50.7s 48.4s

Times for minikube ingress: 38.9s 32.8s 31.9s 38.8s 40.4s
Times for minikube (PR 11933) ingress: 39.9s 31.3s 38.9s 31.9s 31.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11933) |
+----------------+----------+---------------------+
| minikube start | 22.7s    | 22.8s               |
| enable ingress | 34.6s    | 32.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 35.0s 37.1s 36.0s 30.0s 35.0s
Times for minikube (PR 11933) ingress: 35.0s 33.5s 30.5s 31.0s 34.5s

Times for minikube start: 22.6s 22.4s 22.8s 23.3s 22.6s
Times for minikube (PR 11933) start: 21.4s 23.4s 23.5s 22.4s 23.2s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11933) |
+----------------+----------+---------------------+
| minikube start | 41.1s    | 44.3s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 27.8s 45.8s 44.0s 44.0s 43.7s
Times for minikube (PR 11933) start: 44.5s 45.1s 44.0s 43.9s 43.9s

@sharifelgamal sharifelgamal merged commit 4c66799 into kubernetes:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants