Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure gcp-auth addon pull secret to work with all GCR and AR mirrors #12106

Merged
merged 4 commits into from
Aug 9, 2021
Merged

configure gcp-auth addon pull secret to work with all GCR and AR mirrors #12106

merged 4 commits into from
Aug 9, 2021

Conversation

sharifelgamal
Copy link
Collaborator

Fixes #12003

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 3, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2021
@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 3, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12106) |
+----------------+----------+---------------------+
| minikube start | 47.8s    | 47.4s               |
| enable ingress | 31.8s    | 35.6s               |
+----------------+----------+---------------------+

Times for minikube start: 50.1s 47.2s 47.5s 46.7s 47.7s
Times for minikube (PR 12106) start: 47.0s 48.3s 45.7s 48.7s 47.4s

Times for minikube ingress: 31.8s 31.8s 31.8s 32.2s 31.3s
Times for minikube (PR 12106) ingress: 32.2s 32.7s 39.7s 40.8s 32.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12106) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 22.0s               |
| enable ingress | 34.7s    | 34.4s               |
+----------------+----------+---------------------+

Times for minikube start: 23.3s 21.6s 21.9s 20.9s 21.4s
Times for minikube (PR 12106) start: 22.0s 22.7s 21.6s 22.0s 21.9s

Times for minikube ingress: 33.0s 35.5s 36.5s 37.0s 31.5s
Times for minikube (PR 12106) ingress: 36.0s 35.5s 37.5s 31.5s 31.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12106) |
+----------------+----------+---------------------+
| minikube start | 41.3s    | 42.3s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube (PR 12106) start: 43.3s 44.4s 43.6s 36.3s 43.8s
Times for minikube start: 31.4s 43.8s 44.2s 43.7s 43.2s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
KVM_Linux_containerd TestAddons/parallel/Ingress (gopogh) 0.00 (chart)
KVM_Linux_crio TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
KVM_Linux_crio TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 0.00 (chart)
KVM_Linux_crio TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 1.19 (chart)
Docker_Linux_containerd TestRunningBinaryUpgrade (gopogh) 2.25 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/newest-cni/serial/Pause (gopogh) 3.66 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/Pause (gopogh) 7.23 (chart)
Docker_Linux_crio TestNetworkPlugins/group/auto/DNS (gopogh) 12.36 (chart)
KVM_Linux TestForceSystemdFlag (gopogh) 16.09 (chart)
KVM_Linux TestPause/serial/PauseAgain (gopogh) 16.09 (chart)
KVM_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 16.09 (chart)
KVM_Linux TestPause/serial/Start (gopogh) 16.09 (chart)
KVM_Linux TestPause/serial/Unpause (gopogh) 16.09 (chart)
KVM_Linux TestCertOptions (gopogh) 17.05 (chart)
KVM_Linux TestDockerFlags (gopogh) 17.05 (chart)
KVM_Linux TestErrorSpam/setup (gopogh) 17.05 (chart)
KVM_Linux TestFunctional/parallel/BuildImage (gopogh) 17.05 (chart)
KVM_Linux TestFunctional/parallel/CertSync (gopogh) 17.05 (chart)
KVM_Linux TestFunctional/parallel/CpCmd (gopogh) 17.05 (chart)
KVM_Linux TestFunctional/parallel/DashboardCmd (gopogh) 17.05 (chart)
KVM_Linux TestFunctional/parallel/DockerEnv (gopogh) 17.05 (chart)
KVM_Linux TestFunctional/parallel/FileSync (gopogh) 17.05 (chart)
KVM_Linux TestFunctional/parallel/ListImages (gopogh) 17.05 (chart)
KVM_Linux TestFunctional/parallel/LoadImage (gopogh) 17.05 (chart)
KVM_Linux TestFunctional/parallel/MySQL (gopogh) 17.05 (chart)
KVM_Linux TestFunctional/parallel/NodeLabels (gopogh) 17.05 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh
Copy link
Member

medyagh commented Aug 5, 2021

KVM tests 134 seems like a bad test run

@medyagh
Copy link
Member

medyagh commented Aug 5, 2021

/retest

@sharifelgamal
Copy link
Collaborator Author

KVM tests 134 seems like a bad test run

Yeah, one of our machines was misconfigured. It currently out of the rotation so this shouldn't happen again.

@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12106) |
+----------------+----------+---------------------+
| minikube start | 48.2s    | 47.5s               |
| enable ingress | 32.2s    | 32.0s               |
+----------------+----------+---------------------+

Times for minikube start: 47.5s 47.5s 49.1s 47.0s 49.7s
Times for minikube (PR 12106) start: 48.5s 48.1s 47.1s 46.2s 47.6s

Times for minikube ingress: 32.3s 31.7s 32.3s 32.8s 31.8s
Times for minikube (PR 12106) ingress: 31.3s 30.7s 33.7s 32.3s 31.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12106) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 21.9s               |
| enable ingress | 31.9s    | 28.0s               |
+----------------+----------+---------------------+

Times for minikube start: 21.6s 21.9s 22.4s 22.4s 22.1s
Times for minikube (PR 12106) start: 22.0s 20.9s 22.6s 22.0s 21.9s

Times for minikube ingress: 35.5s 35.5s 27.5s 34.5s 26.5s
Times for minikube (PR 12106) ingress: 35.0s 27.0s 25.5s 26.5s 26.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12106) |
+----------------+----------+---------------------+
| minikube start | 44.1s    | 43.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 44.5s 44.4s 43.7s 44.1s 43.6s
Times for minikube (PR 12106) start: 43.3s 44.3s 43.3s 44.3s 42.8s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestAddons/parallel/HelmTiller (gopogh) 0.00 (chart)
Docker_Linux_crio TestAddons/parallel/HelmTiller (gopogh) 0.00 (chart)
Docker_Linux TestAddons/parallel/HelmTiller (gopogh) 0.00 (chart)
Docker_macOS TestMultiNode/serial/AddNode (gopogh) 0.00 (chart)
Docker_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 0.00 (chart)
Docker_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 0.00 (chart)
Docker_macOS TestMultiNode/serial/StartAfterStop (gopogh) 0.00 (chart)
Docker_macOS TestPreload (gopogh) 0.00 (chart)
Hyperkit_macOS TestAddons/parallel/HelmTiller (gopogh) 0.00 (chart)
KVM_Linux_containerd TestAddons/parallel/HelmTiller (gopogh) 0.00 (chart)
KVM_Linux_crio TestAddons/parallel/HelmTiller (gopogh) 0.00 (chart)
KVM_Linux_crio TestStartStop/group/newest-cni/serial/Pause (gopogh) 0.00 (chart)
KVM_Linux_crio TestStartStop/group/newest-cni/serial/SecondStart (gopogh) 0.00 (chart)
KVM_Linux TestAddons/parallel/HelmTiller (gopogh) 0.00 (chart)
Docker_macOS TestSkaffold (gopogh) 0.93 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 0.96 (chart)
Docker_Linux_containerd_arm64 TestScheduledStopUnix (gopogh) 2.00 (chart)
Docker_Linux_crio TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 2.44 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 3.23 (chart)
Docker_Windows TestMultiNode/serial/RestartMultiNode (gopogh) 4.35 (chart)
Docker_Linux_crio TestScheduledStopUnix (gopogh) 4.55 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 5.45 (chart)
Docker_Linux TestScheduledStopUnix (gopogh) 5.45 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 6.36 (chart)
Docker_Linux_containerd TestFunctional/serial/LogsFileCmd (gopogh) 7.27 (chart)
Docker_Linux_containerd TestFunctional/serial/LogsCmd (gopogh) 8.18 (chart)
Docker_Linux TestFunctional/serial/ComponentHealth (gopogh) 8.18 (chart)
Docker_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 8.41 (chart)
Docker_Windows TestRunningBinaryUpgrade (gopogh) 8.79 (chart)
Docker_Linux_containerd_arm64 TestKubernetesUpgrade (gopogh) 10.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@sharifelgamal
Copy link
Collaborator Author

It looks like I somehow broke the helm-tiller addon test, but I can't replicate it and can't figure out why the gcp-auth addon would somehow prevent minikube from pulling the helm-tiller image. So I'm going to rerun the tests to see if it's an actual issue.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12106) |
+----------------+----------+---------------------+
| minikube start | 48.3s    | 48.1s               |
| enable ingress | 32.1s    | 32.3s               |
+----------------+----------+---------------------+

Times for minikube start: 48.9s 49.9s 47.9s 47.4s 47.1s
Times for minikube (PR 12106) start: 47.3s 47.3s 47.6s 46.3s 51.8s

Times for minikube ingress: 31.4s 33.3s 31.7s 32.3s 31.8s
Times for minikube (PR 12106) ingress: 32.2s 33.3s 30.7s 32.2s 33.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12106) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 21.7s               |
| enable ingress | 35.5s    | 34.6s               |
+----------------+----------+---------------------+

Times for minikube start: 23.0s 22.1s 21.6s 21.9s 21.4s
Times for minikube (PR 12106) start: 22.0s 21.6s 21.8s 22.4s 20.9s

Times for minikube ingress: 35.5s 35.5s 32.0s 37.5s 37.0s
Times for minikube (PR 12106) ingress: 32.5s 35.0s 36.0s 34.0s 35.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12106) |
+----------------+----------+---------------------+
| minikube start | 39.3s    | 42.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 27.4s 44.7s 43.8s 36.7s 43.9s
Times for minikube (PR 12106) start: 43.5s 43.2s 40.9s 43.0s 42.8s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_crio TestErrorSpam/setup (gopogh) 0.00 (chart)
KVM_Linux_crio TestNetworkPlugins/group/kindnet/Start (gopogh) 0.91 (chart)
none_Linux TestFunctional/serial/ComponentHealth (gopogh) 0.93 (chart)
KVM_Linux TestAddons/parallel/CSI (gopogh) 0.98 (chart)
Docker_Windows TestAddons/parallel/CSI (gopogh) 1.96 (chart)
KVM_Linux_crio TestNetworkPlugins/group/flannel/Start (gopogh) 2.73 (chart)
Docker_Linux_docker_arm64 TestScheduledStopUnix (gopogh) 5.32 (chart)
Docker_Linux_crio TestScheduledStopUnix (gopogh) 6.09 (chart)
Docker_macOS TestScheduledStopUnix (gopogh) 6.25 (chart)
Docker_Linux_crio TestStartStop/group/embed-certs/serial/Pause (gopogh) 7.14 (chart)
Docker_Linux TestStartStop/group/no-preload/serial/Pause (gopogh) 7.89 (chart)
Docker_Linux TestScheduledStopUnix (gopogh) 9.65 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 14.04 (chart)
Docker_macOS TestFunctional/parallel/DashboardCmd (gopogh) 15.18 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 21.33 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 22.67 (chart)
Docker_Windows TestMultiNode/serial/CopyFile (gopogh) 26.73 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/DeployApp (gopogh) 34.21 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 36.84 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 39.39 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 40.26 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 40.26 (chart)
Docker_Windows TestNetworkPlugins/group/auto/Start (gopogh) 40.43 (chart)
Docker_Linux_crio_arm64 TestNetworkPlugins/group/auto/Start (gopogh) 43.43 (chart)
Docker_Windows TestNetworkPlugins/group/false/Start (gopogh) 48.94 (chart)
Docker_Windows TestFunctional/parallel/DryRun (gopogh) 51.96 (chart)
Docker_Linux_crio_arm64 TestMultiNode/serial/DeployApp2Nodes (gopogh) 53.15 (chart)
Docker_Linux_crio_arm64 TestNetworkPlugins/group/custom-weave/Start (gopogh) 53.54 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/DNS (gopogh) 53.70 (chart)
Docker_Linux_crio_arm64 TestNetworkPlugins/group/kindnet/Start (gopogh) 55.56 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sharifelgamal sharifelgamal merged commit 9995961 into kubernetes:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@blueelvis blueelvis Awaiting requested review from blueelvis

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gcp-auth registries is too restrictive
4 participants
@sharifelgamal @minikube-pr-bot @medyagh @k8s-ci-robot