Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO: Upgrade crictl (from cri-tools) to v1.21.0 #12129

Merged
merged 3 commits into from
Aug 5, 2021
Merged

ISO: Upgrade crictl (from cri-tools) to v1.21.0 #12129

merged 3 commits into from
Aug 5, 2021

Conversation

afbjorklund
Copy link
Collaborator

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 5, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2021
@afbjorklund afbjorklund changed the title ISO: Update crictl (from cri-tools) to v1.21.0 ISO: Upgrade crictl (from cri-tools) to v1.21.0 Aug 5, 2021
@medyagh
Copy link
Member

medyagh commented Aug 5, 2021

ok-to-build-iso

@minikube-bot

This comment has been minimized.

Sign in to view
@afbjorklund
Copy link
Collaborator Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2021
@medyagh
Copy link
Member

medyagh commented Aug 5, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 5, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12129) |
+----------------+----------+---------------------+
| minikube start | 50.5s    | 52.5s               |
| enable ingress | 31.7s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 30.9s 31.9s 31.4s 31.8s 32.4s
Times for minikube (PR 12129) ingress: 31.8s 32.4s 31.8s 31.3s 31.3s

Times for minikube start: 51.3s 47.4s 53.2s 47.7s 53.0s
Times for minikube (PR 12129) start: 51.3s 56.7s 54.4s 51.5s 48.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12129) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 23.3s               |
| enable ingress | 26.7s    | 28.6s               |
+----------------+----------+---------------------+

Times for minikube start: 23.6s 22.1s 22.6s 22.7s 21.9s
Times for minikube (PR 12129) start: 24.4s 22.3s 22.7s 22.8s 24.2s

Times for minikube ingress: 26.5s 26.5s 27.0s 27.0s 26.5s
Times for minikube (PR 12129) ingress: 26.6s 36.5s 26.5s 28.0s 25.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12129) |
+----------------+----------+---------------------+
| minikube start | 41.2s    | 43.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 29.9s 44.0s 45.0s 43.4s 43.4s
Times for minikube (PR 12129) start: 43.8s 43.3s 44.0s 43.0s 44.4s

@medyagh
Copy link
Member

medyagh commented Aug 5, 2021

/approve

@medyagh medyagh merged commit be03223 into kubernetes:master Aug 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_docker_arm64 TestAddons/parallel/GCPAuth (gopogh) 0.00 (chart)
Docker_macOS TestScheduledStopUnix (gopogh) 0.00 (chart)
KVM_Linux_crio TestStartStop/group/embed-certs/serial/Pause (gopogh) 0.97 (chart)
Docker_Linux_docker_arm64 TestAddons/parallel/CSI (gopogh) 1.12 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 2.25 (chart)
Docker_Linux_docker_arm64 TestAddons/parallel/Ingress (gopogh) 3.37 (chart)
Docker_Linux_crio TestScheduledStopUnix (gopogh) 3.67 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 4.59 (chart)
Docker_Linux TestScheduledStopUnix (gopogh) 4.59 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/MountCmd/any-port (gopogh) 5.00 (chart)
Docker_Linux_crio TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 5.56 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/PersistentVolumeClaim (gopogh) 5.62 (chart)
Docker_Linux_docker_arm64 TestMultiNode/serial/DeployApp2Nodes (gopogh) 7.87 (chart)
Docker_Linux_docker_arm64 TestMultiNode/serial/PingHostFrom2Pods (gopogh) 7.87 (chart)
Docker_macOS TestNetworkPlugins/group/false/DNS (gopogh) 12.26 (chart)
Docker_macOS TestFunctional/parallel/DashboardCmd (gopogh) 13.21 (chart)
KVM_Linux TestStartStop/group/newest-cni/serial/Pause (gopogh) 15.89 (chart)
Docker_Windows TestInsufficientStorage (gopogh) 17.20 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 20.75 (chart)
Docker_Linux_crio TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 25.69 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/GCPAuth (gopogh) 27.18 (chart)
KVM_Linux_crio TestJSONOutput/stop/parallel/DistinctCurrentSteps (gopogh) 29.13 (chart)
KVM_Linux_crio TestJSONOutput/stop/parallel/IncreasingCurrentSteps (gopogh) 29.13 (chart)
Docker_Linux_crio TestStartStop/group/embed-certs/serial/Stop (gopogh) 31.19 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/CSI (gopogh) 37.86 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 40.57 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 40.57 (chart)
Docker_Linux_crio_arm64 TestNetworkPlugins/group/auto/Start (gopogh) 41.05 (chart)
Docker_Windows TestNetworkPlugins/group/auto/Start (gopogh) 41.18 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 43.69 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh Awaiting requested review from medyagh

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@afbjorklund @medyagh @minikube-bot @minikube-pr-bot @k8s-ci-robot