Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading an image from tar failing on existing delete #12143

Merged
merged 5 commits into from
Aug 9, 2021

Conversation

spowelljr
Copy link
Member

Fixes #11992

When loading an image from tar using image load it would fail trying to delete the existing image because the image name is set to the src of the file, ie. C:\this_is_a_dir\image.tar.gz instead of image:latest and would fail the delete.

I added a check to compare the src and image name, and if they match, skip the delete as we don't have the actual image name.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 6, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 6, 2021
@medyagh
Copy link
Member

medyagh commented Aug 6, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 6, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12143) |
+----------------+----------+---------------------+
| minikube start | 49.1s    | 47.3s               |
| enable ingress | 34.3s    | 35.5s               |
+----------------+----------+---------------------+

Times for minikube start: 52.6s 51.2s 47.6s 46.3s 47.8s
Times for minikube (PR 12143) start: 48.2s 47.9s 47.1s 45.9s 47.5s

Times for minikube ingress: 33.8s 32.3s 32.9s 40.3s 32.3s
Times for minikube (PR 12143) ingress: 39.3s 31.8s 31.8s 34.8s 39.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12143) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 21.8s               |
| enable ingress | 36.4s    | 35.4s               |
+----------------+----------+---------------------+

Times for minikube start: 22.6s 22.1s 21.8s 22.7s 21.5s
Times for minikube (PR 12143) start: 21.5s 23.1s 21.1s 22.3s 21.2s

Times for minikube (PR 12143) ingress: 35.0s 35.0s 35.0s 36.0s 36.0s
Times for minikube ingress: 36.6s 35.0s 36.0s 37.5s 37.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12143) |
+----------------+----------+---------------------+
| minikube start | 43.2s    | 44.0s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube (PR 12143) start: 44.6s 44.0s 44.3s 43.9s 43.1s
Times for minikube start: 41.1s 43.8s 43.8s 43.9s 43.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestAddons/parallel/HelmTiller (gopogh) 0.00 (chart)
Docker_Linux_crio TestAddons/parallel/HelmTiller (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestAddons/parallel/GCPAuth (gopogh) 0.00 (chart)
Docker_Linux TestAddons/parallel/HelmTiller (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/BuildImage (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/MountCmd/any-port (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/MySQL (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 0.00 (chart)
Docker_macOS TestMultiNode/serial/AddNode (gopogh) 0.00 (chart)
Docker_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 0.00 (chart)
Docker_macOS TestMultiNode/serial/FreshStart2Nodes (gopogh) 0.00 (chart)
Docker_macOS TestMultiNode/serial/ProfileList (gopogh) 0.00 (chart)
Docker_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 0.00 (chart)
Docker_macOS TestMultiNode/serial/StartAfterStop (gopogh) 0.00 (chart)
Docker_macOS TestMultiNode/serial/StopNode (gopogh) 0.00 (chart)
KVM_Linux_containerd TestAddons/parallel/HelmTiller (gopogh) 0.00 (chart)
KVM_Linux TestAddons/parallel/HelmTiller (gopogh) 0.00 (chart)
none_Linux TestFunctional/serial/ExtraConfig (gopogh) 0.00 (chart)
Docker_macOS TestSkaffold (gopogh) 0.93 (chart)
none_Linux TestFunctional/serial/ComponentHealth (gopogh) 0.98 (chart)
Docker_Linux_docker_arm64 TestAddons/parallel/CSI (gopogh) 1.15 (chart)
Docker_Linux TestAddons/parallel/Olm (gopogh) 1.82 (chart)
Docker_Linux_containerd_arm64 TestScheduledStopUnix (gopogh) 2.00 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 2.30 (chart)
Docker_Linux_docker_arm64 TestAddons/parallel/Ingress (gopogh) 3.45 (chart)
Docker_Linux_docker_arm64 TestFunctional/serial/ComponentHealth (gopogh) 3.45 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/CSI (gopogh) 4.00 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/Ingress (gopogh) 4.00 (chart)
Docker_Linux_crio TestScheduledStopUnix (gopogh) 4.55 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 6, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12143) |
+----------------+----------+---------------------+
| minikube start | 47.1s    | 47.0s               |
| enable ingress | 35.3s    | 33.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 12143) start: 46.7s 47.1s 47.1s 46.5s 47.6s
Times for minikube start: 46.9s 46.6s 47.0s 46.3s 48.5s

Times for minikube ingress: 31.8s 40.2s 31.8s 32.3s 40.3s
Times for minikube (PR 12143) ingress: 40.3s 31.7s 31.8s 31.8s 31.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12143) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.9s               |
| enable ingress | 35.1s    | 35.7s               |
+----------------+----------+---------------------+

Times for minikube start: 21.4s 22.0s 21.6s 21.2s 21.6s
Times for minikube (PR 12143) start: 21.0s 22.0s 21.8s 22.1s 22.4s

Times for minikube ingress: 32.5s 31.5s 35.5s 35.5s 40.5s
Times for minikube (PR 12143) ingress: 35.0s 35.5s 36.0s 36.5s 35.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12143) |
+----------------+----------+---------------------+
| minikube start | 42.1s    | 43.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 44.0s 42.9s 43.9s 37.0s 42.7s
Times for minikube (PR 12143) start: 45.4s 43.3s 43.5s 42.7s 43.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/Stop (gopogh) 2.67 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 2.94 (chart)
Docker_Linux_crio_arm64 TestScheduledStopUnix (gopogh) 3.60 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 4.05 (chart)
Docker_Windows TestMultiNode/serial/RestartMultiNode (gopogh) 4.95 (chart)
Docker_Linux_crio TestScheduledStopUnix (gopogh) 6.09 (chart)
Docker_macOS TestScheduledStopUnix (gopogh) 6.25 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/BuildImage (gopogh) 8.11 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/Ingress (gopogh) 8.18 (chart)
Docker_Linux_crio TestNetworkPlugins/group/cilium/DNS (gopogh) 8.70 (chart)
Docker_macOS TestStartStop/group/no-preload/serial/Pause (gopogh) 9.43 (chart)
Docker_Linux TestScheduledStopUnix (gopogh) 9.65 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/CSI (gopogh) 10.00 (chart)
Docker_Linux_containerd_arm64 TestScheduledStopUnix (gopogh) 10.91 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/MountCmd/any-port (gopogh) 12.50 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/PersistentVolumeClaim (gopogh) 13.64 (chart)
Docker_Windows TestOffline (gopogh) 13.86 (chart)
Docker_Windows TestFunctional/parallel/InternationalLanguage (gopogh) 14.71 (chart)
Docker_macOS TestFunctional/parallel/DashboardCmd (gopogh) 15.18 (chart)
Docker_macOS TestNetworkPlugins/group/false/DNS (gopogh) 15.32 (chart)
Docker_Windows TestInsufficientStorage (gopogh) 16.67 (chart)
KVM_Linux TestScheduledStopUnix (gopogh) 17.86 (chart)
Docker_Linux_crio TestPause/serial/Pause (gopogh) 18.26 (chart)
Docker_Linux_crio TestPause/serial/VerifyStatus (gopogh) 18.26 (chart)
Docker_Linux_crio TestPause/serial/PauseAgain (gopogh) 20.87 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 21.33 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 22.67 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 24.32 (chart)
Docker_Windows TestAddons/parallel/HelmTiller (gopogh) 24.51 (chart)
Docker_Windows TestMultiNode/serial/CopyFile (gopogh) 26.73 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12143) |
+----------------+----------+---------------------+
| minikube start | 48.9s    | 47.7s               |
| enable ingress | 32.2s    | 35.2s               |
+----------------+----------+---------------------+

Times for minikube start: 49.5s 48.8s 50.1s 47.6s 48.8s
Times for minikube (PR 12143) start: 47.0s 46.9s 48.1s 49.9s 46.6s

Times for minikube ingress: 31.8s 32.8s 31.3s 32.7s 32.3s
Times for minikube (PR 12143) ingress: 31.8s 32.3s 39.8s 40.4s 31.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12143) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 22.2s               |
| enable ingress | 35.2s    | 34.9s               |
+----------------+----------+---------------------+

Times for minikube start: 22.9s 22.0s 22.8s 21.8s 21.8s
Times for minikube (PR 12143) start: 22.2s 21.7s 21.5s 22.6s 22.8s

Times for minikube ingress: 37.0s 32.5s 36.0s 35.5s 35.0s
Times for minikube (PR 12143) ingress: 36.5s 31.5s 35.5s 35.5s 35.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12143) |
+----------------+----------+---------------------+
| minikube start | 41.4s    | 43.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube (PR 12143) start: 44.6s 43.6s 42.9s 43.5s 43.5s
Times for minikube start: 31.6s 43.4s 45.1s 43.2s 43.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_docker_arm64 TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Docker_Linux_crio TestNetworkPlugins/group/bridge/DNS (gopogh) 4.38 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/Pause (gopogh) 6.52 (chart)
Docker_Linux_docker_arm64 TestScheduledStopUnix (gopogh) 9.80 (chart)
Docker_Linux_crio TestAddons/parallel/GCPAuth (gopogh) 10.14 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/old-k8s-version/serial/VerifyKubernetesImages (gopogh) 11.76 (chart)
KVM_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 11.76 (chart)
KVM_Linux TestMultiNode/serial/FreshStart2Nodes (gopogh) 11.76 (chart)
KVM_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 11.76 (chart)
Docker_macOS TestNetworkPlugins/group/false/DNS (gopogh) 14.41 (chart)
Docker_Linux_containerd TestPause/serial/Pause (gopogh) 14.49 (chart)
Docker_Linux_containerd TestPause/serial/VerifyStatus (gopogh) 14.49 (chart)
Docker_Linux_crio TestScheduledStopUnix (gopogh) 15.94 (chart)
Docker_Linux TestScheduledStopUnix (gopogh) 17.39 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 17.65 (chart)
Docker_Linux_containerd TestPause/serial/PauseAgain (gopogh) 23.19 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 24.11 (chart)
Docker_Linux_crio TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 26.09 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 27.82 (chart)
Docker_Linux_containerd_arm64 TestScheduledStopUnix (gopogh) 31.11 (chart)
KVM_Linux_crio TestJSONOutput/stop/parallel/DistinctCurrentSteps (gopogh) 32.06 (chart)
KVM_Linux_crio TestJSONOutput/stop/parallel/IncreasingCurrentSteps (gopogh) 32.06 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 34.06 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/kindnet/Start (gopogh) 34.59 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/GCPAuth (gopogh) 35.29 (chart)
Docker_Linux_crio_arm64 TestNetworkPlugins/group/auto/Start (gopogh) 42.15 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12143) |
+----------------+----------+---------------------+
| minikube start | 48.2s    | 47.1s               |
| enable ingress | 35.5s    | 32.3s               |
+----------------+----------+---------------------+

Times for minikube start: 48.7s 48.2s 47.7s 47.8s 48.7s
Times for minikube (PR 12143) start: 47.6s 46.7s 47.0s 47.8s 46.5s

Times for minikube ingress: 40.8s 40.3s 31.8s 32.3s 32.3s
Times for minikube (PR 12143) ingress: 32.8s 32.3s 32.3s 31.7s 32.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12143) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 21.7s               |
| enable ingress | 36.0s    | 35.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 12143) start: 21.7s 21.8s 21.5s 22.2s 21.4s
Times for minikube start: 23.1s 21.3s 22.1s 21.8s 21.0s

Times for minikube ingress: 36.0s 37.1s 35.5s 35.5s 36.0s
Times for minikube (PR 12143) ingress: 35.5s 36.0s 35.0s 36.0s 35.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12143) |
+----------------+----------+---------------------+
| minikube start | 38.5s    | 41.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.5s 43.4s 37.4s 43.9s 36.1s
Times for minikube (PR 12143) start: 36.8s 42.8s 42.3s 44.3s 42.9s

@spowelljr spowelljr merged commit de8a1ba into kubernetes:master Aug 9, 2021
@spowelljr spowelljr deleted the imageLoadTar branch August 9, 2021 22:15
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd_arm64 TestFunctional/parallel/BuildImage (gopogh) 1.47 (chart)
Docker_Linux_containerd_arm64 TestMultiNode/serial/DeployApp2Nodes (gopogh) 1.47 (chart)
Docker_Linux_containerd_arm64 TestMultiNode/serial/PingHostFrom2Pods (gopogh) 1.47 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/calico/Start (gopogh) 8.21 (chart)
Docker_Linux_docker_arm64 TestScheduledStopUnix (gopogh) 9.80 (chart)
Docker_Windows TestPause/serial/PauseAgain (gopogh) 11.40 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/MountCmd/any-port (gopogh) 11.85 (chart)
Docker_Windows TestPause/serial/Pause (gopogh) 12.07 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 12.93 (chart)
Docker_Linux_docker_arm64 TestNetworkPlugins/group/custom-weave/Start (gopogh) 13.73 (chart)
Docker_Linux_docker_arm64 TestMultiNode/serial/DeployApp2Nodes (gopogh) 14.71 (chart)
Docker_Linux_docker_arm64 TestMultiNode/serial/PingHostFrom2Pods (gopogh) 14.71 (chart)
Docker_Linux TestScheduledStopUnix (gopogh) 17.27 (chart)
Docker_Linux_crio TestPause/serial/Pause (gopogh) 19.42 (chart)
Docker_Linux_crio TestPause/serial/VerifyStatus (gopogh) 19.42 (chart)
Docker_Linux_crio TestPause/serial/PauseAgain (gopogh) 21.58 (chart)
KVM_Linux TestScheduledStopUnix (gopogh) 24.09 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 27.61 (chart)
Docker_Linux_containerd_arm64 TestScheduledStopUnix (gopogh) 31.62 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 34.53 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/kindnet/Start (gopogh) 35.07 (chart)
Docker_Windows TestAddons/parallel/GCPAuth (gopogh) 58.40 (chart)
Docker_Windows TestPause/serial/VerifyStatus (gopogh) 66.09 (chart)
Docker_Windows TestNetworkPlugins/group/cilium/Start (gopogh) 66.37 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 72.57 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 73.45 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 79.82 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/bridge/Start (gopogh) 81.34 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 94.00 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 94.12 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minikube v1.22.0 cannot load E:\image tar.gz
5 participants