-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loading an image from tar failing on existing delete #12143
Conversation
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 52.6s 51.2s 47.6s 46.3s 47.8s Times for minikube ingress: 33.8s 32.3s 32.9s 40.3s 32.3s docker driver with docker runtime
Times for minikube start: 22.6s 22.1s 21.8s 22.7s 21.5s Times for minikube (PR 12143) ingress: 35.0s 35.0s 35.0s 36.0s 36.0s docker driver with containerd runtime
Times for minikube (PR 12143) start: 44.6s 44.0s 44.3s 43.9s 43.1s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kvm2 driver with docker runtime
Times for minikube (PR 12143) start: 46.7s 47.1s 47.1s 46.5s 47.6s Times for minikube ingress: 31.8s 40.2s 31.8s 32.3s 40.3s docker driver with docker runtime
Times for minikube start: 21.4s 22.0s 21.6s 21.2s 21.6s Times for minikube ingress: 32.5s 31.5s 35.5s 35.5s 40.5s docker driver with containerd runtime
Times for minikube start: 44.0s 42.9s 43.9s 37.0s 42.7s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
kvm2 driver with docker runtime
Times for minikube start: 49.5s 48.8s 50.1s 47.6s 48.8s Times for minikube ingress: 31.8s 32.8s 31.3s 32.7s 32.3s docker driver with docker runtime
Times for minikube start: 22.9s 22.0s 22.8s 21.8s 21.8s Times for minikube ingress: 37.0s 32.5s 36.0s 35.5s 35.0s docker driver with containerd runtime
Times for minikube (PR 12143) start: 44.6s 43.6s 42.9s 43.5s 43.5s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
kvm2 driver with docker runtime
Times for minikube start: 48.7s 48.2s 47.7s 47.8s 48.7s Times for minikube ingress: 40.8s 40.3s 31.8s 32.3s 32.3s docker driver with docker runtime
Times for minikube (PR 12143) start: 21.7s 21.8s 21.5s 22.2s 21.4s Times for minikube ingress: 36.0s 37.1s 35.5s 35.5s 36.0s docker driver with containerd runtime
Times for minikube start: 31.5s 43.4s 37.4s 43.9s 36.1s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
Fixes #11992
When loading an image from tar using
image load
it would fail trying to delete the existing image because the image name is set to the src of the file, ie.C:\this_is_a_dir\image.tar.gz
instead ofimage:latest
and would fail the delete.I added a check to compare the src and image name, and if they match, skip the delete as we don't have the actual image name.