pause each container separately

[sharifelgamal]

Our containerd pause tests are failing with the following error:

X Exiting due to GUEST_PAUSE: runc: sudo runc --root /run/containerd/runc/k8s.io pause 44e5c29356861d3eb4eea140081d1869eb05d894f0a088323bd8c4db9fc8ed35 508221fbe40ab163913f6c34d29dd4548e075546b675d1ec9f56fffbb8bc48d7: Process exited with status 1
	stdout:
	Incorrect Usage.
	
	NAME:
	   runc pause - pause suspends all processes inside the container
	
	USAGE:
	   runc pause <container-id>

The issue is that we're appending each container id as we pause each one, which is not correct. This change fixes that.

[sharifelgamal]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12318) |
+----------------+----------+---------------------+
| minikube start | 47.6s    | 46.9s               |
| enable ingress | 35.0s    | 34.0s               |
+----------------+----------+---------------------+

Times for minikube start: 48.4s 46.4s 47.1s 48.0s 47.9s
Times for minikube (PR 12318) start: 47.2s 46.2s 47.6s 46.6s 47.1s

Times for minikube ingress: 32.3s 31.7s 39.3s 39.8s 31.8s
Times for minikube (PR 12318) ingress: 41.3s 32.3s 31.8s 32.8s 31.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12318) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 21.7s               |
| enable ingress | 35.8s    | 36.1s               |
+----------------+----------+---------------------+

Times for minikube (PR 12318) start: 22.0s 21.1s 21.5s 21.1s 22.6s
Times for minikube start: 22.8s 21.3s 21.3s 22.0s 22.1s

Times for minikube ingress: 36.5s 35.0s 36.0s 36.0s 35.5s
Times for minikube (PR 12318) ingress: 35.5s 35.5s 36.5s 37.0s 36.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12318) |
+----------------+----------+---------------------+
| minikube start | 41.5s    | 43.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.9s 44.1s 43.7s 44.4s 43.7s
Times for minikube (PR 12318) start: 43.0s 44.1s 44.3s 43.9s 42.6s

[sharifelgamal]

The Docker Linux containerd pause tests failed, but for reasons unrelated to the fix I'm making here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
KVM_Linux	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	1.28 (chart)
Hyperkit_macOS	TestNetworkPlugins/group/cilium/Start (gopogh)	3.42 (chart)
Hyperkit_macOS	TestPreload (gopogh)	4.27 (chart)
KVM_Linux	TestStoppedBinaryUpgrade/Upgrade (gopogh)	4.76 (chart)
Docker_Windows	TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh)	5.98 (chart)
Docker_Windows	TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh)	5.98 (chart)
Docker_Windows	TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh)	5.98 (chart)
Docker_Windows	TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh)	5.98 (chart)
Docker_Windows	TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh)	6.25 (chart)
Docker_Windows	TestStartStop/group/no-preload/serial/VerifyKubernetesImages (gopogh)	6.32 (chart)
Docker_Windows	TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh)	9.40 (chart)
Docker_Windows	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	10.62 (chart)
Docker_Windows	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	10.62 (chart)
Docker_Windows	TestStartStop/group/old-k8s-version/serial/VerifyKubernetesImages (gopogh)	10.62 (chart)
Docker_Linux_crio_arm64	TestFunctional/parallel/BuildImage (gopogh)	10.88 (chart)
Hyperkit_macOS	TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh)	11.11 (chart)
Hyperkit_macOS	TestStartStop/group/no-preload/serial/DeployApp (gopogh)	11.11 (chart)
Hyperkit_macOS	TestMultiNode/serial/DeployApp2Nodes (gopogh)	12.82 (chart)
Hyperkit_macOS	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	12.82 (chart)
Docker_Windows	TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh)	13.33 (chart)
Docker_Windows	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	13.68 (chart)
Hyperkit_macOS	TestNetworkPlugins/group/calico/Start (gopogh)	14.53 (chart)
Hyperkit_macOS	TestSkaffold (gopogh)	14.53 (chart)
Docker_Windows	TestStartStop/group/no-preload/serial/SecondStart (gopogh)	15.38 (chart)
Docker_Windows	TestStartStop/group/old-k8s-version/serial/Pause (gopogh)	16.81 (chart)
Hyperkit_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	17.24 (chart)
Docker_Windows	TestStartStop/group/no-preload/serial/Pause (gopogh)	18.09 (chart)
Hyperkit_macOS	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	20.51 (chart)
Hyperkit_macOS	TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh)	21.37 (chart)
Hyperkit_macOS	TestStartStop/group/embed-certs/serial/DeployApp (gopogh)	21.37 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.