Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GCP auth pull secret even if creds JSON is nil #12461

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

sharifelgamal
Copy link
Collaborator

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 14, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12461) |
+----------------+----------+---------------------+
| minikube start | 50.5s    | 49.4s               |
| enable ingress | 31.5s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube start: 52.4s 51.4s 50.9s 49.5s 48.1s
Times for minikube (PR 12461) start: 47.9s 47.5s 47.6s 52.3s 51.9s

Times for minikube ingress: 32.9s 30.8s 32.4s 30.7s 30.9s
Times for minikube (PR 12461) ingress: 31.4s 31.8s 31.3s 31.3s 32.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12461) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 21.7s               |
| enable ingress | 37.8s    | 50.8s               |
+----------------+----------+---------------------+

Times for minikube start: 21.7s 22.0s 21.6s 22.0s 22.3s
Times for minikube (PR 12461) start: 21.0s 22.6s 21.6s 21.7s 21.8s

Times for minikube ingress: 27.5s 26.4s 82.0s 26.9s 26.0s
Times for minikube (PR 12461) ingress: 82.4s 28.0s 27.4s 89.9s 26.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12461) |
+----------------+----------+---------------------+
| minikube start | 44.0s    | 44.0s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 43.6s 44.1s 43.5s 44.5s 44.0s
Times for minikube (PR 12461) start: 44.3s 43.4s 44.0s 44.3s 44.0s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd_arm64 TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/no-preload/serial/DeployApp (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/no-preload/serial/FirstStart (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/no-preload/serial/SecondStart (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/auto/Start (gopogh) 0.67 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 0.67 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/SaveImageToFile (gopogh) 1.33 (chart)
Docker_macOS TestFunctional/parallel/MySQL (gopogh) 1.36 (chart)
Docker_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 1.36 (chart)
Docker_macOS TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 1.36 (chart)
Docker_Linux_containerd_arm64 TestMultiNode/serial/DeployApp2Nodes (gopogh) 2.00 (chart)
Docker_Linux_containerd_arm64 TestMultiNode/serial/PingHostFrom2Pods (gopogh) 2.00 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/GCPAuth (gopogh) 2.67 (chart)
Docker_Linux_containerd_arm64 TestErrorSpam/setup (gopogh) 3.33 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/custom-weave/Start (gopogh) 3.33 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/BuildImage (gopogh) 4.00 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/SaveImage (gopogh) 4.00 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 4.00 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 4.00 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/PersistentVolumeClaim (gopogh) 4.67 (chart)
Docker_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 4.76 (chart)
Docker_macOS TestSkaffold (gopogh) 4.76 (chart)
Docker_Linux_crio TestNetworkPlugins/group/cilium/DNS (gopogh) 5.23 (chart)
Docker_macOS TestFunctional/parallel/MountCmd/any-port (gopogh) 5.44 (chart)
Docker_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 5.44 (chart)
Docker_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 5.44 (chart)
Docker_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 5.44 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/calico/Start (gopogh) 6.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@sharifelgamal sharifelgamal merged commit c0534a6 into kubernetes:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants