-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use newer dashboard, to support ingress extensions #12475
Conversation
This should solve kubernetes#12402 and issues where ingresses will not show properly in the dashboard. This error shows on kubernetes 1.22
Hi @leifcr. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leifcr please fix the unit test and also the Preload Version needs to be bumped after this PR
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 49.5s 53.8s 48.2s 50.0s 48.6s Times for minikube ingress: 33.3s 32.4s 33.9s 32.3s 32.4s docker driver with docker runtime
Times for minikube start: 35.6s 21.9s 21.6s 22.4s 22.3s Times for minikube (PR 12475) ingress: 26.0s 26.4s 25.9s 27.5s 26.4s docker driver with containerd runtime
Times for minikube start: 45.0s 43.7s 36.8s 43.5s 43.1s |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leifcr, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sharifelgamal and @medyagh Thanks for fixing unit tests and getting this merged. I'll dig further into the code, so I can do that the next time. |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
This should solve #12402 and issues where ingresses will not show properly in the dashboard.
This error shows on kubernetes 1.22
It bumps the dashboard and metrics to newest versions