Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer dashboard, to support ingress extensions #12475

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

leifcr
Copy link
Contributor

@leifcr leifcr commented Sep 14, 2021

This should solve #12402 and issues where ingresses will not show properly in the dashboard.
This error shows on kubernetes 1.22

It bumps the dashboard and metrics to newest versions

This should solve kubernetes#12402 and issues where ingresses will not show properly in the dashboard.
This error shows on kubernetes 1.22
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 14, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @leifcr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leifcr please fix the unit test and also the Preload Version needs to be bumped after this PR

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 16, 2021
@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 16, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12475) |
+----------------+----------+---------------------+
| minikube start | 50.0s    | 74.1s               |
| enable ingress | 32.9s    | 32.8s               |
+----------------+----------+---------------------+

Times for minikube start: 49.5s 53.8s 48.2s 50.0s 48.6s
Times for minikube (PR 12475) start: 75.0s 71.6s 74.2s 75.2s 74.4s

Times for minikube ingress: 33.3s 32.4s 33.9s 32.3s 32.4s
Times for minikube (PR 12475) ingress: 33.3s 31.8s 33.0s 32.4s 33.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12475) |
+----------------+----------+---------------------+
| minikube start | 24.8s    | 35.7s               |
| enable ingress | 31.8s    | 26.5s               |
+----------------+----------+---------------------+

Times for minikube start: 35.6s 21.9s 21.6s 22.4s 22.3s
Times for minikube (PR 12475) start: 36.1s 35.3s 35.5s 35.4s 36.0s

Times for minikube (PR 12475) ingress: 26.0s 26.4s 25.9s 27.5s 26.4s
Times for minikube ingress: 34.4s 28.0s 36.0s 34.5s 26.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12475) |
+----------------+----------+---------------------+
| minikube start | 42.4s    | 41.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 45.0s 43.7s 36.8s 43.5s 43.1s
Times for minikube (PR 12475) start: 39.3s 39.0s 42.7s 42.0s 43.2s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leifcr, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2021
@sharifelgamal sharifelgamal merged commit a86693c into kubernetes:master Sep 16, 2021
@leifcr
Copy link
Contributor Author

leifcr commented Sep 16, 2021

@sharifelgamal and @medyagh Thanks for fixing unit tests and getting this merged. I'll dig further into the code, so I can do that the next time.

@leifcr leifcr deleted the patch-2 branch September 16, 2021 21:24
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestDownloadOnlyKic (gopogh) 0.00 (chart)
Docker_Linux TestDownloadOnlyKic (gopogh) 0.00 (chart)
Docker_Windows TestDownloadOnlyKic (gopogh) 0.00 (chart)
Docker_Windows TestSkaffold (gopogh) 2.03 (chart)
KVM_Linux TestDebPackageInstall/install_amd64_ubuntu_18.04/kvm2-driver (gopogh) 6.06 (chart)
Docker_Linux TestDebPackageInstall/install_amd64_ubuntu_18.04/kvm2-driver (gopogh) 9.09 (chart)
Docker_Linux_containerd TestDebPackageInstall/install_amd64_ubuntu_18.04/kvm2-driver (gopogh) 12.12 (chart)
Docker_Windows TestScheduledStopWindows (gopogh) 20.95 (chart)
Docker_Windows TestNetworkPlugins/group/auto/Start (gopogh) 26.52 (chart)
Docker_Windows TestNetworkPlugins/group/false/Start (gopogh) 33.33 (chart)
Docker_Windows TestFunctional/parallel/DryRun (gopogh) 39.86 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 50.00 (chart)
Docker_Windows TestFunctional/parallel/LoadImageFromFile (gopogh) 52.70 (chart)
Docker_Windows TestPause/serial/VerifyStatus (gopogh) 58.78 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 59.85 (chart)
Docker_Windows TestPause/serial/DeletePaused (gopogh) 59.86 (chart)
Docker_Windows TestNetworkPlugins/group/cilium/Start (gopogh) 61.36 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 63.64 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 65.91 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 79.55 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 91.67 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)
Docker_Windows TestCertOptions (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants