-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
China Firewall: Adding Aliyun mirror for preload images and K8s release binaries #12578
China Firewall: Adding Aliyun mirror for preload images and K8s release binaries #12578
Conversation
…netes binaries Signed-off-by: Li Yi <denverdino@gmail.com>
Hi @denverdino. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
…netes binaries Signed-off-by: Li Yi <denverdino@gmail.com>
Signed-off-by: Li Yi <denverdino@gmail.com>
.github/workflows/sync-minikube.yml
Outdated
|
||
- name: Synchronize images to Alibaba Cloud Container Registry Service | ||
env: | ||
ACR_USER: ${{ secrets.ACR_USER }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use a more unique name
like ALIBABA_ACR_USER
and same for other secrets
and then if u share me those secrets I will add them to to the repo
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: denverdino, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kvm2 driver with docker runtime
Times for minikube start: 47.5s 48.8s 47.0s 47.7s 47.8s Times for minikube (PR 12578) ingress: 32.2s 31.7s 31.8s 32.2s 32.3s docker driver with docker runtime
Times for minikube ingress: 30.9s 34.4s 34.5s 26.5s 26.9s Times for minikube (PR 12578) start: 21.4s 21.9s 21.2s 21.7s 22.6s docker driver with containerd runtime
Times for minikube (PR 12578) start: 29.1s 29.8s 44.8s 48.4s 43.8s Times for minikube (PR 12578) ingress: 29.4s 27.4s 27.4s 28.4s 32.4s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
Signed-off-by: Li Yi denverdino@gmail.com
This PR is for the proposal in #12535
Alibaba Cloud Container Service team maintain the mirror for the release images for Kubernetes, and also other dependencies for Minikube, e.g. preload images, iso and addon images.
So, it will simplify the Chinese developers to use Minikube without network download issues. E.g.
If new addon is added, just let use know and add the mirror config in "deploy/addons/aliyun_mirror.json"
Pls let us know your feedback for that. Thanks a lot