Fix mounting on non-default profile #12711

spowelljr · 2021-10-14T21:45:42Z

Problem:
Using --mount flag on start doesn't work on VM drivers when using non-default profile. Root cause is we weren't passing the profile command when running minikube mount command so was only working on default profile.

Solution:
Pass profile into mount command.

Problem:
Killing mount on a cluster or deleting a cluster kills the mount on all clusters. Root cause is we use a single mount process between between all clusters, so when one's terminated it terminates all mounts.

Solution:
Make a mount process for each profile so they're independent of each other.

… independent

spowelljr · 2021-10-14T21:45:54Z

/ok-to-test

test/integration/mount_start_test.go

cmd/minikube/cmd/delete.go

minikube-pr-bot · 2021-10-14T22:43:01Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12711) |
+----------------+----------+---------------------+
| minikube start | 47.7s    | 46.5s               |
| enable ingress | 32.0s    | 31.9s               |
+----------------+----------+---------------------+

Times for minikube start: 49.7s 47.6s 48.1s 45.7s 47.6s
Times for minikube (PR 12711) start: 46.2s 47.0s 45.7s 46.0s 47.5s

Times for minikube ingress: 34.7s 31.4s 30.8s 32.2s 30.9s
Times for minikube (PR 12711) ingress: 31.8s 33.2s 31.9s 31.2s 31.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12711) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.5s               |
| enable ingress | 27.5s    | 30.4s               |
+----------------+----------+---------------------+

Times for minikube (PR 12711) start: 21.5s 21.5s 21.5s 21.4s 21.8s
Times for minikube start: 21.9s 21.4s 21.1s 20.7s 22.8s

Times for minikube ingress: 28.0s 26.9s 28.0s 26.4s 28.4s
Times for minikube (PR 12711) ingress: 26.9s 35.4s 27.5s 27.9s 34.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12711) |
+----------------+----------+---------------------+
| minikube start | 40.8s    | 44.2s               |
| enable ingress | 31.5s    | 28.5s               |
+----------------+----------+---------------------+

Times for minikube start: 31.4s 43.4s 43.6s 43.7s 41.9s
Times for minikube (PR 12711) start: 42.5s 47.6s 43.4s 43.4s 44.0s

Times for minikube ingress: 34.4s 32.9s 23.9s 32.5s 33.9s
Times for minikube (PR 12711) ingress: 18.9s 33.4s 33.9s 32.9s 23.4s

minikube-pr-bot · 2021-10-14T23:52:00Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
none_Linux	TestMountStart/serial/StartWithMountFirst (gopogh)	n/a
none_Linux	TestMountStart/serial/StartWithMountSecond (gopogh)	n/a
none_Linux	TestMountStart/serial/VerifyMountFirst (gopogh)	n/a
none_Linux	TestMountStart/serial/VerifyMountPostDelete (gopogh)	n/a
none_Linux	TestMountStart/serial/VerifyMountSecond (gopogh)	n/a
KVM_Linux_containerd	TestRunningBinaryUpgrade (gopogh)	1.22 (chart)
Docker_Windows	TestNetworkPlugins/group/false/DNS (gopogh)	13.08 (chart)
Docker_Windows	TestDownloadOnlyKic (gopogh)	20.53 (chart)
Docker_Windows	TestDownloadOnly/v1.14.0/preload-exists (gopogh)	20.53 (chart)
Docker_Windows	TestDownloadOnly/v1.22.2/preload-exists (gopogh)	20.53 (chart)
Docker_Windows	TestDownloadOnly/v1.22.3-rc.0/preload-exists (gopogh)	20.53 (chart)
Docker_Windows	TestPause/serial/DeletePaused (gopogh)	26.49 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	85.43 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)
Docker_Windows	TestCertOptions (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-10-15T00:04:59Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12711) |
+----------------+----------+---------------------+
| minikube start | 47.3s    | 46.8s               |
| enable ingress | 30.9s    | 31.2s               |
+----------------+----------+---------------------+

Times for minikube start: 49.2s 46.5s 48.0s 46.1s 46.6s
Times for minikube (PR 12711) start: 47.1s 46.9s 45.8s 47.3s 47.0s

Times for minikube ingress: 31.8s 30.2s 31.3s 30.3s 31.2s
Times for minikube (PR 12711) ingress: 32.7s 31.3s 30.7s 29.7s 31.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12711) |
+----------------+----------+---------------------+
| minikube start | 21.2s    | 21.7s               |
| enable ingress | 28.5s    | 28.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.4s 26.9s 26.9s 34.4s 26.9s
Times for minikube (PR 12711) ingress: 33.9s 30.4s 26.4s 26.9s 26.9s

Times for minikube start: 21.9s 21.0s 21.3s 20.9s 21.0s
Times for minikube (PR 12711) start: 21.7s 23.0s 20.9s 21.3s 21.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12711) |
+----------------+----------+---------------------+
| minikube start | 39.9s    | 43.5s               |
| enable ingress | 33.1s    | 26.3s               |
+----------------+----------+---------------------+

Times for minikube start: 26.2s 43.1s 43.7s 43.9s 42.8s
Times for minikube (PR 12711) start: 42.4s 44.3s 43.9s 43.8s 42.9s

Times for minikube ingress: 34.9s 31.9s 32.9s 32.9s 32.9s
Times for minikube (PR 12711) ingress: 33.0s 17.9s 18.9s 28.9s 32.9s

minikube-pr-bot · 2021-10-15T01:15:34Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12711) |
+----------------+----------+---------------------+
| minikube start | 48.3s    | 47.1s               |
| enable ingress | 32.2s    | 34.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 32.8s 35.8s 30.8s 30.8s 30.7s
Times for minikube (PR 12711) ingress: 46.2s 32.2s 32.3s 31.8s 30.3s

Times for minikube start: 50.4s 49.3s 47.6s 47.7s 46.5s
Times for minikube (PR 12711) start: 48.1s 47.0s 45.5s 47.5s 47.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12711) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 21.3s               |
| enable ingress | 29.8s    | 28.4s               |
+----------------+----------+---------------------+

Times for minikube start: 22.3s 20.7s 23.5s 21.1s 21.9s
Times for minikube (PR 12711) start: 21.8s 21.2s 21.5s 20.5s 21.5s

Times for minikube ingress: 26.4s 27.9s 31.5s 28.9s 34.5s
Times for minikube (PR 12711) ingress: 26.9s 33.9s 26.4s 27.9s 26.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12711) |
+----------------+----------+---------------------+
| minikube start | 39.9s    | 36.5s               |
| enable ingress | 29.4s    | 30.3s               |
+----------------+----------+---------------------+

Times for minikube start: 31.1s 37.0s 44.2s 44.0s 43.4s
Times for minikube (PR 12711) start: 26.3s 42.4s 44.0s 44.1s 25.9s

Times for minikube ingress: 33.4s 29.5s 32.9s 27.9s 23.4s
Times for minikube (PR 12711) ingress: 33.9s 26.9s 23.0s 32.9s 34.9s

minikube-pr-bot · 2021-10-15T01:17:26Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
none_Linux	TestMountStart/serial/StartWithMountFirst (gopogh)	n/a
none_Linux	TestMountStart/serial/StartWithMountSecond (gopogh)	n/a
none_Linux	TestMountStart/serial/VerifyMountFirst (gopogh)	n/a
none_Linux	TestMountStart/serial/VerifyMountPostDelete (gopogh)	n/a
none_Linux	TestMountStart/serial/VerifyMountSecond (gopogh)	n/a
Docker_Linux_containerd	TestNetworkPlugins/group/enable-default-cni/Start (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestStartStop/group/old-k8s-version/serial/Pause (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestNetworkPlugins/group/kindnet/Start (gopogh)	1.30 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	6.98 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	9.30 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/custom-weave/Start (gopogh)	11.63 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/enable-default-cni/Start (gopogh)	13.95 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/false/Start (gopogh)	13.95 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	16.28 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/flannel/Start (gopogh)	16.28 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	16.28 (chart)
Docker_Windows	TestDownloadOnlyKic (gopogh)	22.54 (chart)
Docker_Windows	TestDownloadOnly/v1.14.0/preload-exists (gopogh)	22.54 (chart)
Docker_Windows	TestDownloadOnly/v1.22.2/preload-exists (gopogh)	22.54 (chart)
Docker_Windows	TestDownloadOnly/v1.22.3-rc.0/preload-exists (gopogh)	22.54 (chart)
Hyper-V_Windows	TestErrorSpam/setup (gopogh)	23.26 (chart)
Hyper-V_Windows	TestDownloadOnly/v1.14.0/preload-exists (gopogh)	58.14 (chart)
Hyper-V_Windows	TestDownloadOnly/v1.22.2/preload-exists (gopogh)	58.14 (chart)
Hyper-V_Windows	TestDownloadOnly/v1.22.3-rc.0/preload-exists (gopogh)	58.14 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/DNS (gopogh)	83.18 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	84.51 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)
Docker_Windows	TestCertOptions (gopogh)	100.00 (chart)
Docker_Windows	TestPause/serial/VerifyDeletedResources (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	100.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-10-15T03:03:22Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
KVM_Linux	TestScheduledStopUnix (gopogh)	1.30 (chart)
Docker_Linux_containerd	TestOffline (gopogh)	1.32 (chart)
Docker_Windows	TestNetworkPlugins/group/false/DNS (gopogh)	13.39 (chart)
Hyper-V_Windows	TestErrorSpam/setup (gopogh)	22.73 (chart)
Docker_Windows	TestDownloadOnlyKic (gopogh)	23.08 (chart)
Docker_Windows	TestDownloadOnly/v1.14.0/preload-exists (gopogh)	23.08 (chart)
Docker_Windows	TestDownloadOnly/v1.22.2/preload-exists (gopogh)	23.08 (chart)
Docker_Windows	TestDownloadOnly/v1.22.3-rc.0/preload-exists (gopogh)	23.08 (chart)
Hyper-V_Windows	TestDownloadOnly/v1.14.0/preload-exists (gopogh)	59.09 (chart)
Hyper-V_Windows	TestDownloadOnly/v1.22.2/preload-exists (gopogh)	59.09 (chart)
Hyper-V_Windows	TestDownloadOnly/v1.22.3-rc.0/preload-exists (gopogh)	59.09 (chart)
Docker_Windows	TestNetworkPlugins/group/custom-weave/Start (gopogh)	73.43 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	84.62 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)
Docker_Windows	TestCertOptions (gopogh)	100.00 (chart)
Docker_Windows	TestPause/serial/VerifyDeletedResources (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/RestartKeepsNodes (gopogh)	100.00 (chart)
Hyper-V_Windows	TestRunningBinaryUpgrade (gopogh)	100.00 (chart)
Hyper-V_Windows	TestStoppedBinaryUpgrade/Upgrade (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

spowelljr · 2021-10-15T16:12:49Z

/retest-this-please

minikube-pr-bot · 2021-10-15T17:07:29Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12711) |
+----------------+----------+---------------------+
| minikube start | 47.5s    | 46.8s               |
| enable ingress | 32.0s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 12711) start: 47.0s 46.9s 45.7s 47.1s 47.4s
Times for minikube start: 50.2s 47.6s 47.6s 46.2s 46.1s

Times for minikube ingress: 31.8s 32.3s 31.8s 33.3s 30.8s
Times for minikube (PR 12711) ingress: 30.3s 31.8s 31.2s 32.5s 31.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12711) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.9s               |
| enable ingress | 28.3s    | 29.1s               |
+----------------+----------+---------------------+

Times for minikube (PR 12711) start: 21.3s 21.9s 22.5s 22.1s 21.5s
Times for minikube start: 23.0s 20.8s 21.4s 21.8s 20.9s

Times for minikube ingress: 31.4s 28.4s 27.5s 26.9s 27.4s
Times for minikube (PR 12711) ingress: 27.4s 27.9s 27.4s 27.9s 34.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12711) |
+----------------+----------+---------------------+
| minikube start | 40.8s    | 43.4s               |
| enable ingress | 35.8s    | 32.6s               |
+----------------+----------+---------------------+

Times for minikube start: 27.1s 44.4s 44.6s 43.4s 44.6s
Times for minikube (PR 12711) start: 43.6s 43.0s 43.6s 43.5s 43.6s

Times for minikube ingress: 46.9s 29.4s 28.9s 36.9s 36.9s
Times for minikube (PR 12711) ingress: 33.9s 33.4s 36.5s 29.4s 29.9s

minikube-pr-bot · 2021-10-15T18:33:48Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestForceSystemdEnv (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

k8s-ci-robot · 2021-10-15T18:51:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fix mounting on non-default profile & make mounting processes cluster…

2a489bf

… independent

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2021

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2021

k8s-ci-robot requested review from prezha and sharifelgamal October 14, 2021 21:46

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2021

updated docs

ad47329

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2021

sharifelgamal reviewed Oct 14, 2021

View reviewed changes

test/integration/mount_start_test.go Show resolved Hide resolved

cmd/minikube/cmd/delete.go Outdated Show resolved Hide resolved

add backwards compatible mount-process delete

9a89855

skip test on none driver

0623f34

spowelljr force-pushed the fixMount branch from aa63707 to 0623f34 Compare October 15, 2021 00:27

remove unnecessary join

0fcf1ed

sharifelgamal approved these changes Oct 15, 2021

View reviewed changes

spowelljr merged commit 99661e6 into kubernetes:master Oct 15, 2021

spowelljr deleted the fixMount branch October 15, 2021 19:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix mounting on non-default profile #12711

Fix mounting on non-default profile #12711

spowelljr commented Oct 14, 2021

spowelljr commented Oct 14, 2021

minikube-pr-bot commented Oct 14, 2021

minikube-pr-bot commented Oct 14, 2021

minikube-pr-bot commented Oct 15, 2021

minikube-pr-bot commented Oct 15, 2021

minikube-pr-bot commented Oct 15, 2021

minikube-pr-bot commented Oct 15, 2021

spowelljr commented Oct 15, 2021

minikube-pr-bot commented Oct 15, 2021

minikube-pr-bot commented Oct 15, 2021

k8s-ci-robot commented Oct 15, 2021

Fix mounting on non-default profile #12711

Fix mounting on non-default profile #12711

Conversation

spowelljr commented Oct 14, 2021

spowelljr commented Oct 14, 2021

minikube-pr-bot commented Oct 14, 2021

minikube-pr-bot commented Oct 14, 2021

minikube-pr-bot commented Oct 15, 2021

minikube-pr-bot commented Oct 15, 2021

minikube-pr-bot commented Oct 15, 2021

minikube-pr-bot commented Oct 15, 2021

spowelljr commented Oct 15, 2021

minikube-pr-bot commented Oct 15, 2021

minikube-pr-bot commented Oct 15, 2021

k8s-ci-robot commented Oct 15, 2021