Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill mount process before stopping nodes #12716

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Oct 15, 2021

Fixes #12649

Problem:
minikube stop with the Hyper-V driver and with mount enabled takes 9 minutes to complete. But stopping with the mount process killed takes a normal amount of time.

Solution:
Change order of operations to kill mount process before stopping nodes.

Before: minikube stop took 9 minutes on my machine
Now: minikube stop took 23 seconds

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 15, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2021
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12716) |
+----------------+----------+---------------------+
| minikube start | 47.1s    | 46.7s               |
| enable ingress | 31.7s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube start: 49.1s 47.1s 45.7s 46.4s 47.1s
Times for minikube (PR 12716) start: 47.5s 46.7s 46.4s 46.9s 45.9s

Times for minikube ingress: 31.8s 30.3s 33.2s 31.9s 31.2s
Times for minikube (PR 12716) ingress: 31.3s 31.2s 31.8s 31.2s 30.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12716) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.4s               |
| enable ingress | 29.9s    | 30.0s               |
+----------------+----------+---------------------+

Times for minikube start: 21.5s 22.3s 21.3s 20.6s 22.2s
Times for minikube (PR 12716) start: 21.0s 20.5s 20.7s 23.6s 21.4s

Times for minikube ingress: 28.4s 34.4s 26.4s 33.9s 26.4s
Times for minikube (PR 12716) ingress: 27.9s 35.4s 26.4s 34.4s 25.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12716) |
+----------------+----------+---------------------+
| minikube start | 38.9s    | 39.7s               |
| enable ingress | 28.7s    | 32.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.4s 32.9s 26.5s 36.9s 18.9s
Times for minikube (PR 12716) ingress: 25.4s 38.4s 32.9s 32.9s 32.9s

Times for minikube start: 33.7s 44.1s 36.4s 36.2s 44.0s
Times for minikube (PR 12716) start: 36.7s 30.6s 43.9s 43.8s 43.7s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestMountStart/serial/StartWithMountFirst (gopogh) 0.00 (chart)
Docker_Linux_containerd TestMountStart/serial/VerifyMountFirst (gopogh) 0.00 (chart)
Docker_Windows TestStartStop/group/no-preload/serial/Pause (gopogh) 8.70 (chart)
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) 15.75 (chart)
Docker_Windows TestDownloadOnlyKic (gopogh) 28.57 (chart)
Docker_Windows TestDownloadOnly/v1.14.0/preload-exists (gopogh) 28.57 (chart)
Docker_Windows TestDownloadOnly/v1.22.2/preload-exists (gopogh) 28.57 (chart)
Docker_Windows TestDownloadOnly/v1.22.3-rc.0/preload-exists (gopogh) 28.57 (chart)
Hyper-V_Windows TestDownloadOnly/v1.14.0/preload-exists (gopogh) 63.27 (chart)
Hyper-V_Windows TestDownloadOnly/v1.22.2/preload-exists (gopogh) 63.27 (chart)
Hyper-V_Windows TestDownloadOnly/v1.22.3-rc.0/preload-exists (gopogh) 63.27 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 72.14 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 82.86 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)
Docker_Windows TestCertOptions (gopogh) 100.00 (chart)
Docker_Windows TestPause/serial/VerifyDeletedResources (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit c073e65 into kubernetes:master Oct 18, 2021
@spowelljr spowelljr deleted the fixHyperVStop branch October 18, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube stop hangs when local file system is mounted
4 participants