Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minikube addons list shows addons if cluster does not exist #12837

Merged
merged 1 commit into from
Nov 1, 2021
Merged

minikube addons list shows addons if cluster does not exist #12837

merged 1 commit into from
Nov 1, 2021

Conversation

spowelljr
Copy link
Member

Closes #12736

Before:

$ minikube addons list
🤷  Profile "minikube" not found. Run "minikube profile list" to view all profiles.
👉  To start a cluster, run: "minikube start"

Now:

$ minikube addons list
|-----------------------------|-----------------------|
|         ADDON NAME          |      MAINTAINER       |
|-----------------------------|-----------------------|
| ambassador                  | unknown (third-party) |
| auto-pause                  | google                |
| csi-hostpath-driver         | kubernetes            |
| dashboard                   | kubernetes            |
| default-storageclass        | kubernetes            |
| efk                         | unknown (third-party) |
| freshpod                    | google                |
| gcp-auth                    | google                |
| gvisor                      | google                |
| helm-tiller                 | unknown (third-party) |
| ingress                     | unknown (third-party) |
| ingress-dns                 | unknown (third-party) |
| istio                       | unknown (third-party) |
| istio-provisioner           | unknown (third-party) |
| kubevirt                    | unknown (third-party) |
| logviewer                   | google                |
| metallb                     | unknown (third-party) |
| metrics-server              | kubernetes            |
| nvidia-driver-installer     | google                |
| nvidia-gpu-device-plugin    | unknown (third-party) |
| olm                         | unknown (third-party) |
| pod-security-policy         | unknown (third-party) |
| portainer                   | portainer.io          |
| registry                    | google                |
| registry-aliases            | unknown (third-party) |
| registry-creds              | unknown (third-party) |
| storage-provisioner         | kubernetes            |
| storage-provisioner-gluster | unknown (third-party) |
| volumesnapshots             | kubernetes            |
|-----------------------------|-----------------------|

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2021
@sharifelgamal
Copy link
Collaborator

LGTM. Maybe add a unit test?

@spowelljr
Copy link
Member Author

LGTM. Maybe add a unit test?

Sure, will do!

@medyagh
Copy link
Member

medyagh commented Nov 1, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 1, 2021
medyagh
medyagh reviewed Nov 1, 2021
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spowelljr can u plz also paste output of --output=json I am curious what it shows for that

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12837) |
+----------------+----------+---------------------+
| minikube start | 47.4s    | 47.3s               |
| enable ingress | 32.5s    | 31.9s               |
+----------------+----------+---------------------+

Times for minikube start: 49.5s 47.1s 47.6s 46.3s 46.5s
Times for minikube (PR 12837) start: 46.9s 46.0s 48.6s 48.2s 46.9s

Times for minikube ingress: 30.8s 33.2s 31.7s 33.9s 32.7s
Times for minikube (PR 12837) ingress: 31.7s 31.7s 31.8s 30.8s 33.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12837) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 21.9s               |
| enable ingress | 32.0s    | 30.0s               |
+----------------+----------+---------------------+

Times for minikube start: 22.2s 21.0s 21.6s 20.7s 22.1s
Times for minikube (PR 12837) start: 22.3s 23.1s 21.9s 21.5s 21.0s

Times for minikube ingress: 27.4s 28.4s 35.5s 34.4s 34.4s
Times for minikube (PR 12837) ingress: 31.4s 27.9s 27.9s 34.4s 28.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12837) |
+----------------+----------+---------------------+
| minikube start | 40.0s    | 42.7s               |
| enable ingress | 35.8s    | 29.8s               |
+----------------+----------+---------------------+

Times for minikube start: 27.6s 43.6s 41.6s 43.6s 43.4s
Times for minikube (PR 12837) start: 42.8s 43.6s 44.3s 43.6s 39.0s

Times for minikube (PR 12837) ingress: 32.9s 32.9s 27.9s 22.9s 32.4s
Times for minikube ingress: 39.4s 36.9s 32.9s 32.9s 36.9s

@medyagh
Copy link
Member

medyagh commented Nov 1, 2021

thank you for this PR

@medyagh medyagh merged commit c573330 into kubernetes:master Nov 1, 2021
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 0.00 (chart)
Docker_Windows TestNetworkPlugins/group/cilium/Start (gopogh) 2.31 (chart)
KVM_Linux_containerd TestRunningBinaryUpgrade (gopogh) 4.00 (chart)
Docker_Linux_containerd TestPause/serial/Pause (gopogh) 18.71 (chart)
Docker_Linux_containerd TestPause/serial/VerifyStatus (gopogh) 18.71 (chart)
Docker_Windows TestMountStart/serial/StartWithMountFirst (gopogh) 94.62 (chart)
Docker_Windows TestMountStart/serial/StartWithMountSecond (gopogh) 94.62 (chart)
Docker_Windows TestMountStart/serial/VerifyMountFirst (gopogh) 94.62 (chart)
Docker_Windows TestMountStart/serial/VerifyMountPostDelete (gopogh) 94.62 (chart)
Docker_Windows TestMountStart/serial/VerifyMountSecond (gopogh) 94.62 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)
Docker_Windows TestCertOptions (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/RestartStopped (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/Stop (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountPostStop (gopogh) 100.00 (chart)
Docker_Windows TestPause/serial/VerifyDeletedResources (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr mentioned this pull request Nov 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh left review comments

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

addon list should list addons even if minikube cluster is not running
5 participants
@spowelljr @k8s-ci-robot @sharifelgamal @medyagh @minikube-pr-bot