-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix zsh completion #12841
fix zsh completion #12841
Conversation
Hi @Keyhoh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Keyhoh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Keyhoh there is no way for me to test this,
would u plz share the output of minikube in the PR description ? before and after this PR ?
thanks @medyagh ! |
thank you @Keyhoh |
my previous fix is wrong
zsh completion is not working in v1.24.0-beta.0
revert wrong change (#12420) and re-fix
before PR (v1.24.0-beta.0)
tab completion does not work
$ out/minikube version minikube version: v1.24.0-beta.0 commit: 06b3f0a03b012632c86627e227cfeb29b12aed5c $ out/minikube completion zsh > before.completion.txt
before.completion.txt
after PR
completion works
$ out/minikube version minikube version: v1.24.0-beta.0 commit: ca928b43ed86ed65056700dba67ec1a5e0b5714e $ out/minikube completion zsh > after.completion.txt
after.completion.txt
stable release
completion is broken
$ out/minikube version minikube version: v1.23.2 commit: 0a0ad764652082477c00d51d2475284b5d39ceed $ out/minikube completion zsh > v1.23.completion.txt
v1.23.completion.txt