-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CRI-O runtime with Rootless Docker driver (--driver=docker --container-runtime=cri-o
)
#12900
Conversation
Follow-up to PR 12359 (containerd runtime with Rootless Docker driver). Usage (needs cgroup v2): ``` dockerd-rootless-setuptool.sh install docker context use rootless minikube start --driver=docker --container-runtime=cri-o ``` See site/content/en/docs/drivers/includes/docker_usage.inc Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
cc @giuseppe FYI |
e045c9c
to
d7e7284
Compare
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 70.1s 71.2s 71.4s 71.9s 69.2s Times for minikube ingress: 31.3s 32.7s 31.8s 32.3s 31.2s docker driver with docker runtime
Times for minikube start: 37.2s 36.2s 35.7s 36.0s 35.9s Times for minikube ingress: 25.4s 26.4s 28.5s 27.4s 26.9s docker driver with containerd runtime
Times for minikube start: 38.7s 41.6s 39.7s 40.0s 38.8s Times for minikube ingress: 46.4s 40.4s 32.4s 38.4s 41.9s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AkihiroSuda, giuseppe, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thank you very much @AkihiroSuda for this contribution :) look forward to see more of your great work |
Follow-up to PR #12359 (containerd runtime with Rootless Docker driver).
Usage (needs cgroup v2):
See
site/content/en/docs/drivers/includes/docker_usage.inc
Tested on Ubuntu 21.10 host, Rootless Docker 20.10.10