Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CRI-O runtime with Rootless Docker driver (--driver=docker --container-runtime=cri-o) #12900

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

AkihiroSuda
Copy link
Member

Follow-up to PR #12359 (containerd runtime with Rootless Docker driver).

Usage (needs cgroup v2):

dockerd-rootless-setuptool.sh install
docker context use rootless
minikube start --driver=docker --container-runtime=cri-o

See site/content/en/docs/drivers/includes/docker_usage.inc


Tested on Ubuntu 21.10 host, Rootless Docker 20.10.10

$ kubectl get nodes -o wide
NAME       STATUS   ROLES                  AGE    VERSION   INTERNAL-IP    EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION      CONTAINER-RUNTIME
minikube   Ready    control-plane,master   104s   v1.22.3   192.168.49.2   <none>        Ubuntu 20.04.2 LTS   5.13.0-20-generic   cri-o://1.22.0

$ kubectl get pods -A
NAMESPACE     NAME                               READY   STATUS    RESTARTS      AGE
kube-system   coredns-78fcd69978-kpsfg           1/1     Running   0             79s
kube-system   etcd-minikube                      1/1     Running   0             85s
kube-system   kindnet-546zq                      1/1     Running   0             79s
kube-system   kube-apiserver-minikube            1/1     Running   0             93s
kube-system   kube-controller-manager-minikube   1/1     Running   0             92s
kube-system   kube-proxy-w45xb                   1/1     Running   0             79s
kube-system   kube-scheduler-minikube            1/1     Running   0             86s
kube-system   storage-provisioner                1/1     Running   1 (48s ago)   89s

Follow-up to PR 12359 (containerd runtime with Rootless Docker driver).

Usage (needs cgroup v2):
```
dockerd-rootless-setuptool.sh install
docker context use rootless
minikube start --driver=docker --container-runtime=cri-o
```

See site/content/en/docs/drivers/includes/docker_usage.inc

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 9, 2021
@AkihiroSuda
Copy link
Member Author

cc @giuseppe FYI

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 9, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@medyagh
Copy link
Member

medyagh commented Nov 9, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 9, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12900) |
+----------------+----------+---------------------+
| minikube start | 70.8s    | 52.4s               |
| enable ingress | 31.9s    | 32.3s               |
+----------------+----------+---------------------+

Times for minikube start: 70.1s 71.2s 71.4s 71.9s 69.2s
Times for minikube (PR 12900) start: 56.9s 52.2s 49.8s 51.5s 51.7s

Times for minikube ingress: 31.3s 32.7s 31.8s 32.3s 31.2s
Times for minikube (PR 12900) ingress: 31.8s 32.3s 32.8s 33.3s 31.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12900) |
+----------------+----------+---------------------+
| minikube start | 36.2s    | 25.7s               |
| enable ingress | 26.9s    | 31.1s               |
+----------------+----------+---------------------+

Times for minikube start: 37.2s 36.2s 35.7s 36.0s 35.9s
Times for minikube (PR 12900) start: 25.6s 26.4s 25.1s 25.5s 25.9s

Times for minikube ingress: 25.4s 26.4s 28.5s 27.4s 26.9s
Times for minikube (PR 12900) ingress: 29.5s 29.4s 29.9s 33.4s 33.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12900) |
+----------------+----------+---------------------+
| minikube start | 39.8s    | 52.8s               |
| enable ingress | 39.9s    | 29.3s               |
+----------------+----------+---------------------+

Times for minikube start: 38.7s 41.6s 39.7s 40.0s 38.8s
Times for minikube (PR 12900) start: 50.5s 49.8s 53.4s 53.0s 57.2s

Times for minikube ingress: 46.4s 40.4s 32.4s 38.4s 41.9s
Times for minikube (PR 12900) ingress: 22.9s 23.9s 37.4s 32.4s 29.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestNoKubernetes/serial/Start (gopogh) 2.13 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 28.35 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 70.87 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 74.80 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 81.60 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 83.20 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 85.04 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/RestartStopped (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/StartWithMountFirst (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/StartWithMountSecond (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/Stop (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountFirst (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountPostDelete (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountPostStop (gopogh) 100.00 (chart)
Docker_Windows TestMountStart/serial/VerifyMountSecond (gopogh) 100.00 (chart)
Docker_Windows TestPause/serial/VerifyDeletedResources (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, giuseppe, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2021
@medyagh
Copy link
Member

medyagh commented Nov 12, 2021

thank you very much @AkihiroSuda for this contribution :) look forward to see more of your great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants