Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO: Podman 3.4.2 #13126

Merged
merged 2 commits into from
Mar 23, 2022
Merged

ISO: Podman 3.4.2 #13126

merged 2 commits into from
Mar 23, 2022

Conversation

afbjorklund
Copy link
Collaborator

Continuing from PR #11727

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2021
@medyagh
Copy link
Member

medyagh commented Dec 8, 2021

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2021
@afbjorklund afbjorklund mentioned this pull request Dec 13, 2021
Closed
@k8s-ci-robot

This comment has been minimized.

Sign in to view
@afbjorklund
Copy link
Collaborator Author

/reopen

@k8s-ci-robot
Copy link
Contributor

@afbjorklund: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Feb 2, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 2, 2022
@minikube-bot

This comment has been minimized.

Sign in to view
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 2, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 2, 2022
@afbjorklund
Copy link
Collaborator Author

ok-to-build-iso

@afbjorklund
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 4, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13126) |
+----------------+----------+---------------------+
| minikube start | 44.2s    | 44.4s               |
| enable ingress | 30.0s    | 28.5s               |
+----------------+----------+---------------------+

Times for minikube start: 44.4s 44.1s 43.9s 43.8s 45.0s
Times for minikube (PR 13126) start: 44.7s 43.4s 44.7s 44.4s 44.8s

Times for minikube ingress: 30.1s 27.1s 30.6s 32.5s 29.5s
Times for minikube (PR 13126) ingress: 26.1s 27.0s 28.6s 31.0s 29.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13126) |
+----------------+----------+---------------------+
| minikube start | 26.0s    | 26.2s               |
| enable ingress | 35.2s    | 23.7s               |
+----------------+----------+---------------------+

Times for minikube start: 26.2s 25.7s 25.8s 26.1s 26.1s
Times for minikube (PR 13126) start: 26.0s 27.1s 26.1s 25.8s 25.8s

Times for minikube ingress: 23.0s 23.9s 21.9s 23.4s 84.0s
Times for minikube (PR 13126) ingress: 24.4s 23.4s 23.9s 23.9s 23.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13126) |
+----------------+----------+---------------------+
| minikube start | 43.7s    | 41.6s               |
| enable ingress | 21.7s    | 29.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 18.9s 23.4s 21.9s 23.4s 20.9s
Times for minikube (PR 13126) ingress: 23.4s 23.4s 55.4s 23.4s 23.4s

Times for minikube start: 45.3s 41.8s 44.9s 41.6s 45.0s
Times for minikube (PR 13126) start: 41.4s 42.1s 41.3s 41.4s 41.7s

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/13126/a3ead51/iso_build.txt

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
none_Linux TestFunctional/parallel/DashboardCmd (gopogh) 0.84 (chart)
Docker_Linux TestFunctional/serial/ComponentHealth (gopogh) 3.70 (chart)
Docker_macOS TestJSONOutput/pause/Command (gopogh) 11.71 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 22.35 (chart)
Docker_macOS TestAddons/parallel/MetricsServer (gopogh) 28.18 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 44.44 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 44.44 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 45.45 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 45.45 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/Start (gopogh) 50.00 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 50.00 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 51.79 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 51.85 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 51.85 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 58.75 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/DNS (gopogh) 60.32 (chart)
Docker_Cloud_Shell TestAddons/parallel/MetricsServer (gopogh) 61.76 (chart)
Docker_Linux TestNetworkPlugins/group/custom-weave/Start (gopogh) 62.04 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 65.45 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 65.45 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 66.07 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 66.67 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 71.30 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 77.78 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 78.46 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 78.69 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 81.48 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 82.41 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 82.81 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 99.02 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 8f0e467 into kubernetes:master Mar 23, 2022
@afbjorklund afbjorklund mentioned this pull request Mar 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueelvis blueelvis Awaiting requested review from blueelvis

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@afbjorklund @k8s-ci-robot @medyagh @minikube-bot @minikube-pr-bot