Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reference to nonexistent file for hyperkit driver #13418

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

sharifelgamal
Copy link
Collaborator

No description provided.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 20, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2022
@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 20, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13418) |
+----------------+----------+---------------------+
| minikube start | 45.0s    | 44.5s               |
| enable ingress | 29.2s    | 28.8s               |
+----------------+----------+---------------------+

Times for minikube start: 46.2s 45.2s 45.3s 44.3s 44.0s
Times for minikube (PR 13418) start: 44.9s 45.2s 44.1s 43.2s 45.1s

Times for minikube (PR 13418) ingress: 28.6s 30.0s 25.0s 30.1s 30.0s
Times for minikube ingress: 30.6s 28.6s 29.5s 29.1s 28.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13418) |
+----------------+----------+---------------------+
| minikube start | 26.0s    | 26.3s               |
| enable ingress | 22.4s    | 35.1s               |
+----------------+----------+---------------------+

Times for minikube start: 26.7s 25.4s 26.1s 26.1s 25.5s
Times for minikube (PR 13418) start: 26.3s 26.4s 25.9s 26.7s 26.0s

Times for minikube ingress: 23.9s 22.4s 20.4s 22.0s 23.4s
Times for minikube (PR 13418) ingress: 22.9s 84.4s 23.0s 23.0s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13418) |
+----------------+----------+---------------------+
| minikube start | 41.2s    | 43.5s               |
| enable ingress | 23.0s    | 21.0s               |
+----------------+----------+---------------------+

Times for minikube start: 33.9s 40.9s 45.0s 41.4s 44.5s
Times for minikube (PR 13418) start: 45.7s 43.8s 41.3s 41.5s 45.1s

Times for minikube ingress: 19.9s 23.5s 29.4s 23.4s 18.9s
Times for minikube (PR 13418) ingress: 18.9s 19.9s 23.4s 23.4s 19.4s

@sharifelgamal sharifelgamal merged commit 5ceae0b into kubernetes:master Jan 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants