drivers/kvm: Use ARP for retrieving interface ip addresses #13482
Conversation
k8s-ci-robot
added
the
do-not-merge/invalid-commit-message
|
|
|
Welcome @anoopcs9! |
|
Hi @anoopcs9. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
|
Can one of the admins verify this patch? |
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
cncf-cla: no
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
/unassign @prezha |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
kvm2 driver with docker runtime Times for minikube (PR 13482) start: 62.3s 62.7s 61.7s 62.8s 63.2s Times for minikube ingress: 28.1s 29.6s 28.5s 26.1s 29.0s docker driver with docker runtime Times for minikube start: 40.5s 39.8s 38.8s 40.0s 39.5s Times for minikube ingress: 21.9s 22.0s 22.9s 22.9s 24.9s docker driver with containerd runtime Times for minikube ingress: 29.9s 29.9s 29.9s 29.9s 29.9s Times for minikube start: 47.1s 47.3s 46.4s 46.3s 47.1s |
|
@anoopcs9 I an curious do u mind listing what platfroms are like that ? and should we fall back to the old system in case this one fails as a fail over? |
|
@anoopcs9 Thank you for this PR, do u mind sigining the CLA so we could accept contributions? |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
I was facing problems with CentOS 8(8.5) as mentioned in linked issue #11459. I have also shared my findings as a comment on the issue.
see my inline reply |
k8s-ci-robot
added
size/S
@medyagh, What to do with these failures? I hope the change from this PR is not the culprit :-/ |
|
kvm2 driver with docker runtime Times for minikube start: 48.5s 44.4s 44.1s 44.4s 44.0s Times for minikube ingress: 31.1s 29.6s 29.6s 30.6s 26.6s docker driver with docker runtime Times for minikube start: 27.8s 26.6s 26.3s 27.1s 26.4s Times for minikube ingress: 27.4s 26.5s 32.9s 24.9s 30.9s docker driver with containerd runtime Times for minikube start: 36.4s 45.0s 45.6s 42.3s 45.4s Times for minikube ingress: 39.9s 27.0s 19.4s 22.9s 19.9s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
The failures are not unexpected, the rightmost column is what % of the time they fail. |
|
thank you very much @anoopcs9 for improving the KVM driver, just a minor spelling error then we are good to go ! |
|
/check-cla |
|
kvm2 driver with docker runtime Times for minikube start: 45.7s 43.7s 44.2s 43.6s 44.0s Times for minikube ingress: 25.5s 30.0s 29.1s 28.6s 30.5s docker driver with docker runtime Times for minikube start: 30.9s 25.0s 26.2s 26.6s 26.5s Times for minikube ingress: 19.9s 22.4s 22.9s 22.9s 83.4s docker driver with containerd runtime Times for minikube start: 30.1s 45.6s 44.5s 41.4s 44.8s Times for minikube ingress: 23.4s 19.4s 19.9s 23.4s 19.4s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
kvm2 driver with docker runtime Times for minikube start: 44.6s 44.5s 50.0s 43.8s 45.1s Times for minikube ingress: 29.5s 30.1s 30.6s 26.0s 28.5s docker driver with docker runtime |
My bad. I had accidentally revoked authorization for Linux Foundation: EasyCLA OAuth App. I have reauthorized and it passes now. |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
/check-cla |
|
@anoopcs9 I am curious hve u signed the CLA with the same email in your git config from the time u did "git commit" do u mind checking ? |
On platforms where dhcp lease status is not updated immediately after domain creation it fails to list ip addresses until next refresh happens resulting in the following error: 8<----------8<----------8<----------8<----------8<----------8<---------- Creating kvm2 VM (CPUs=2, Memory=4096MB, Disk=20480MB) ... Failed to start kvm2 VM. Running "minikube delete" may fix it: creating host: create: Error creating machine: Error in driver during machine creation: IP not available after waiting: machine minikube didn't return IP after 1 minute Exiting due to GUEST_PROVISION: Failed to start host: creating host: create: Error creating machine: Error in driver during machine creation: IP not available after waiting: machine minikube didn't return IP after 1 minute 8<----------8<----------8<----------8<----------8<----------8<---------- Using ARP instead of LEASE for ip address query is justifiable as listing is done following the domain creation. In case of failure we fallback to listing via LEASE source. Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
|
/check-cla |
k8s-ci-robot
added
cncf-cla: yes
|
kvm2 driver with docker runtime Times for minikube ingress: 29.1s 25.6s 30.5s 25.5s 26.6s Times for minikube (PR 13482) start: 43.7s 50.4s 44.4s 45.1s 43.9s docker driver with docker runtime Times for minikube start: 26.6s 26.0s 26.1s 25.7s 26.8s Times for minikube ingress: 24.0s 21.9s 22.9s 22.9s 22.9s docker driver with containerd runtime Times for minikube start: 30.5s 42.5s 44.7s 45.5s 45.8s Times for minikube ingress: 23.4s 23.4s 28.9s 19.4s 19.4s |
It was to do with my LF account. |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anoopcs9, sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thank you for your contribution! |
On platforms where dhcp lease status is not updated immediately after domain creation it fails to list ip addresses until next refresh happens resulting in the following error:
Using ARP instead of LEASE for ip address query is justifiable as listing is done following the domain creation.
fixes #11459