Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hard coded docker driver in minikube service command #13514

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

presztak
Copy link
Member

This PR inroduces fix for bug similar to this one: #12594 but this time minikube service command is affected.
Docker driver is hard coded in ForwardPort function. This will lead to error when user is using podman instead of docker driver.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 29, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @presztak. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: presztak
To complete the pull request process, please assign prezha after the PR has been reviewed.
You can assign the PR to them by writing /assign @prezha in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2022
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestMultiNode/serial/DeleteNode (gopogh) 0.00 (chart)
Hyperkit_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 0.00 (chart)
Hyperkit_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 0.00 (chart)
Hyperkit_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 0.00 (chart)
Hyperkit_macOS TestMultiNode/serial/RestartMultiNode (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/custom-weave/Start (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 0.00 (chart)
Hyperkit_macOS TestMultiNode/serial/FreshStart2Nodes (gopogh) 1.25 (chart)
Hyperkit_macOS TestNetworkPlugins/group/calico/Start (gopogh) 1.25 (chart)
Docker_macOS TestDownloadOnly/v1.23.2/preload-exists (gopogh) 3.12 (chart)
KVM_Linux TestDockerFlags (gopogh) 7.89 (chart)
Hyperkit_macOS TestSkaffold (gopogh) 11.25 (chart)
KVM_Linux_containerd TestCertExpiration (gopogh) 12.50 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 13.73 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/EnableAddonAfterStop (gopogh) 13.73 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh) 13.73 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 13.73 (chart)
Docker_macOS TestDownloadOnlyKic (gopogh) 14.86 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 15.69 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh) 15.69 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 15.69 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 15.69 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/Stop (gopogh) 15.69 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 17.65 (chart)
KVM_Linux_containerd TestNoKubernetes/serial/StartWithStopK8s (gopogh) 22.39 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/DNS (gopogh) 37.04 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 45.10 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/Start (gopogh) 45.83 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/Pause (gopogh) 51.92 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 54.17 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 30b187f into kubernetes:master Feb 1, 2022
@totollygeek
Copy link

Is there a way to workaround the issue, without installing docker, while this one is released?
That would be super helpful. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants