Upgrade kubernetes dashboard from v2.3.1 to v2.5.1 #13741

ziyi-xie · 2022-03-02T08:15:39Z

Kubernetes dashboard has been upgraded to v2.5.1 now, and this PR fixed the version of dashboard to v2.5.1 in minikube.
https://github.com/kubernetes/dashboard/releases

k8s-ci-robot · 2022-03-02T08:15:46Z

Welcome @ziyi-xie!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-03-02T08:15:47Z

Hi @ziyi-xie. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ziyi-xie · 2022-03-02T08:21:01Z

pkg/minikube/assets/addons.go

@@ -134,7 +134,7 @@ var Addons = map[string]*Addon{
 		MustBinAsset(addons.DashboardAssets, "dashboard/dashboard-secret.yaml", vmpath.GuestAddonsDir, "dashboard-secret.yaml", "0640"),
 		MustBinAsset(addons.DashboardAssets, "dashboard/dashboard-svc.yaml", vmpath.GuestAddonsDir, "dashboard-svc.yaml", "0640"),
 	}, false, "dashboard", "kubernetes", map[string]string{
-		"Dashboard":      "kubernetesui/dashboard:v2.3.1@sha256:ec27f462cf1946220f5a9ace416a84a57c18f98c777876a8054405d1428cc92e",
+		"Dashboard":      "kubernetesui/dashboard:v2.5.0@sha256:ec27f462cf1946220f5a9ace416a84a57c18f98c777876a8054405d1428cc92e",


Hi! I think I have to change the hash here, but the hash for v2.3.1 is different from the one I checked on dockerhub. Could you tell me where can I find it?

You can get the digest(kubernetesui/dashboard:v2.3.1@sha256:ec27f462cf1946220f5a9ace416a84a57c18f98c777876a8054405d1428cc92e) by docker inspect kubernetesui/dashboard:v2.3.1 --format='{{index .RepoDigests}}'.
Note that you need to pull the image(kubernetesui/dashboard:v2.3.1) to local, in advance.

Thank you so much for your help!!

minikube-bot · 2022-03-02T08:21:05Z

Can one of the admins verify this patch?

ziyi-xie · 2022-03-02T08:22:17Z

/hold

…e/assets/addons.go

ziyi-xie · 2022-03-03T08:17:24Z

/hold cancel

atoato88 · 2022-03-04T02:02:07Z

Could you add some contexts of this PR on description?

What this PR does / why we need it
Which issue(s) this PR fixes (if exists)

t-inu · 2022-03-04T02:31:10Z

pkg/minikube/cruntime/containerd_test.go

@@ -27,7 +27,7 @@ func TestAddRepoTagToImageName(t *testing.T) {
 		imgName string
 		want    string
 	}{
-		{"kubernetesui/dashboard:v2.1.0", "docker.io/kubernetesui/dashboard:v2.1.0"},
+		{"kubernetesui/dashboard:v2.5.0", "docker.io/kubernetesui/dashboard:v2.5.0"},
 		{"kubernetesui/metrics-scraper:v1.0.4", "docker.io/kubernetesui/metrics-scraper:v1.0.4"},


In the previous upgrade, this file has not been updated, so metrics-scraper is not the latest version.
I think it's better to update from v1.0.4 to v1.0.7.

It was corrected and thank you so much for letting me know!

…ainerd_test.go file

medyagh · 2022-03-04T19:37:04Z

/ok-to-test

minikube-pr-bot · 2022-03-04T20:31:42Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13741) |
+----------------+----------+---------------------+
| minikube start | 54.0s    | 63.7s               |
| enable ingress | 29.5s    | 29.3s               |
+----------------+----------+---------------------+

Times for minikube start: 54.6s 52.7s 52.1s 55.2s 55.3s
Times for minikube (PR 13741) start: 63.3s 63.3s 65.6s 62.3s 64.0s

Times for minikube (PR 13741) ingress: 29.6s 29.5s 29.6s 29.5s 28.5s
Times for minikube ingress: 29.0s 30.0s 29.6s 29.6s 29.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13741) |
+----------------+----------+---------------------+
| minikube start | 26.4s    | 36.7s               |
| enable ingress | 22.4s    | 23.2s               |
+----------------+----------+---------------------+

Times for minikube start: 29.6s 25.6s 25.2s 25.4s 26.1s
Times for minikube (PR 13741) start: 35.8s 36.8s 37.2s 36.7s 37.3s

Times for minikube ingress: 22.9s 20.9s 21.9s 22.9s 23.4s
Times for minikube (PR 13741) ingress: 26.0s 22.9s 22.9s 21.9s 22.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13741) |
+----------------+----------+---------------------+
| minikube start | 41.5s    | 69.4s               |
| enable ingress | 24.8s    | 24.6s               |
+----------------+----------+---------------------+

Times for minikube start: 34.4s 45.8s 40.7s 41.4s 45.4s
Times for minikube (PR 13741) start: 71.2s 69.8s 69.8s 69.6s 66.6s

Times for minikube ingress: 18.9s 19.4s 33.4s 33.4s 18.9s
Times for minikube (PR 13741) ingress: 22.9s 18.9s 33.9s 23.9s 23.4s

minikube-pr-bot · 2022-03-04T22:29:37Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Hyperkit_macOS	TestErrorSpam/setup (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/ValidateNameConflict (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestErrorSpam/setup (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestFunctional/parallel/MountCmd/any-port (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestFunctional/parallel/MySQL (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestFunctional/parallel/NodeLabels (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestFunctional/parallel/ServiceCmd (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestFunctional/parallel/StatusCmd (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestFunctional/serial/ComponentHealth (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestFunctional/serial/ExtraConfig (gopogh)	0.00 (chart)
KVM_Linux	TestErrorSpam/setup (gopogh)	0.62 (chart)
Docker_macOS	TestDownloadOnly/v1.23.4-rc.0/preload-exists (gopogh)	0.70 (chart)
KVM_Linux_containerd	TestFunctional/serial/LogsFileCmd (gopogh)	1.25 (chart)
Docker_Linux	TestNoKubernetes/serial/StartNoArgs (gopogh)	2.80 (chart)
KVM_Linux_containerd	TestFunctional/parallel/DashboardCmd (gopogh)	3.12 (chart)
Docker_macOS	TestJSONOutput/pause/Command (gopogh)	4.20 (chart)
Docker_Linux_containerd	TestPause/serial/Pause (gopogh)	9.17 (chart)
Docker_macOS	TestDownloadOnlyKic (gopogh)	9.79 (chart)
Docker_macOS	TestDownloadOnly/v1.23.3/preload-exists (gopogh)	9.79 (chart)
Hyper-V_Windows	TestErrorSpam/setup (gopogh)	13.57 (chart)
Hyperkit_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	15.03 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/flannel/Start (gopogh)	25.71 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	32.86 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	35.96 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	35.96 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	35.96 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	37.07 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/DeployApp (gopogh)	37.72 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/FirstStart (gopogh)	37.72 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

ziyi-xie · 2022-03-07T07:36:00Z

@medyagh Hi! Thank you for running the test for me! And I noticed that there are several tests failed and I don't have any clue about the reason. Could you tell me what I can do to fix it? Looking forward to hearing from you and many thanks. :)

shu-mutou · 2022-03-11T01:15:57Z

@ziyi-xie Dashboard 2.5.1 was released last night. Could you bump to it?

klaases

Do you want to bump to v2.5.1?

ziyi-xie · 2022-03-16T00:47:17Z

@ziyi-xie Dashboard 2.5.1 was released last night. Could you bump to it?

@shu-mutou It was corrected and thank you so much for letting me know!

ziyi-xie · 2022-03-16T01:02:41Z

Do you want to bump to v2.5.1?

@klaases I've just bumped it to v2.5.1 and could you check if everything looks OK please? Thank you.

minikube-pr-bot · 2022-03-16T01:29:17Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13741) |
+----------------+----------+---------------------+
| minikube start | 53.1s    | 63.1s               |
| enable ingress | 28.8s    | 29.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 29.1s 28.5s 29.0s 29.0s 28.6s
Times for minikube (PR 13741) ingress: 29.0s 29.0s 30.6s 28.6s 29.5s

Times for minikube start: 54.9s 52.7s 52.4s 53.1s 52.3s
Times for minikube (PR 13741) start: 65.1s 61.9s 62.8s 63.0s 62.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13741) |
+----------------+----------+---------------------+
| minikube start | 26.8s    | 36.1s               |
| enable ingress | 22.0s    | 22.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 21.9s 21.5s 21.9s 22.4s 22.4s
Times for minikube (PR 13741) ingress: 20.4s 21.9s 25.0s 23.5s 22.9s

Times for minikube start: 29.1s 27.2s 25.3s 26.0s 26.6s
Times for minikube (PR 13741) start: 35.9s 36.9s 35.6s 36.1s 35.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13741) |
+----------------+----------+---------------------+
| minikube start | 40.6s    | 66.5s               |
| enable ingress | 25.7s    | 24.5s               |
+----------------+----------+---------------------+

Times for minikube start: 31.1s 40.5s 40.4s 45.8s 45.2s
Times for minikube (PR 13741) start: 67.8s 66.1s 68.9s 65.2s 64.5s

Times for minikube ingress: 32.9s 33.4s 23.4s 18.9s 19.9s
Times for minikube (PR 13741) ingress: 23.4s 22.9s 29.9s 22.9s 23.4s

minikube-pr-bot · 2022-03-16T03:53:47Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Cloud_Shell	TestFunctional/parallel/DashboardCmd (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh)	0.00 (chart)
Docker_Linux	TestNoKubernetes/serial/StartWithStopK8s (gopogh)	0.00 (chart)
Hyperkit_macOS	TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh)	0.00 (chart)
Hyperkit_macOS	TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh)	0.00 (chart)
Hyperkit_macOS	TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh)	0.00 (chart)
Hyperkit_macOS	TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh)	0.00 (chart)
Hyperkit_macOS	TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh)	0.00 (chart)
Hyperkit_macOS	TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh)	0.00 (chart)
Hyperkit_macOS	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	0.00 (chart)
Hyperkit_macOS	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	0.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/ValidateNameConflict (gopogh)	0.00 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/auto/Start (gopogh)	0.00 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/kindnet/Start (gopogh)	0.00 (chart)
Hyper-V_Windows	TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh)	0.00 (chart)
Hyper-V_Windows	TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh)	0.00 (chart)
Hyper-V_Windows	TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh)	0.00 (chart)
Hyper-V_Windows	TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh)	0.00 (chart)
Hyper-V_Windows	TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh)	0.00 (chart)
Hyper-V_Windows	TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh)	0.00 (chart)
Hyper-V_Windows	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestErrorSpam/setup (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestFunctional/parallel/DashboardCmd (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh)	0.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

shu-mutou · 2022-03-16T06:43:49Z

pkg/minikube/assets/addons.go

@@ -134,7 +134,7 @@ var Addons = map[string]*Addon{
 		MustBinAsset(addons.DashboardAssets, "dashboard/dashboard-secret.yaml", vmpath.GuestAddonsDir, "dashboard-secret.yaml", "0640"),
 		MustBinAsset(addons.DashboardAssets, "dashboard/dashboard-svc.yaml", vmpath.GuestAddonsDir, "dashboard-svc.yaml", "0640"),
 	}, false, "dashboard", "kubernetes", map[string]string{
-		"Dashboard":      "kubernetesui/dashboard:v2.3.1@sha256:ec27f462cf1946220f5a9ace416a84a57c18f98c777876a8054405d1428cc92e",
+		"Dashboard":      "kubernetesui/dashboard:v2.5.1@sha256:cc746e7a0b1eec0db01cbabbb6386b23d7af97e79fa9e36bb883a95b7eb96fe2]",


Thanks for bump to 2.5.1!
But the ] at the last of hash is not needed. Please remove it.

I've just corrected it and thank you so much!

minikube-pr-bot · 2022-03-16T09:39:36Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13741) |
+----------------+----------+---------------------+
| minikube start | 52.9s    | 62.9s               |
| enable ingress | 38.3s    | 28.6s               |
+----------------+----------+---------------------+

Times for minikube start: 54.3s 53.0s 51.9s 52.7s 52.5s
Times for minikube (PR 13741) start: 63.4s 62.5s 63.9s 62.4s 62.4s

Times for minikube (PR 13741) ingress: 25.0s 29.1s 30.5s 29.5s 29.1s
Times for minikube ingress: 26.1s 29.0s 25.5s 25.0s 86.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13741) |
+----------------+----------+---------------------+
| minikube start | 26.1s    | 36.3s               |
| enable ingress | 23.0s    | 22.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 13741) start: 36.7s 35.8s 36.6s 35.6s 36.6s
Times for minikube start: 26.5s 25.1s 26.4s 27.7s 24.9s

Times for minikube ingress: 22.9s 22.9s 22.9s 23.0s 23.4s
Times for minikube (PR 13741) ingress: 22.9s 22.0s 22.9s 22.9s 23.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13741) |
+----------------+----------+---------------------+
| minikube start | 40.2s    | 71.4s               |
| enable ingress | 21.6s    | 36.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 13741) start: 74.3s 67.2s 73.7s 73.0s 68.7s
Times for minikube start: 30.1s 40.7s 44.6s 40.4s 45.4s

Times for minikube ingress: 23.4s 23.4s 19.0s 22.9s 19.4s
Times for minikube (PR 13741) ingress: 22.9s 24.4s 22.9s 54.4s 58.4s

minikube-pr-bot · 2022-03-16T12:06:34Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/Pause (gopogh)	0.00 (chart)
Docker_macOS	TestDownloadOnly/v1.23.4-rc.0/preload-exists (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestErrorSpam/setup (gopogh)	0.00 (chart)
Hyperkit_macOS	TestErrorSpam/setup (gopogh)	0.65 (chart)
KVM_Linux	TestErrorSpam/setup (gopogh)	1.26 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/Pause (gopogh)	1.37 (chart)
Docker_Linux	TestNoKubernetes/serial/Start (gopogh)	1.95 (chart)
Docker_Linux_containerd	TestPause/serial/Pause (gopogh)	2.42 (chart)
Docker_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	3.88 (chart)
Docker_Linux	TestStartStop/group/embed-certs/serial/Pause (gopogh)	4.55 (chart)
Docker_macOS	TestJSONOutput/pause/Command (gopogh)	6.34 (chart)
Docker_macOS	TestDownloadOnlyKic (gopogh)	10.56 (chart)
Docker_macOS	TestDownloadOnly/v1.23.3/preload-exists (gopogh)	10.56 (chart)
Docker_macOS	TestNoKubernetes/serial/StartNoArgs (gopogh)	11.36 (chart)
Hyper-V_Windows	TestErrorSpam/setup (gopogh)	12.50 (chart)
Docker_Windows	TestNetworkPlugins/group/false/Start (gopogh)	23.68 (chart)
Docker_Windows	TestPause/serial/Pause (gopogh)	24.21 (chart)
Docker_macOS	TestStartStop/group/newest-cni/serial/FirstStart (gopogh)	29.51 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	37.50 (chart)
Docker_macOS	TestFunctional/serial/ComponentHealth (gopogh)	43.66 (chart)
Docker_macOS	TestFunctional/serial/ExtraConfig (gopogh)	43.66 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/kindnet/Start (gopogh)	45.83 (chart)
Docker_Linux	TestNetworkPlugins/group/custom-weave/Start (gopogh)	62.34 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	72.79 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	75.40 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/calico/Start (gopogh)	78.33 (chart)
Docker_Linux	TestNetworkPlugins/group/calico/Start (gopogh)	79.22 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/bridge/DNS (gopogh)	80.99 (chart)
Docker_Windows	TestAddons/parallel/MetricsServer (gopogh)	86.41 (chart)
Docker_macOS	TestDownloadOnly/v1.16.0/preload-exists (gopogh)	100.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

ziyi-xie · 2022-03-24T04:25:15Z

/assign @medyagh

ziyi-xie · 2022-03-24T04:34:35Z

/assign @blueelvis

ziyi-xie · 2022-04-04T08:33:36Z

@spowelljr Hi! Sorry for the sudden message. Would it be possible for you to check if everything is ok with this PR for me please? Many thanks.

spowelljr · 2022-04-04T17:34:16Z

pkg/minikube/bootstrapper/images/kubeadm_test.go

@@ -103,7 +103,7 @@ func TestKubeadmImages(t *testing.T) {
 			"k8s.gcr.io/etcd:3.2.24",
 			"k8s.gcr.io/pause:3.1",
 			"gcr.io/k8s-minikube/storage-provisioner:" + version.GetStorageProvisionerVersion(),
-			"docker.io/kubernetesui/dashboard:v2.3.1",
+			"docker.io/kubernetesui/dashboard:v2.5.1",


Doesn't have to happen in this PR, but we should make the dashboard, metrics-scraper, and pause strings into consts as they're independent of the Kubernetes version, and bumping the version of one of those three requires changing the version for every test case.

Noted with many thanks.

k8s-ci-robot · 2022-04-04T17:50:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klaases, spowelljr, ziyi-xie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jesperpedersen · 2022-04-05T10:22:37Z

This gives

❌  Unable to load cached images: loading cached images: stat /home/demo/.minikube/cache/images/amd64/docker.io/kubernetesui/dashboard_v2.5.1: no such file or directory

To see this:

minikube delete
minikube start

ziyi-xie · 2022-04-06T04:12:36Z

This gives

❌  Unable to load cached images: loading cached images: stat /home/demo/.minikube/cache/images/amd64/docker.io/kubernetesui/dashboard_v2.5.1: no such file or directory

To see this:

minikube delete
minikube start

Thank you for letting me know! But I didn't encounter such situation.
Is there any possibility that all the caches are cleared during the update, and will it be fixed if pull the image from dockerhub again before start the minikube?

jesperpedersen · 2022-04-06T11:31:08Z

@ziyi-xie Fixed in #13911

upgrade kubernetes dashboard from v2.3.1 to v2.5.0

771d719

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 2, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 2, 2022

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 2, 2022

k8s-ci-robot requested review from blueelvis and klaases March 2, 2022 08:15

ziyi-xie commented Mar 2, 2022

View reviewed changes

ziyi-xie changed the title ~~[DNM] Upgrade kubernetes dashboard from v2.3.1 to v2.5.0~~ Upgrade kubernetes dashboard from v2.3.1 to v2.5.0 Mar 2, 2022

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2022

modified the hash for kubernetes dashboard v2.5.0 in file pkg/minikub…

ff9c3fe

…e/assets/addons.go

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2022

t-inu reviewed Mar 4, 2022

View reviewed changes

modified the version of metrics-scraper in pkg/minikube/cruntime/cont…

e74ce6e

…ainerd_test.go file

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2022

klaases approved these changes Mar 15, 2022

View reviewed changes

upgrade kubernetes dashboard from v2.5.0 to v2.5.1

b9fcc58

ziyi-xie changed the title ~~Upgrade kubernetes dashboard from v2.3.1 to v2.5.0~~ Upgrade kubernetes dashboard from v2.3.1 to v2.5.1 Mar 16, 2022

shu-mutou reviewed Mar 16, 2022

View reviewed changes

modify the typo in pkg/minikube/assets/addons.go file

8542f7d

k8s-ci-robot assigned medyagh Mar 24, 2022

k8s-ci-robot assigned blueelvis Mar 24, 2022

spowelljr unassigned medyagh and blueelvis Apr 4, 2022

spowelljr reviewed Apr 4, 2022

View reviewed changes

spowelljr approved these changes Apr 4, 2022

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2022

spowelljr merged commit 69417f0 into kubernetes:master Apr 4, 2022

ziyi-xie mentioned this pull request May 31, 2022

REQUEST: New membership for ziyi-xie kubernetes/org#3459

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade kubernetes dashboard from v2.3.1 to v2.5.1 #13741

Upgrade kubernetes dashboard from v2.3.1 to v2.5.1 #13741

ziyi-xie commented Mar 2, 2022 •

edited

Loading

k8s-ci-robot commented Mar 2, 2022

k8s-ci-robot commented Mar 2, 2022

ziyi-xie Mar 2, 2022

atoato88 Mar 3, 2022

ziyi-xie Mar 3, 2022

minikube-bot commented Mar 2, 2022

ziyi-xie commented Mar 2, 2022

ziyi-xie commented Mar 3, 2022

atoato88 commented Mar 4, 2022

t-inu Mar 4, 2022

ziyi-xie Mar 4, 2022

medyagh commented Mar 4, 2022

minikube-pr-bot commented Mar 4, 2022

minikube-pr-bot commented Mar 4, 2022

ziyi-xie commented Mar 7, 2022

shu-mutou commented Mar 11, 2022 •

edited

Loading

klaases left a comment

ziyi-xie commented Mar 16, 2022 •

edited

Loading

ziyi-xie commented Mar 16, 2022

minikube-pr-bot commented Mar 16, 2022

minikube-pr-bot commented Mar 16, 2022

shu-mutou Mar 16, 2022 •

edited

Loading

ziyi-xie Mar 16, 2022

minikube-pr-bot commented Mar 16, 2022

minikube-pr-bot commented Mar 16, 2022

ziyi-xie commented Mar 24, 2022 •

edited

Loading

ziyi-xie commented Mar 24, 2022

ziyi-xie commented Apr 4, 2022

spowelljr Apr 4, 2022

ziyi-xie Apr 4, 2022

k8s-ci-robot commented Apr 4, 2022

jesperpedersen commented Apr 5, 2022

ziyi-xie commented Apr 6, 2022

jesperpedersen commented Apr 6, 2022

Upgrade kubernetes dashboard from v2.3.1 to v2.5.1 #13741

Upgrade kubernetes dashboard from v2.3.1 to v2.5.1 #13741

Conversation

ziyi-xie commented Mar 2, 2022 • edited Loading

k8s-ci-robot commented Mar 2, 2022

k8s-ci-robot commented Mar 2, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

minikube-bot commented Mar 2, 2022

ziyi-xie commented Mar 2, 2022

ziyi-xie commented Mar 3, 2022

atoato88 commented Mar 4, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

medyagh commented Mar 4, 2022

minikube-pr-bot commented Mar 4, 2022

minikube-pr-bot commented Mar 4, 2022

ziyi-xie commented Mar 7, 2022

shu-mutou commented Mar 11, 2022 • edited Loading

klaases left a comment

Choose a reason for hiding this comment

ziyi-xie commented Mar 16, 2022 • edited Loading

ziyi-xie commented Mar 16, 2022

minikube-pr-bot commented Mar 16, 2022

minikube-pr-bot commented Mar 16, 2022

shu-mutou Mar 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

minikube-pr-bot commented Mar 16, 2022

minikube-pr-bot commented Mar 16, 2022

ziyi-xie commented Mar 24, 2022 • edited Loading

ziyi-xie commented Mar 24, 2022

ziyi-xie commented Apr 4, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 4, 2022

jesperpedersen commented Apr 5, 2022

ziyi-xie commented Apr 6, 2022

jesperpedersen commented Apr 6, 2022

ziyi-xie commented Mar 2, 2022 •

edited

Loading

shu-mutou commented Mar 11, 2022 •

edited

Loading

ziyi-xie commented Mar 16, 2022 •

edited

Loading

shu-mutou Mar 16, 2022 •

edited

Loading

ziyi-xie commented Mar 24, 2022 •

edited

Loading