Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trying to pause multiple containers with runc #13783

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Fix trying to pause multiple containers with runc #13783

merged 1 commit into from
Mar 15, 2022

Conversation

spowelljr
Copy link
Member

Fixes #12284

Problem:
runc only supports pausing one container at a time. The container IDs were being looped over properly, but was appending to the previous command causing multiple container IDs being provided.

Before:

// assuming container IDs 123, 456, 789
sudo runc --root /run/containerd/runc/k8s.io pause 123
sudo runc --root /run/containerd/runc/k8s.io pause 123 456
sudo runc --root /run/containerd/runc/k8s.io pause 123 456 789

After:

// assuming container IDs 123, 456, 789
sudo runc --root /run/containerd/runc/k8s.io pause 123
sudo runc --root /run/containerd/runc/k8s.io pause 456
sudo runc --root /run/containerd/runc/k8s.io pause 789

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2022
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 14, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13783) |
+----------------+----------+---------------------+
| minikube start | 52.5s    | 52.1s               |
| enable ingress | 28.1s    | 27.8s               |
+----------------+----------+---------------------+

Times for minikube start: 53.5s 52.1s 52.8s 52.0s 52.1s
Times for minikube (PR 13783) start: 52.1s 51.2s 52.3s 52.2s 52.6s

Times for minikube ingress: 30.0s 26.6s 29.1s 29.5s 25.5s
Times for minikube (PR 13783) ingress: 29.0s 26.6s 25.5s 29.5s 28.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13783) |
+----------------+----------+---------------------+
| minikube start | 26.2s    | 25.8s               |
| enable ingress | 21.5s    | 23.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 13783) start: 24.7s 26.3s 26.8s 25.5s 25.9s
Times for minikube start: 27.2s 26.5s 26.5s 25.8s 24.9s

Times for minikube ingress: 21.9s 21.5s 21.4s 21.9s 20.9s
Times for minikube (PR 13783) ingress: 22.9s 22.9s 22.9s 21.9s 27.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13783) |
+----------------+----------+---------------------+
| minikube start | 41.5s    | 42.1s               |
| enable ingress | 23.1s    | 22.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 13783) start: 40.9s 41.6s 41.1s 45.3s 41.5s
Times for minikube start: 33.5s 41.8s 40.9s 45.2s 46.2s

Times for minikube ingress: 19.9s 23.4s 23.4s 29.9s 18.9s
Times for minikube (PR 13783) ingress: 23.4s 23.4s 22.9s 19.9s 22.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestStartStop/group/embed-certs/serial/Pause (gopogh) 3.16 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/cilium/Start (gopogh) 4.07 (chart)
Docker_Linux TestNetworkPlugins/group/auto/DNS (gopogh) 6.96 (chart)
Hyperkit_macOS TestFunctional/serial/ComponentHealth (gopogh) 7.59 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 8.05 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 8.05 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 8.05 (chart)
Docker_Linux_containerd TestNoKubernetes/serial/StartNoArgs (gopogh) 8.27 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 9.09 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/auto/Start (gopogh) 11.38 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 12.21 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 12.21 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 12.21 (chart)
Docker_Linux_containerd TestAddons/parallel/Registry (gopogh) 12.50 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 14.50 (chart)
KVM_Linux_containerd TestPause/serial/SecondStartNoReconfiguration (gopogh) 14.55 (chart)
Docker_Windows TestRunningBinaryUpgrade (gopogh) 17.43 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 21.52 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 22.90 (chart)
Docker_Linux_containerd TestOffline (gopogh) 24.68 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmdConnect (gopogh) 25.93 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 26.44 (chart)
Docker_macOS TestStartStop/group/newest-cni/serial/Pause (gopogh) 26.67 (chart)
Docker_macOS TestStartStop/group/no-preload/serial/FirstStart (gopogh) 26.67 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 27.85 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 27.87 (chart)
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 29.11 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 29.11 (chart)
Docker_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 29.11 (chart)
Docker_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 29.11 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

klaases
klaases approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@klaases klaases left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klaases, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 8103a86 into kubernetes:master Mar 15, 2022
@spowelljr spowelljr deleted the fixPauseTEst branch March 15, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaases klaases klaases approved these changes

@medyagh medyagh Awaiting requested review from medyagh

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestPause/serial/Pause failing
4 participants
@spowelljr @minikube-pr-bot @k8s-ci-robot @klaases