-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade buildkit from 0.9.0 to 0.10.0 #13791
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @afbjorklund!
ok-to-build-image |
ok-to-build-iso |
Hi @afbjorklund, building a new ISO failed. |
Hi @afbjorklund, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further. |
5e33cf6
to
572f52a
Compare
572f52a
to
db455fc
Compare
ok-to-build-iso |
Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
/ok-to-test |
ok-to-build-image |
kvm2 driver with docker runtime
Times for minikube (PR 13791) start: 52.4s 52.8s 52.4s 53.2s 52.2s Times for minikube ingress: 25.1s 28.6s 29.0s 28.5s 29.1s docker driver with docker runtime
Times for minikube start: 30.4s 27.1s 25.9s 25.4s 26.3s Times for minikube ingress: 27.9s 22.4s 23.4s 21.9s 21.9s docker driver with containerd runtime
Times for minikube start: 34.0s 42.2s 41.2s 41.6s 45.8s Times for minikube (PR 13791) ingress: 21.5s 21.4s 21.5s 21.5s 17.9s |
Hi @afbjorklund, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further. |
kvm2 driver with docker runtime
Times for minikube start: 55.0s 53.4s 53.2s 53.9s 52.9s Times for minikube ingress: 30.1s 26.6s 28.7s 27.6s 30.2s docker driver with docker runtime
Times for minikube start: 32.0s 27.4s 26.4s 26.1s 27.5s Times for minikube ingress: 22.4s 24.0s 23.0s 21.9s 23.1s docker driver with containerd runtime
Times for minikube start: 35.7s 47.1s 46.6s 44.0s 46.5s Times for minikube (PR 13791) ingress: 22.4s 28.0s 18.0s 22.0s 18.0s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
kvm2 driver with docker runtime
Times for minikube start: 50.9s 51.3s 50.5s 50.1s 50.8s Times for minikube ingress: 30.1s 29.7s 30.0s 29.1s 29.6s docker driver with docker runtime |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
308a723
to
7c1b415
Compare
ok-to-build-image |
ok-to-build-iso |
kvm2 driver with docker runtime
Times for minikube start: 53.9s 52.7s 52.7s 51.8s 52.1s Times for minikube ingress: 29.7s 29.7s 29.1s 30.1s 29.1s docker driver with docker runtime
Times for minikube start: 26.3s 25.1s 25.1s 25.3s 24.6s Times for minikube (PR 13791) ingress: 21.9s 27.9s 20.9s 21.9s 23.5s docker driver with containerd runtime
Times for minikube ingress: 18.9s 32.5s 18.9s 18.9s 22.4s Times for minikube start: 33.4s 28.8s 33.4s 43.8s 29.7s |
Hi @afbjorklund, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further. |
Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
kvm2 driver with docker runtime
Times for minikube start: 51.9s 49.3s 50.5s 51.4s 50.7s Times for minikube ingress: 29.6s 26.0s 30.6s 29.6s 30.1s docker driver with docker runtime
Times for minikube start: 25.1s 24.0s 24.2s 24.8s 25.0s Times for minikube ingress: 22.4s 22.4s 23.9s 22.9s 21.9s docker driver with containerd runtime
Times for minikube start: 35.0s 32.9s 31.4s 39.6s 32.5s Times for minikube ingress: 18.9s 17.9s 28.9s 32.4s 19.0s |
kvm2 driver with docker runtime
Times for minikube ingress: 28.5s 29.1s 30.0s 29.1s 30.5s Times for minikube start: 54.7s 51.3s 54.5s 50.4s 51.2s docker driver with docker runtime
Times for minikube start: 29.2s 24.5s 25.4s 24.2s 24.7s Times for minikube ingress: 24.4s 22.4s 23.4s 22.4s 22.9s docker driver with containerd runtime
Times for minikube start: 33.7s 28.9s 31.7s 28.6s 28.7s Times for minikube (PR 13791) ingress: 22.4s 26.4s 22.0s 22.5s 28.9s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, klaases, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.