Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO: Upgrade buildroot minor version #13814

Merged
merged 8 commits into from
May 3, 2022

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Mar 20, 2022

From

2021.02.4 (August 10th, 2021)

To

2021.02.12 (April 6th, 2022)


https://git.busybox.net/buildroot/plain/CHANGES?id=2021.02.12

https://cdn.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.19.235

EDIT: Bump from 2021.02.10 to 2021.02.12, the final release (EOL)

Will upgrade to 2022.02.x, when we bump KIC to Ubuntu 22.04 LTS

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2022
@afbjorklund
Copy link
Collaborator Author

ok-to-build-iso

@afbjorklund afbjorklund changed the title Upgrade buildroot minor version ISO: Upgrade buildroot minor version Mar 20, 2022
@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2022
@afbjorklund
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 20, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime
error collecting results for kvm2 driver: timing run 0 with minikube: timing cmd: [out/minikube start --driver=kvm2 --container-runtime=docker]: waiting for minikube: exit status 80
docker driver with docker runtime
error downloading artifacts: downloading artifacts: exit status 81docker driver with containerd runtime
error downloading artifacts: downloading artifacts: exit status 81

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestAddons/Setup (gopogh) 0.59 (chart)
KVM_Linux_containerd TestCertExpiration (gopogh) 0.59 (chart)
KVM_Linux_containerd TestCertOptions (gopogh) 0.59 (chart)
KVM_Linux_containerd TestErrorSpam/setup (gopogh) 0.59 (chart)
KVM_Linux_containerd TestForceSystemdEnv (gopogh) 0.59 (chart)
KVM_Linux_containerd TestForceSystemdFlag (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/CertSync (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/CpCmd (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/FileSync (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/NodeLabels (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/SSHCmd (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/StatusCmd (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/UpdateContextCmd/no_changes (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh) 0.59 (chart)
KVM_Linux_containerd TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh) 0.59 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh
Copy link
Member

medyagh commented Mar 23, 2022

the test look not good

@klaases
Copy link
Contributor

klaases commented Mar 23, 2022

/retest-this-please

@spowelljr
Copy link
Member

the test look not good

That's likely just the KVM linux machine, we deleted that machine and created a new one, the retest should show the true result

@spowelljr
Copy link
Member

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime
error collecting results for kvm2 driver: timing run 0 with minikube (PR 13814): timing cmd: [/home/jenkins/.minikube/minikube-binaries/13814/minikube start --driver=kvm2 --container-runtime=docker]: waiting for minikube: exit status 52
docker driver with docker runtime
error downloading artifacts: downloading artifacts: exit status 81docker driver with containerd runtime
error downloading artifacts: downloading artifacts: exit status 81

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestFunctional/parallel (gopogh) n/a
KVM_Linux_containerd TestIngressAddonLegacy/serial (gopogh) n/a
KVM_Linux_containerd TestAddons/Setup (gopogh) 0.56 (chart)
KVM_Linux_containerd TestErrorSpam/setup (gopogh) 0.56 (chart)
KVM_Linux_containerd TestFunctional/serial/AuditLog (gopogh) 0.56 (chart)
KVM_Linux_containerd TestFunctional/serial/CacheCmd/cache/cache_reload (gopogh) 0.56 (chart)
KVM_Linux_containerd TestFunctional/serial/CacheCmd/cache/verify_cache_inside_node (gopogh) 0.56 (chart)
KVM_Linux_containerd TestFunctional/serial/ExtraConfig (gopogh) 0.56 (chart)
KVM_Linux_containerd TestFunctional/serial/KubeContext (gopogh) 0.56 (chart)
KVM_Linux_containerd TestFunctional/serial/KubectlGetPods (gopogh) 0.56 (chart)
KVM_Linux_containerd TestFunctional/serial/MinikubeKubectlCmd (gopogh) 0.56 (chart)
KVM_Linux_containerd TestFunctional/serial/MinikubeKubectlCmdDirectly (gopogh) 0.56 (chart)
KVM_Linux_containerd TestFunctional/serial/SoftStart (gopogh) 0.56 (chart)
KVM_Linux_containerd TestFunctional/serial/StartWithProxy (gopogh) 0.56 (chart)
KVM_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 0.56 (chart)
KVM_Linux_containerd TestJSONOutput/pause/Audit (gopogh) 0.56 (chart)
KVM_Linux_containerd TestJSONOutput/pause/Command (gopogh) 0.56 (chart)
KVM_Linux_containerd TestJSONOutput/start/Audit (gopogh) 0.56 (chart)
KVM_Linux_containerd TestJSONOutput/start/Command (gopogh) 0.56 (chart)
KVM_Linux_containerd TestJSONOutput/start/parallel/DistinctCurrentSteps (gopogh) 0.56 (chart)
KVM_Linux_containerd TestJSONOutput/start/parallel/IncreasingCurrentSteps (gopogh) 0.56 (chart)
KVM_Linux_containerd TestJSONOutput/unpause/Audit (gopogh) 0.56 (chart)
KVM_Linux_containerd TestJSONOutput/unpause/Command (gopogh) 0.56 (chart)
KVM_Linux_containerd TestMountStart/serial/StartWithMountFirst (gopogh) 0.56 (chart)
KVM_Linux_containerd TestMultiNode/serial/RestartKeepsNodes (gopogh) 0.56 (chart)
Docker_Linux TestForceSystemdFlag (gopogh) 0.61 (chart)
Docker_Linux_containerd TestKubernetesUpgrade (gopogh) 4.12 (chart)
Docker_Linux TestPause/serial/Pause (gopogh) 10.91 (chart)
Docker_Windows TestSkaffold (gopogh) 21.09 (chart)
Docker_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 29.60 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 29, 2022
@spowelljr
Copy link
Member

ok-to-build-iso

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 29, 2022
@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2022
@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/13814/6e89be2/iso_build.txt

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDownloadOnly/v1.23.6-rc.0/preload-exists (gopogh) 1.68 (chart)
Docker_Linux TestNoKubernetes/serial/Start (gopogh) 3.80 (chart)
Hyper-V_Windows TestNetworkPlugins/group/cilium/Start (gopogh) 8.51 (chart)
Docker_macOS TestDownloadOnlyKic (gopogh) 8.92 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 8.97 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/auto/Start (gopogh) 9.92 (chart)
Docker_macOS TestDownloadOnly/v1.23.5/preload-exists (gopogh) 10.08 (chart)
KVM_Linux_containerd TestPause/serial/SecondStartNoReconfiguration (gopogh) 12.14 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/AddonExistsAfterStop (gopogh) 12.50 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/EnableAddonAfterStop (gopogh) 13.58 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/Stop (gopogh) 13.58 (chart)
Docker_macOS TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 14.10 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 14.10 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/UserAppExistsAfterStop (gopogh) 14.11 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/SecondStart (gopogh) 14.63 (chart)
Docker_macOS TestPause/serial/Start (gopogh) 16.03 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithK8s (gopogh) 16.77 (chart)
Docker_macOS TestNoKubernetes/serial/ProfileList (gopogh) 17.12 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 17.12 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 17.12 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 18.79 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 19.48 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 19.55 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 19.55 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 19.55 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 20.30 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/DeployApp (gopogh) 29.92 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 30.08 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/FirstStart (gopogh) 30.47 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/SecondStart (gopogh) 30.71 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@jepio
Copy link

jepio commented Apr 9, 2022

Sigh, now the ISO build is totally broken.

The log says this about building containerd:

ERROR: v1.5.11.tar.gz has wrong sha256 hash:
ERROR: expected: 6a289406c1c0583763e5a9754e31a1eced55cd5f162a7bc2a3a315d5eb05c7a1
ERROR: got : 02b79d5e2b07b5e64cd28f1fe84395ee11eef95fc49fd923a9ab93022b148be6

And I just saw that you already reported this issue before containerd/containerd#6387
So either 2021.02.11 builds or we need to file a patch against buildroot to fix the checksum.

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Apr 10, 2022

That's not buildroot, it's a known issue with a k8s component

diff -ur containerd-1.5.11.orig/vendor/k8s.io/client-go/pkg/version/base.go containerd-1.5.11/vendor/k8s.io/client-go/pkg/version/base.go
--- containerd-1.5.11.orig/vendor/k8s.io/client-go/pkg/version/base.go	2022-03-24 01:09:42.000000000 +0100
+++ containerd-1.5.11/vendor/k8s.io/client-go/pkg/version/base.go	2022-03-24 01:09:42.000000000 +0100
@@ -55,7 +55,7 @@
 	// NOTE: The $Format strings are replaced during 'git archive' thanks to the
 	// companion .gitattributes file containing 'export-subst' in this same
 	// directory.  See also https://git-scm.com/docs/gitattributes
-	gitVersion   string = "v0.0.0-master+3df54a8523"
+	gitVersion   string = "v0.0.0-master+3df54a85234"
 	gitCommit    string = "3df54a852345ae127d1fa3092b95168e4a88e2f8" // sha1 from git, output of $(git rev-parse HEAD)
 	gitTreeState string = ""            // state of git tree, either "clean" or "dirty"
 

@afbjorklund
Copy link
Collaborator Author

ok-to-build-iso

@minikube-pr-bot

This comment was marked as outdated.

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot

This comment was marked as outdated.

@minikube-pr-bot

This comment was marked as outdated.

@minikube-pr-bot

This comment was marked as outdated.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2022
@afbjorklund afbjorklund force-pushed the buildroot-2021.02.10 branch from adab88e to 17012aa Compare April 19, 2022 17:52
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2022
@afbjorklund
Copy link
Collaborator Author

ok-to-build-iso

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13814) |
+----------------+----------+---------------------+
| minikube start | 51.8s    | 51.2s               |
| enable ingress | 30.1s    | 29.0s               |
+----------------+----------+---------------------+

Times for minikube start: 52.8s 50.6s 51.7s 52.1s 51.9s
Times for minikube (PR 13814) start: 50.1s 52.1s 51.8s 51.7s 50.2s

Times for minikube ingress: 29.7s 31.1s 31.5s 29.1s 29.1s
Times for minikube (PR 13814) ingress: 25.6s 30.2s 30.1s 29.6s 29.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13814) |
+----------------+----------+---------------------+
| minikube start | 25.5s    | 24.7s               |
| enable ingress | 23.4s    | 22.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.0s 22.9s 22.9s 22.4s 21.9s
Times for minikube (PR 13814) ingress: 23.0s 22.9s 23.0s 22.9s 21.9s

Times for minikube start: 28.3s 24.4s 25.0s 24.6s 25.2s
Times for minikube (PR 13814) start: 23.9s 25.2s 24.9s 25.1s 24.4s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 13814) |
+-------------------+----------+---------------------+
| minikube start    | 38.4s    | 39.7s               |
| ⚠️  enable ingress | 21.6s    | 27.5s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 29.4s 39.9s 39.7s 43.1s 39.8s
Times for minikube (PR 13814) start: 32.2s 40.5s 40.9s 45.2s 39.9s

Times for minikube ingress: 22.5s 22.4s 22.4s 18.9s 21.9s
Times for minikube (PR 13814) ingress: 18.9s 22.4s 32.4s 27.9s 35.9s

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13814) |
+----------------+----------+---------------------+
| minikube start | 51.1s    | 50.8s               |
| enable ingress | 28.8s    | 27.5s               |
+----------------+----------+---------------------+

Times for minikube start: 50.5s 51.4s 50.6s 51.4s 51.7s
Times for minikube (PR 13814) start: 51.3s 49.1s 51.7s 50.7s 51.1s

Times for minikube ingress: 30.1s 29.1s 29.6s 26.1s 29.0s
Times for minikube (PR 13814) ingress: 26.6s 26.6s 26.1s 29.0s 29.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13814) |
+----------------+----------+---------------------+
| minikube start | 25.2s    | 24.6s               |
| enable ingress | 22.5s    | 22.3s               |
+----------------+----------+---------------------+

Times for minikube start: 28.2s 24.1s 24.9s 23.7s 25.1s
Times for minikube (PR 13814) start: 23.9s 24.6s 25.5s 24.6s 24.2s

Times for minikube ingress: 23.5s 22.5s 22.0s 22.4s 21.9s
Times for minikube (PR 13814) ingress: 20.9s 22.9s 22.4s 22.9s 22.4s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 13814) |
+-------------------+----------+---------------------+
| minikube start    | 39.6s    | 40.1s               |
| ⚠️  enable ingress | 20.5s    | 30.6s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 30.3s 38.7s 44.1s 40.2s 44.5s
Times for minikube (PR 13814) start: 39.2s 40.6s 39.9s 40.4s 40.3s

Times for minikube ingress: 22.4s 22.0s 17.9s 21.9s 18.4s
Times for minikube (PR 13814) ingress: 22.4s 32.4s 22.5s 53.4s 22.4s

@spowelljr
Copy link
Member

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13814) |
+----------------+----------+---------------------+
| minikube start | 51.1s    | 51.1s               |
| enable ingress | 29.0s    | 28.2s               |
+----------------+----------+---------------------+

Times for minikube start: 52.4s 50.0s 51.0s 51.3s 50.7s
Times for minikube (PR 13814) start: 51.5s 50.9s 51.4s 50.4s 51.4s

Times for minikube ingress: 29.5s 29.5s 26.5s 29.1s 30.1s
Times for minikube (PR 13814) ingress: 29.0s 26.0s 30.1s 26.5s 29.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13814) |
+----------------+----------+---------------------+
| minikube start | 24.7s    | 24.2s               |
| enable ingress | 23.0s    | 23.6s               |
+----------------+----------+---------------------+

Times for minikube start: 28.2s 23.8s 24.0s 24.1s 23.7s
Times for minikube (PR 13814) start: 24.6s 24.8s 24.2s 24.0s 23.7s

Times for minikube (PR 13814) ingress: 23.0s 26.9s 23.5s 22.4s 22.4s
Times for minikube ingress: 22.9s 22.9s 22.9s 23.4s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13814) |
+----------------+----------+---------------------+
| minikube start | 41.2s    | 41.2s               |
| enable ingress | 20.8s    | 22.7s               |
+----------------+----------+---------------------+

Times for minikube start: 32.8s 44.2s 44.8s 39.7s 44.3s
Times for minikube (PR 13814) start: 40.3s 39.8s 43.5s 43.6s 39.0s

Times for minikube ingress: 17.9s 27.9s 17.9s 22.4s 17.9s
Times for minikube (PR 13814) ingress: 22.4s 22.4s 18.4s 17.9s 32.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 0.00 (chart)
Hyperkit_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh) 3.03 (chart)
Docker_Linux_containerd TestNoKubernetes/serial/StartNoArgs (gopogh) 4.62 (chart)
Docker_Linux TestPause/serial/Pause (gopogh) 5.97 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/custom-weave/Start (gopogh) 11.32 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/auto/Start (gopogh) 13.21 (chart)
Docker_Windows TestAddons/Setup (gopogh) 16.18 (chart)
Docker_Windows TestErrorSpam/setup (gopogh) 16.18 (chart)
Docker_Windows TestForceSystemdFlag (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/CertSync (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/CpCmd (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/DockerEnv/powershell (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/FileSync (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/Setup (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/MySQL (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/NodeLabels (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 16.18 (chart)
Docker_Windows TestFunctional/parallel/PersistentVolumeClaim (gopogh) 16.18 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr
Copy link
Member

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13814) |
+----------------+----------+---------------------+
| minikube start | 51.1s    | 51.2s               |
| enable ingress | 29.8s    | 29.1s               |
+----------------+----------+---------------------+

Times for minikube start: 52.0s 51.4s 50.8s 50.1s 51.3s
Times for minikube (PR 13814) start: 49.8s 50.9s 54.0s 50.4s 51.0s

Times for minikube ingress: 29.1s 29.6s 29.6s 31.0s 29.6s
Times for minikube (PR 13814) ingress: 29.5s 29.1s 29.0s 29.6s 28.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13814) |
+----------------+----------+---------------------+
| minikube start | 24.2s    | 24.3s               |
| enable ingress | 22.9s    | 22.3s               |
+----------------+----------+---------------------+

Times for minikube start: 25.4s 24.0s 23.5s 24.2s 23.9s
Times for minikube (PR 13814) start: 24.0s 24.8s 24.0s 24.3s 24.4s

Times for minikube ingress: 23.0s 21.9s 22.9s 23.9s 22.9s
Times for minikube (PR 13814) ingress: 21.9s 22.4s 23.0s 21.9s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13814) |
+----------------+----------+---------------------+
| minikube start | 40.7s    | 39.8s               |
| enable ingress | 20.9s    | 22.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 13814) start: 39.8s 39.5s 39.3s 39.9s 40.6s
Times for minikube start: 33.2s 43.7s 38.8s 44.2s 43.7s

Times for minikube ingress: 17.9s 18.4s 22.4s 28.0s 17.9s
Times for minikube (PR 13814) ingress: 23.4s 22.4s 22.4s 22.4s 22.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestRunningBinaryUpgrade (gopogh) 1.33 (chart)
Docker_macOS TestDownloadOnlyKic (gopogh) 1.54 (chart)
Docker_macOS TestDownloadOnly/v1.23.5/preload-exists (gopogh) 1.54 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 38.46 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh) 38.46 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 38.46 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 38.46 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/Stop (gopogh) 38.46 (chart)
Docker_Windows TestForceSystemdEnv (gopogh) 38.81 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 40.48 (chart)
Docker_Windows TestPause/serial/Start (gopogh) 41.79 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 45.76 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 46.77 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 46.77 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 50.75 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/Pause (gopogh) 56.92 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 57.41 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 57.41 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 57.41 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 58.18 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 59.70 (chart)
Docker_Windows TestNoKubernetes/serial/Start (gopogh) 59.70 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 61.54 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 62.69 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 66.00 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/DNS (gopogh) 66.67 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 68.00 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 70.37 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/DNS (gopogh) 74.19 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 74.63 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 6703066 into kubernetes:master May 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/failing-test Indicates that a PR should not merge because it has a failing test ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants