Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define qemu as a qemu2 driver alias #14284

Merged
merged 3 commits into from
Jun 7, 2022
Merged

define qemu as a qemu2 driver alias #14284

merged 3 commits into from
Jun 7, 2022
+3 −93

Conversation

sharifelgamal
Copy link
Collaborator

@sharifelgamal sharifelgamal commented Jun 6, 2022 •
edited
Loading

Related: #14146

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 6, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2022
@sharifelgamal
Copy link
Collaborator Author

cc @afbjorklund

@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 6, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14284) |
+----------------+----------+---------------------+
| minikube start | 50.8s    | 50.8s               |
| enable ingress | 27.2s    | 28.8s               |
+----------------+----------+---------------------+

Times for minikube start: 51.6s 48.7s 51.1s 51.4s 51.2s
Times for minikube (PR 14284) start: 51.2s 51.0s 50.9s 50.7s 50.4s

Times for minikube ingress: 26.5s 29.0s 25.5s 25.5s 29.5s
Times for minikube (PR 14284) ingress: 29.1s 28.5s 28.6s 29.1s 29.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14284) |
+----------------+----------+---------------------+
| minikube start | 24.7s    | 24.2s               |
| enable ingress | 22.6s    | 22.3s               |
+----------------+----------+---------------------+

Times for minikube start: 27.9s 23.8s 24.1s 24.0s 23.8s
Times for minikube (PR 14284) start: 24.0s 23.6s 24.1s 24.2s 25.1s

Times for minikube ingress: 22.4s 23.9s 22.4s 22.4s 21.9s
Times for minikube (PR 14284) ingress: 22.4s 22.9s 21.4s 22.4s 22.4s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14284) |
+-------------------+----------+---------------------+
| minikube start    | 30.2s    | 33.5s               |
| ⚠️  enable ingress | 22.9s    | 29.5s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 33.7s 32.3s 27.9s 28.4s 28.4s
Times for minikube (PR 14284) start: 43.6s 28.9s 28.2s 39.1s 27.6s

Times for minikube ingress: 18.9s 28.4s 22.4s 22.4s 22.4s
Times for minikube (PR 14284) ingress: 17.9s 32.4s 22.4s 22.4s 52.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestFunctional/parallel/MountCmd/specific-port (gopogh) 0.00 (chart)
KVM_Linux TestPause/serial/PauseAgain (gopogh) 0.60 (chart)
Docker_Linux TestNetworkPlugins/group/cilium/Start (gopogh) 0.62 (chart)
Docker_Linux TestAddons/parallel/Registry (gopogh) 1.88 (chart)
Docker_Linux TestFunctional/parallel/PersistentVolumeClaim (gopogh) 1.88 (chart)
Docker_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 1.88 (chart)
Docker_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 1.88 (chart)
Docker_Linux TestFunctional/parallel/DashboardCmd (gopogh) 2.50 (chart)
Docker_Linux_containerd TestNoKubernetes/serial/StartNoArgs (gopogh) 5.48 (chart)
Docker_Windows TestNetworkPlugins/group/calico/NetCatPod (gopogh) 7.41 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 7.83 (chart)
Docker_Linux TestNetworkPlugins/group/auto/DNS (gopogh) 8.28 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 14.63 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/Stop (gopogh) 16.36 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/AddonExistsAfterStop (gopogh) 16.97 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/EnableAddonAfterStop (gopogh) 16.97 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/SecondStart (gopogh) 16.97 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/UserAppExistsAfterStop (gopogh) 17.47 (chart)
Docker_macOS TestFunctional/parallel/DashboardCmd (gopogh) 18.75 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 20.00 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 24.32 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/Start (gopogh) 32.50 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 37.96 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 50.00 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 50.93 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 59.38 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 59.38 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 59.38 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 59.38 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 65.62 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

afbjorklund
afbjorklund approved these changes Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@afbjorklund afbjorklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, if wondering the qemu driver is for docker-machine (similar to the kvm driver)

The qemu2 and kvm2 are the internal versions, that are forked and more adapted to minikube...

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 7, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14284) |
+----------------+----------+---------------------+
| minikube start | 51.7s    | 51.6s               |
| enable ingress | 28.6s    | 28.7s               |
+----------------+----------+---------------------+

Times for minikube start: 53.2s 51.2s 52.0s 50.6s 51.5s
Times for minikube (PR 14284) start: 50.9s 51.5s 51.3s 52.4s 52.0s

Times for minikube ingress: 29.1s 28.7s 28.6s 30.6s 26.2s
Times for minikube (PR 14284) ingress: 26.1s 30.6s 30.6s 26.1s 30.1s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14284) |
+-------------------+----------+---------------------+
| minikube start    | 25.3s    | 24.7s               |
| ⚠️  enable ingress | 22.9s    | 35.2s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 27.1s 25.2s 24.6s 24.6s 25.1s
Times for minikube (PR 14284) start: 24.7s 24.7s 24.9s 24.9s 24.5s

Times for minikube ingress: 22.9s 22.0s 23.5s 22.4s 23.4s
Times for minikube (PR 14284) ingress: 84.4s 22.9s 22.9s 22.9s 23.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14284) |
+----------------+----------+---------------------+
| minikube start | 32.6s    | 32.2s               |
| enable ingress | 21.4s    | 22.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 21.9s 22.4s 22.4s 22.5s 17.9s
Times for minikube (PR 14284) ingress: 22.0s 22.4s 22.4s 23.4s 19.9s

Times for minikube start: 31.2s 29.2s 29.1s 29.5s 43.9s
Times for minikube (PR 14284) start: 29.9s 29.0s 29.6s 29.2s 43.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 7.83 (chart)
Docker_Windows TestPause/serial/PauseAgain (gopogh) 9.52 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 14.63 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 20.00 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/DeployApp (gopogh) 30.58 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/SecondStart (gopogh) 30.58 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 31.15 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/FirstStart (gopogh) 32.26 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 33.06 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 33.06 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 33.61 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 34.68 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 41.67 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 49.59 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 50.00 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 50.00 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 50.41 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 50.41 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 50.93 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 73.75 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 74.38 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 75.00 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 75.20 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 75.97 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 78.46 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 80.00 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 81.25 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 87.50 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 87.50 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 87.50 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@sharifelgamal sharifelgamal merged commit f3e7565 into kubernetes:master Jun 7, 2022
@klaases klaases mentioned this pull request Jun 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh left review comments

@afbjorklund afbjorklund afbjorklund approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sharifelgamal @minikube-pr-bot @k8s-ci-robot @medyagh @afbjorklund