Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special case port mapping publish on macOS #14290

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Special case port mapping publish on macOS #14290

merged 1 commit into from
Jun 8, 2022

Conversation

kgibm
Copy link
Contributor

@kgibm kgibm commented Jun 7, 2022

fixes #12658

Signed-off-by: Kevin Grigorenko kevin.grigorenko@us.ibm.com

@kgibm
Issue kubernetes#12658: Special case port mapping publish on macOS
7df74d3 
Signed-off-by: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 7, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kgibm / name: Kevin Grigorenko (7df74d3)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 7, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @kgibm!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @kgibm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 7, 2022
@kgibm kgibm mentioned this pull request Jun 7, 2022
Closed
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 7, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2022
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestMinikubeProfile (gopogh) n/a
Docker_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 0.00 (chart)
Docker_Windows TestNoKubernetes/serial/Stop (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 7.83 (chart)
Docker_macOS TestDownloadOnlyKic (gopogh) 9.52 (chart)
Docker_macOS TestDownloadOnly/v1.23.6/preload-exists (gopogh) 9.52 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 37.96 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 50.93 (chart)
Docker_Windows TestAddons/Setup (gopogh) 51.85 (chart)
Docker_Windows TestErrorSpam/setup (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/CertSync (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/CpCmd (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/DockerEnv/powershell (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/FileSync (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/Setup (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/MySQL (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/NodeLabels (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/PersistentVolumeClaim (gopogh) 51.85 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr
Copy link
Member

/retest-this-please

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestSkaffold (gopogh) 0.00 (chart)
Docker_macOS TestMultiNode/serial/AddNode (gopogh) 1.04 (chart)
Docker_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 1.04 (chart)
Docker_macOS TestMultiNode/serial/StartAfterStop (gopogh) 1.04 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 7.83 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 9.78 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 20.00 (chart)
Docker_Windows TestPause/serial/Pause (gopogh) 22.22 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 24.32 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 41.67 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 50.93 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 80.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 87.50 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 87.50 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 87.50 (chart)
Docker_macOS TestPreload (gopogh) 87.50 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 87.50 (chart)
Docker_macOS TestPause/serial/VerifyStatus (gopogh) 88.42 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 88.42 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 88.54 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 88.54 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 94.32 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/Pause (gopogh) 94.32 (chart)
Docker_macOS TestStartStop/group/newest-cni/serial/Pause (gopogh) 94.32 (chart)
Docker_macOS TestStartStop/group/no-preload/serial/Pause (gopogh) 94.32 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 94.32 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 94.32 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 94.32 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 94.32 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 94.32 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@kgibm
Copy link
Contributor Author

kgibm commented Jun 8, 2022

Looking at the first log, the error seems to be related to Docker pull request limits:

ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/golang/manifests/sha256:39f9d94d45e404c98c3aa3c9b2406185f46ffddefeb45cdd9b778024626302fc: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

@spowelljr
Copy link
Member

Hi @kgibm, thanks for noticing that, I'll make sure to login to our Docker Hub accounts on our CI machines to prevent this in the future.

@spowelljr
Copy link
Member

A large amount of the test environments didn't report back, so going to run the tests again.

@spowelljr
Copy link
Member

/retest-this-please

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestMinikubeProfile (gopogh) n/a
Docker_Windows TestNoKubernetes/serial/Stop (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 7.83 (chart)
Docker_Windows TestAddons/Setup (gopogh) 51.85 (chart)
Docker_Windows TestErrorSpam/setup (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/CertSync (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/CpCmd (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/DockerEnv/powershell (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/FileSync (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/Setup (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/MySQL (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/NodeLabels (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/PersistentVolumeClaim (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/SSHCmd (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/StatusCmd (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/UpdateContextCmd/no_changes (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh) 51.85 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@kgibm
Copy link
Contributor Author

kgibm commented Jun 8, 2022

First test error seems to be:

Error response from daemon: cannot create network 683cd12d1eddbbf070e65dfdac992936ad3eaba811349fd9017b386ad031bdf3 (br-683cd12d1edd): conflicts with network 242e5ea9b5729ee491a318a05d91513f513576e09c7633b19207dbd56a7d298a (br-242e5ea9b572): networks have overlapping IPv4

Conflicting networks? And this was on Windows so it should not have been affected by this patch.

@spowelljr
Copy link
Member

First test error seems to be:

Error response from daemon: cannot create network 683cd12d1eddbbf070e65dfdac992936ad3eaba811349fd9017b386ad031bdf3 (br-683cd12d1edd): conflicts with network 242e5ea9b5729ee491a318a05d91513f513576e09c7633b19207dbd56a7d298a (br-242e5ea9b572): networks have overlapping IPv4

Conflicting networks? And this was on Windows so it should not have been affected by this patch.

Yeah, this PR seems fine to me

@spowelljr spowelljr merged commit c099c05 into kubernetes:master Jun 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kgibm, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@spowelljr spowelljr mentioned this pull request Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minikube with podman on macOS darwin/amd64 doesn't work
5 participants
@kgibm @k8s-ci-robot @minikube-bot @spowelljr @minikube-pr-bot