Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update nginx image #14317

Merged
merged 1 commit into from
Jun 13, 2022
Merged

update nginx image #14317

merged 1 commit into from
Jun 13, 2022

Conversation

spowelljr
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2022
@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 13, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14317) |
+----------------+----------+---------------------+
| minikube start | 51.2s    | 50.7s               |
| enable ingress | 28.1s    | 28.3s               |
+----------------+----------+---------------------+

Times for minikube start: 51.0s 52.2s 50.8s 51.1s 51.1s
Times for minikube (PR 14317) start: 50.5s 51.6s 50.7s 50.7s 50.3s

Times for minikube ingress: 26.5s 30.6s 29.0s 28.6s 25.6s
Times for minikube (PR 14317) ingress: 26.0s 29.6s 31.0s 25.5s 29.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14317) |
+----------------+----------+---------------------+
| minikube start | 25.0s    | 24.4s               |
| enable ingress | 23.3s    | 23.3s               |
+----------------+----------+---------------------+

Times for minikube start: 28.1s 23.9s 24.6s 24.7s 23.7s
Times for minikube (PR 14317) start: 24.0s 23.4s 25.6s 23.8s 25.1s

Times for minikube ingress: 23.5s 22.9s 21.9s 25.9s 22.4s
Times for minikube (PR 14317) ingress: 22.9s 25.0s 22.9s 23.4s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14317) |
+----------------+----------+---------------------+
| minikube start | 32.1s    | 30.9s               |
| enable ingress | 24.8s    | 21.9s               |
+----------------+----------+---------------------+

Times for minikube start: 29.9s 29.5s 32.0s 28.3s 40.7s
Times for minikube (PR 14317) start: 31.4s 33.2s 32.4s 28.6s 28.9s

Times for minikube ingress: 22.5s 28.4s 18.9s 32.4s 21.9s
Times for minikube (PR 14317) ingress: 18.9s 17.9s 17.9s 32.4s 22.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestSkaffold (gopogh) 0.00 (chart)
Hyperkit_macOS TestSkaffold (gopogh) 0.81 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 7.83 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 9.38 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/DNS (gopogh) 27.78 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/DeployApp (gopogh) 30.58 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/SecondStart (gopogh) 30.58 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 31.15 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/FirstStart (gopogh) 32.26 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 49.59 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 50.00 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 50.00 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 50.41 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 50.41 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 50.93 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 73.75 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 74.38 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 75.00 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 75.20 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 75.97 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 78.46 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 81.25 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 87.50 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 87.50 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 87.50 (chart)
Docker_macOS TestPreload (gopogh) 87.50 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 87.50 (chart)
Docker_macOS TestPause/serial/VerifyStatus (gopogh) 88.42 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 88.42 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 88.54 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 0292a8a into kubernetes:master Jun 13, 2022
@spowelljr spowelljr deleted the updateNginx branch June 13, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@medyagh medyagh Awaiting requested review from medyagh

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spowelljr @sharifelgamal @minikube-pr-bot @k8s-ci-robot