Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gcp-auth-webhook to v0.0.9 #14372

Merged
merged 4 commits into from
Jun 21, 2022

Conversation

sharifelgamal
Copy link
Collaborator

@sharifelgamal sharifelgamal commented Jun 21, 2022

This is PR updates the gcp-auth-webhook image to v0.0.9, which includes fixes specified in the release.

The TL;DR is that we now add credentials to initContainers as well as containers, and fix a bug where service accounts created after addon enable weren't getting the image pull secret.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2022
@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 21, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14372) |
+----------------+----------+---------------------+
| minikube start | 51.3s    | 51.4s               |
| enable ingress | 28.3s    | 26.5s               |
+----------------+----------+---------------------+

Times for minikube start: 52.4s 51.9s 50.0s 51.1s 51.1s
Times for minikube (PR 14372) start: 50.5s 50.9s 53.1s 52.0s 50.4s

Times for minikube ingress: 29.8s 29.5s 30.0s 26.6s 25.6s
Times for minikube (PR 14372) ingress: 26.6s 25.6s 25.1s 26.5s 28.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14372) |
+----------------+----------+---------------------+
| minikube start | 24.3s    | 24.8s               |
| enable ingress | 23.6s    | 22.7s               |
+----------------+----------+---------------------+

Times for minikube start: 23.9s 23.8s 24.6s 24.8s 24.3s
Times for minikube (PR 14372) start: 25.4s 25.0s 23.9s 25.0s 24.7s

Times for minikube ingress: 23.4s 22.4s 22.9s 22.9s 26.4s
Times for minikube (PR 14372) ingress: 23.4s 23.4s 22.5s 21.9s 22.4s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14372) |
+-------------------+----------+---------------------+
| minikube start    | 42.3s    | 34.8s               |
| ⚠️  enable ingress | 21.8s    | 27.0s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube ingress: 28.4s 22.4s 18.0s 17.9s 22.4s
Times for minikube (PR 14372) ingress: 18.9s 22.4s 22.5s 22.4s 48.9s

Times for minikube start: 43.5s 39.8s 43.9s 43.8s 40.4s
Times for minikube (PR 14372) start: 32.1s 40.4s 28.3s 29.5s 43.8s

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this PR :) please lets add PR description and possibly explain what it is is fixing

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sharifelgamal sharifelgamal merged commit 319dd49 into kubernetes:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants