-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update gcp-auth-webhook to v0.0.9 #14372
update gcp-auth-webhook to v0.0.9 #14372
Conversation
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 52.4s 51.9s 50.0s 51.1s 51.1s Times for minikube ingress: 29.8s 29.5s 30.0s 26.6s 25.6s docker driver with docker runtime
Times for minikube start: 23.9s 23.8s 24.6s 24.8s 24.3s Times for minikube ingress: 23.4s 22.4s 22.9s 22.9s 26.4s docker driver with containerd runtime
Times for minikube ingress: 28.4s 22.4s 18.0s 17.9s 22.4s Times for minikube start: 43.5s 39.8s 43.9s 43.8s 40.4s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for this PR :) please lets add PR description and possibly explain what it is is fixing
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is PR updates the gcp-auth-webhook image to v0.0.9, which includes fixes specified in the release.
The TL;DR is that we now add credentials to initContainers as well as containers, and fix a bug where service accounts created after addon enable weren't getting the image pull secret.