add VerifiedMaintainer field to Addons and display a warning if empty #14499

inifares23lab · 2022-07-03T12:45:33Z

The Addon type now has another string Field: VerifiedMaintainer
The new field is added to the NewAddon function and to the Addons map.

When enabling an addon if the VerifiedMaintainer field is empty a warning message is displayed:

! The <ADDON_NAME> addon doesn't have a verified maintainer.
Since for now I just added an empty string for every addon, it will always display the warning when enabling

fixes #14493

k8s-ci-robot · 2022-07-03T12:45:41Z

Hi @inifares23lab. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2022-07-03T12:48:03Z

Can one of the admins verify this patch?

spowelljr

Hi @inifares23lab, there are a lot of formatting problems in this PR, could you run gofmt -w -s . to resolve them and then push the changes up, thanks.

inifares23lab · 2022-07-06T21:24:49Z

Hi @spowelljr
apologies
formatted and pushed now

spowelljr · 2022-07-06T22:51:27Z

Hi @inifares23lab, thanks for formatting the code.

Could you wrap all Maintainers that aren't Google or Kubernetes with 3rd party (X).

For example Portainer.io to 3rd party (Portainer.io)

Could you also add 3rd party (Gluster) as the maintainer for storage-provisioner-gluster.

If the Maintainer is Kubernetes or Google could you make the message be the following:

<addon_name> is an addon maintained by <maintainer> for any concerns contact minikube on GitHub.
You can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS

For the rest of addons could you update your message to:

<addon_name> is A 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.

And for 3rd party addons, if there's a verified maintainer for the addon could you also add the following line:

<addonn_name> is maintained by <maintainer> for any concerns contact <verified_maintaer> on GitHub.

inifares23lab · 2022-07-07T14:20:28Z

Hello

updated messages and handled the 3 different cases
updated 3rd party maintainers and fixed some typos

examples:
💡 auto-pause is an addon maintained by Google. For any concerns contact minikube on GitHub.
You can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS

❗ ambassador is A 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.

💡 metallb is maintained by 3rd party (MetalLB) for any concerns contact MOCK-VERIFI
ED-MAINTAINER on GitHub.

cmd/minikube/cmd/config/enable.go

spowelljr

The Google/Kubernetes and no verified maintainer case is perfect.

But if it's a 3rd party and has a verified maintainer it should have both messages:

<addon_name> is A 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.
<addon_name> is maintained by <maintainer> for any concerns contact <verified_maintaer> on GitHub.

That ways they're notified it's a 3rd party addon and to enable at their own risk, but also pointed to someone if they have troubles.

pkg/minikube/assets/addons.go

cmd/minikube/cmd/config/enable.go

inifares23lab · 2022-07-15T12:04:32Z

Hi @spowelljr

I agree that displaying both messages is more clear for the user, however I have one concern:

the first message also states that the addon is not verified by minikube maintainers even if in some cases it has a VerifiedMaintainer

It may be better to further customize the messages for the two cases:

3rd party without verified maintainer(same as before):

<addon_name> is A 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.

3rd party with a verified maintainer(add the first message but omit "or verified"):

<addon_name> is A 3rd party addon and not maintained by minikube maintainers, enable at your own risk.
<addon_name> is maintained by <.maintainer> for any concerns contact <verified_maintaer> on GitHub.

Let me know if it makes sense to you
thanks

spowelljr · 2022-07-15T20:37:11Z

Hi @inifares23lab, I know in the issue I originally mentioned a verified maintainer but that was just something I quickly jotted down and should have named it something else.

The field can be called anything, GitHubMaintainer or something like that, there's really no verifying the user themselves. Verified is related to the addon itself though, and any addon that's not maintained by Kubernetes or Google isn't verified.

So the message:
<addon_name> is A 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.
Seems fine to me for both cases because there is no verified maintainer.

inifares23lab · 2022-07-16T13:56:43Z

understood, thank you for clarifying.
I applied the requested changes

spowelljr

Looks good! Just a few last comments

pkg/minikube/assets/addons.go

…maintainer

spowelljr · 2022-07-25T17:31:26Z

/ok-to-test

minikube-pr-bot · 2022-07-25T21:21:02Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14499) |
+----------------+----------+---------------------+
| minikube start | 55.5s    | 56.6s               |
| enable ingress | 28.3s    | 27.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 29.0s 29.5s 28.6s 25.6s 28.5s
Times for minikube (PR 14499) ingress: 25.6s 28.1s 27.1s 29.7s 27.1s

Times for minikube start: 56.0s 54.7s 55.2s 55.9s 55.7s
Times for minikube (PR 14499) start: 56.1s 57.6s 55.7s 56.6s 57.1s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error downloading artifacts: artifact download start: exit status 90

minikube-pr-bot · 2022-07-25T22:55:12Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_macOS	TestDownloadOnlyKic (gopogh)	1.36 (chart)
Docker_macOS	TestDownloadOnly/v1.24.2/preload-exists (gopogh)	1.36 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/auto/DNS (gopogh)	2.68 (chart)
KVM_Linux_containerd	TestPause/serial/SecondStartNoReconfiguration (gopogh)	13.38 (chart)
Docker_Linux_containerd	TestOffline (gopogh)	24.32 (chart)
Docker_Linux_containerd	TestAddons/Setup (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestFunctional/parallel/DashboardCmd (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MountCmd/any-port (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MySQL (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmd (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmdConnect (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestFunctional/serial/ExtraConfig (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestFunctional/serial/SoftStart (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestFunctional/serial/StartWithProxy (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestJSONOutput/start/Command (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestMultiNode/serial/AddNode (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestMultiNode/serial/DeleteNode (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestMultiNode/serial/DeployApp2Nodes (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestMultiNode/serial/FreshStart2Nodes (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestMultiNode/serial/ProfileList (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestMultiNode/serial/StartAfterStop (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestMultiNode/serial/StopNode (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestPreload (gopogh)	25.68 (chart)
Docker_Linux_containerd	TestMultiNode/serial/RestartKeepsNodes (gopogh)	27.70 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

spowelljr

Looks good, thanks for your work on this!

k8s-ci-robot · 2022-07-26T00:00:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inifares23lab, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

inifares23lab added 2 commits July 3, 2022 14:25

add verifiedMaintainer field to Addon

9d44b9c

display warning for addons with unverified Maintainer

dfb4860

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2022

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2022

k8s-ci-robot requested review from prasadkatti and spowelljr July 3, 2022 12:46

spowelljr requested changes Jul 6, 2022

View reviewed changes

formatting with 'gofmt -w -s .'

21e00cf

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 6, 2022

inifares23lab requested a review from spowelljr July 6, 2022 21:26

update maintainer field for addons

2a43f33

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 7, 2022

spowelljr requested changes Jul 8, 2022

View reviewed changes

cmd/minikube/cmd/config/enable.go Outdated Show resolved Hide resolved

cmd/minikube/cmd/config/enable.go Outdated Show resolved Hide resolved

cmd/minikube/cmd/config/enable.go Outdated Show resolved Hide resolved

inifares23lab force-pushed the master branch from b9eaa83 to 7101eaf Compare July 9, 2022 13:29

inifares23lab requested a review from spowelljr July 12, 2022 10:00

spowelljr requested changes Jul 14, 2022

View reviewed changes

pkg/minikube/assets/addons.go Outdated Show resolved Hide resolved

cmd/minikube/cmd/config/enable.go Outdated Show resolved Hide resolved

inifares23lab force-pushed the master branch from 7101eaf to 179ce6f Compare July 16, 2022 13:54

inifares23lab requested a review from spowelljr July 16, 2022 13:56

spowelljr requested changes Jul 18, 2022

View reviewed changes

pkg/minikube/assets/addons.go Outdated Show resolved Hide resolved

pkg/minikube/assets/addons.go Outdated Show resolved Hide resolved

pkg/minikube/assets/addons.go Outdated Show resolved Hide resolved

when enable addons differentiate message for maintainer and verified …

7dfe7e6

…maintainer

inifares23lab force-pushed the master branch from 179ce6f to 7dfe7e6 Compare July 20, 2022 19:01

inifares23lab requested a review from spowelljr July 20, 2022 19:03

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 25, 2022

spowelljr approved these changes Jul 26, 2022

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2022

spowelljr merged commit 0d274d5 into kubernetes:master Jul 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add VerifiedMaintainer field to Addons and display a warning if empty #14499

add VerifiedMaintainer field to Addons and display a warning if empty #14499

inifares23lab commented Jul 3, 2022

k8s-ci-robot commented Jul 3, 2022

minikube-bot commented Jul 3, 2022

spowelljr left a comment

inifares23lab commented Jul 6, 2022

spowelljr commented Jul 6, 2022 •

edited

Loading

inifares23lab commented Jul 7, 2022

spowelljr left a comment

inifares23lab commented Jul 15, 2022 •

edited

Loading

spowelljr commented Jul 15, 2022

inifares23lab commented Jul 16, 2022

spowelljr left a comment

spowelljr commented Jul 25, 2022

minikube-pr-bot commented Jul 25, 2022

minikube-pr-bot commented Jul 25, 2022

spowelljr left a comment

k8s-ci-robot commented Jul 26, 2022

add VerifiedMaintainer field to Addons and display a warning if empty #14499

add VerifiedMaintainer field to Addons and display a warning if empty #14499

Conversation

inifares23lab commented Jul 3, 2022

k8s-ci-robot commented Jul 3, 2022

minikube-bot commented Jul 3, 2022

spowelljr left a comment

Choose a reason for hiding this comment

inifares23lab commented Jul 6, 2022

spowelljr commented Jul 6, 2022 • edited Loading

inifares23lab commented Jul 7, 2022

spowelljr left a comment

Choose a reason for hiding this comment

inifares23lab commented Jul 15, 2022 • edited Loading

spowelljr commented Jul 15, 2022

inifares23lab commented Jul 16, 2022

spowelljr left a comment

Choose a reason for hiding this comment

spowelljr commented Jul 25, 2022

minikube-pr-bot commented Jul 25, 2022

minikube-pr-bot commented Jul 25, 2022

spowelljr left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 26, 2022

spowelljr commented Jul 6, 2022 •

edited

Loading

inifares23lab commented Jul 15, 2022 •

edited

Loading