Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of audit entries #14695

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Conversation

spowelljr
Copy link
Member

Closes #14543

  • Added feature to cap amount of audit entries
    • Once limit is passed, the oldest entries are trimmed
    • By default limits audit entries to 1,000 lines
  • Added config option MaxAuditEntries
    • Allows to customize the max amount of audit entries to retain
    • minikube config set MaxAuditEntries <number>
    • Setting to 0 will set to unlimited audit entries
  • Added test to ensure cap and MaxAuditEntries are working

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 1, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14695) |
+----------------+----------+---------------------+
| minikube start | 56.2s    | 57.1s               |
| enable ingress | 29.4s    | 29.1s               |
+----------------+----------+---------------------+

Times for minikube start: 56.4s 56.8s 55.6s 56.3s 55.8s
Times for minikube (PR 14695) start: 57.6s 56.6s 58.9s 56.4s 56.1s

Times for minikube ingress: 28.7s 27.7s 30.2s 31.2s 29.2s
Times for minikube (PR 14695) ingress: 29.2s 28.7s 29.7s 28.2s 29.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14695) |
+----------------+----------+---------------------+
| minikube start | 29.6s    | 29.6s               |
| enable ingress | 35.1s    | 22.2s               |
+----------------+----------+---------------------+

Times for minikube start: 29.6s 30.8s 29.2s 30.0s 28.8s
Times for minikube (PR 14695) start: 30.4s 28.6s 29.3s 30.9s 28.9s

Times for minikube ingress: 24.0s 21.5s 83.0s 23.5s 23.5s
Times for minikube (PR 14695) ingress: 22.0s 23.0s 22.1s 21.5s 22.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14695) |
+----------------+----------+---------------------+
| minikube start | 24.8s    | 24.6s               |
| enable ingress | 27.0s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube start: 24.6s 25.4s 24.5s 24.8s 24.6s
Times for minikube (PR 14695) start: 24.5s 24.5s 24.6s 24.4s 25.0s

Times for minikube ingress: 27.0s 27.0s 27.1s 27.1s 27.0s
Times for minikube (PR 14695) ingress: 27.0s 27.0s 27.0s 27.0s 27.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestPause/serial/Start (gopogh) 0.62 (chart)
Docker_Linux_containerd TestFunctional/serial/LogsFileCmd (gopogh) 5.88 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 39.19 (chart)
KVM_Linux TestMultiNode/serial/RestartMultiNode (gopogh) 42.60 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 46.58 (chart)
Docker_Windows TestKubernetesUpgrade (gopogh) 55.15 (chart)
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) 56.76 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 60.00 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 74.84 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 75.00 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 78.74 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 80.00 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 88.05 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 88.68 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 90.57 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 91.19 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 92.12 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 97.67 (chart)
Docker_Linux_containerd TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/HairPin (gopogh) 100.00 (chart)
Docker_macOS TestPause/serial/VerifyStatus (gopogh) 100.00 (chart)
Docker_macOS TestPreload (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 87d7e3b into kubernetes:master Aug 2, 2022
@spowelljr spowelljr deleted the limitAuditSize branch August 2, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit size of audit log
4 participants