Implement socket_vmnet network (QEMU) #14989

spowelljr · 2022-09-21T18:32:24Z

Implemented socket_vmnet network for the QEMU driver

minikube start:

$ minikube start --driver qemu --network socket_vmnet
😄  minikube v1.27.0 on Darwin 12.6 (arm64)
✨  Using the qemu2 (experimental) driver based on user configuration
❗  Using qemu with 'socket_vmnet' network is experimental
👍  Starting control plane node minikube in cluster minikube
🔥  Creating qemu2 VM (CPUs=2, Memory=4000MB, Disk=20000MB) ...
🐳  Preparing Kubernetes v1.25.1 on Docker 20.10.18 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

minikube service:

$ kubectl create deployment hello-minikube --image=docker.io/nginx:1.23
$ kubectl expose deployment hello-minikube --type=NodePort --port=80
$ minikube service hello-minikube
|-----------|----------------|-------------|----------------------------|
| NAMESPACE |      NAME      | TARGET PORT |            URL             |
|-----------|----------------|-------------|----------------------------|
| default   | hello-minikube |          80 | http://192.168.105.2:32037 |
|-----------|----------------|-------------|----------------------------|
🎉  Opening service default/hello-minikube in default browser...
$ curl 192.168.105.2:32037
<!DOCTYPE html>
<html>
<head>
<title>Welcome to nginx!</title>
...

minikube tunnel:

$ kubectl create deployment balanced --image=docker.io/nginx:1.23
$ kubectl expose deployment balanced --type=LoadBalancer --port=80
$ minikube tunnel

# in new terminal window
$ kubectl get services balanced
NAME       TYPE           CLUSTER-IP     EXTERNAL-IP    PORT(S)        AGE
balanced   LoadBalancer   10.101.76.73   10.101.76.73   80:30925/TCP   22s
$ curl 10.101.76.73:80
<!DOCTYPE html>
<html>
<head>
<title>Welcome to nginx!</title>
...

starting with user network (backwards-compatibility)

$ minikube start --driver qemu
😄  minikube v1.27.0 on Darwin 12.6 (arm64)
✨  Using the qemu2 (experimental) driver based on user configuration
❗  The default network for QEMU will change from 'user' to 'socket_vmnet' in a future release
❗  You are using the QEMU driver without a dedicated network, which doesn't support `minikube service` & `minikube tunnel` commands.
To try the experimental dedicated network see: https://minikube.sigs.k8s.io/docs/drivers/qemu/#networking
👍  Starting control plane node minikube in cluster minikube
🔥  Creating qemu2 VM (CPUs=2, Memory=4000MB, Disk=20000MB) ...
🐳  Preparing Kubernetes v1.25.1 on Docker 20.10.18 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

medyagh

the PR looks good to me except we need a documentation page, and also I think we might wanna change the name "socket" to be something more meaningful

I hate to use overloaded words, socket means a lot of things in many worlds.

how about we use a name like "socket_vmnet" or "lima_socket" ?

I also like to know what @afbjorklund thinks

cmd/minikube/cmd/start_flags.go

site/content/en/docs/drivers/qemu.md

eiffel-fl

I was able to create a minikube cluster with network=socket_vmnet and running the service subcommand.

I have some comments but nothing really serious(mainly translation even though they are not perfect):

cmd/minikube/cmd/start_flags.go

pkg/drivers/qemu/qemu.go

translations/fr.json

pkg/drivers/common.go

Co-authored-by: Akihiro Suda <suda.kyoto@gmail.com>

klaases

Nice work, well done!

k8s-ci-robot · 2022-10-03T22:55:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klaases, medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hamidasl · 2024-10-14T01:25:12Z

https://github.com/users/SashaITx/achievements/pull-shark

Hamidasl · 2024-10-14T01:28:51Z

cmd/minikube/cmd/docker-env.go

@@ -50,6 +50,7 @@ import (
 	"k8s.io/minikube/pkg/minikube/reason"


k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 21, 2022

k8s-ci-robot requested review from afbjorklund and klaases September 21, 2022 18:32

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 21, 2022

spowelljr force-pushed the socketVMNet branch 3 times, most recently from f6587cc to 1e57e04 Compare September 21, 2022 21:20

spowelljr force-pushed the socketVMNet branch 2 times, most recently from fbc8685 to 1525689 Compare September 26, 2022 20:04

spowelljr mentioned this pull request Sep 26, 2022

site: fix wrong port numbers #15020

Merged

spowelljr force-pushed the socketVMNet branch from b29a4da to b9af80e Compare September 26, 2022 20:59

spowelljr changed the title ~~WIP: Implement socket_vmnet~~ Implement socket_vmnet Sep 26, 2022

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2022

spowelljr changed the title ~~Implement socket_vmnet~~ Implement socket_vmnet network (QEMU) Sep 26, 2022

medyagh requested changes Sep 26, 2022

View reviewed changes

cmd/minikube/cmd/start_flags.go Outdated Show resolved Hide resolved

AkihiroSuda reviewed Sep 28, 2022

View reviewed changes

site/content/en/docs/drivers/qemu.md Outdated Show resolved Hide resolved

spowelljr mentioned this pull request Sep 28, 2022

QEMU stops working with minikube #15021

Open

eiffel-fl reviewed Sep 28, 2022

View reviewed changes

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 29, 2022

This was referenced Sep 30, 2022

WIP: create tunnel for qemu #14615

Closed

Known QEMU2 Driver Issues #14146

Open

spowelljr force-pushed the socketVMNet branch from e5cd1e9 to f11d12d Compare September 30, 2022 21:00

medyagh self-requested a review October 3, 2022 21:39

medyagh approved these changes Oct 3, 2022

View reviewed changes

klaases reviewed Oct 3, 2022

View reviewed changes

pkg/drivers/common.go Outdated Show resolved Hide resolved

klaases reviewed Oct 3, 2022

View reviewed changes

pkg/drivers/common.go Outdated Show resolved Hide resolved

spowelljr and others added 10 commits October 3, 2022 15:14

implement socket_vmnet

8c12c40

rename socket to socket_vmnet

ad1951a

update experimental message and logic

5fc653b

add qemu networking docs

47b5cfa

make network options tabbed

6d4f255

update messaging if using user network

5c27bc4

generate-docs

324ab82

update user network information

5d8512f

Co-authored-by: Akihiro Suda <suda.kyoto@gmail.com>

add darwin conditionals

f1b909e

inline

463db44

spowelljr force-pushed the socketVMNet branch from d7cdd74 to 463db44 Compare October 3, 2022 22:18

klaases approved these changes Oct 3, 2022

View reviewed changes

spowelljr merged commit e961a52 into kubernetes:master Oct 3, 2022

spowelljr deleted the socketVMNet branch October 3, 2022 23:16

Hamidasl reviewed Oct 14, 2024

View reviewed changes

cmd/minikube/cmd/docker-env.go

@@ -50,6 +50,7 @@ import (

"k8s.io/minikube/pkg/minikube/reason"

Copy link

Hamidasl Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8c12c40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement socket_vmnet network (QEMU) #14989

Implement socket_vmnet network (QEMU) #14989

spowelljr commented Sep 21, 2022 •

edited

Loading

medyagh left a comment

eiffel-fl left a comment •

edited

Loading

klaases left a comment

k8s-ci-robot commented Oct 3, 2022

Hamidasl commented Oct 14, 2024

Hamidasl Oct 14, 2024

		@@ -50,6 +50,7 @@ import (
		"k8s.io/minikube/pkg/minikube/reason"

Implement socket_vmnet network (QEMU) #14989

Implement socket_vmnet network (QEMU) #14989

Conversation

spowelljr commented Sep 21, 2022 • edited Loading

medyagh left a comment

Choose a reason for hiding this comment

eiffel-fl left a comment • edited Loading

Choose a reason for hiding this comment

klaases left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 3, 2022

Hamidasl commented Oct 14, 2024

Hamidasl Oct 14, 2024

Choose a reason for hiding this comment

spowelljr commented Sep 21, 2022 •

edited

Loading

eiffel-fl left a comment •

edited

Loading