Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop applying the beta.kubernetes.io/os and arch #15225

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Stop applying the beta.kubernetes.io/os and arch #15225

merged 1 commit into from
Nov 21, 2022

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Oct 27, 2022

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 27, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 27, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 18, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15225) |
+----------------+----------+---------------------+
| minikube start | 54.3s    | 55.3s               |
| enable ingress | 26.8s    | 27.2s               |
+----------------+----------+---------------------+

Times for minikube start: 55.4s 55.9s 54.0s 53.0s 53.3s
Times for minikube (PR 15225) start: 54.1s 54.4s 54.0s 58.2s 55.9s

Times for minikube ingress: 27.2s 27.7s 25.2s 25.7s 28.2s
Times for minikube (PR 15225) ingress: 28.7s 26.1s 28.7s 25.2s 27.2s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error downloading artifacts: artifact download start: exit status 90

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestMultiNode/serial/DeleteNode (gopogh) 0.00 (chart)
KVM_Linux_containerd TestMultiNode/serial/RestartKeepsNodes (gopogh) 0.00 (chart)
Hyperkit_macOS TestPause/serial/SecondStartNoReconfiguration (gopogh) 22.82 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 24.52 (chart)
Docker_Linux_containerd TestAddons/Setup (gopogh) 29.68 (chart)
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 29.68 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 29.68 (chart)
Docker_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 29.68 (chart)
Docker_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 29.68 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 29.68 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmdConnect (gopogh) 29.68 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 29.68 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 29.68 (chart)
Docker_Linux_containerd TestFunctional/serial/ExtraConfig (gopogh) 29.68 (chart)
Docker_Linux_containerd TestFunctional/serial/SoftStart (gopogh) 29.68 (chart)
Docker_Linux_containerd TestFunctional/serial/StartWithProxy (gopogh) 29.68 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 29.68 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 29.68 (chart)
Docker_Linux_containerd TestJSONOutput/start/Command (gopogh) 29.68 (chart)
Docker_Linux_containerd TestMultiNode/serial/AddNode (gopogh) 29.68 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeleteNode (gopogh) 29.68 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeployApp2Nodes (gopogh) 29.68 (chart)
Docker_Linux_containerd TestMultiNode/serial/FreshStart2Nodes (gopogh) 29.68 (chart)
Docker_Linux_containerd TestMultiNode/serial/PingHostFrom2Pods (gopogh) 29.68 (chart)
Docker_Linux_containerd TestMultiNode/serial/ProfileList (gopogh) 29.68 (chart)
Docker_Linux_containerd TestMultiNode/serial/StartAfterStop (gopogh) 29.68 (chart)
Docker_Linux_containerd TestMultiNode/serial/StopNode (gopogh) 29.68 (chart)
Docker_Linux_containerd TestOffline (gopogh) 29.68 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartKeepsNodes (gopogh) 30.32 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartMultiNode (gopogh) 30.97 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@pacoxu
Copy link
Member Author

pacoxu commented Nov 21, 2022

Are the failed test cases related to the change? I think not.

@spowelljr
Copy link
Member

Are the failed test cases related to the change? I think not.

No, these are unrelated to the change

spowelljr
spowelljr approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2022
@spowelljr spowelljr merged commit 0052ba3 into kubernetes:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

@medyagh medyagh Awaiting requested review from medyagh

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pacoxu @minikube-bot @spowelljr @minikube-pr-bot @k8s-ci-robot