iso: Add FANOTIFY_ACCESS_PERMISSIONS to kernel configs. #15232

eiffel-fl · 2022-10-28T07:57:22Z

Hi.

In this PR, I added CONFIG_FANOTIFY_ACCESS_PERMISSIONS to minikube ISO kernel configs.
Inspektor Gadget makes use of fanotify to detect when new containers are created.
To do so, we rely on CONFIG_FANOTIFY_ACCESS_PERMISSIONS which is sadly not present in minikube kernel packaged in the ISO.
As a consequence, we fallback to podinformer but this implementation does not permit our tool to trace early events after container creation.

As you can see, with the default ISO, we fallback to podinformer.

$ minikube start --driver=kvm
...
🏄  Terminé ! kubectl est maintenant configuré pour utiliser "minikube" cluster et espace de noms "default" par défaut.
$ ./kubectl-gadget deploy
...
Inspektor Gadget successfully deployed
$ minikube ssh zgrep FANOTIFY /proc/config.gz
CONFIG_FANOTIFY=y
# CONFIG_FANOTIFY_ACCESS_PERMISSIONS is not set
$ kubectl logs -n gadget $(kubectl get pods -n gadget --no-headers -o custom-columns=":metadata.name")          main % u=
...
Starting the Gadget Tracer Manager...
time="2022-10-28T07:45:19Z" level=warning msg="Runcfanotify: failed to fanotify mark: fanotify: mark error, invalid argument"
time="2022-10-28T07:45:19Z" level=info msg="GadgetTracerManager: hook mode: podinformer (auto)"
...

While with the new ISO, we use fanotify:

$ minikube start --driver=kvm --iso-url=file://$(pwd)/../minikube-fanotify.iso
...
🏄  Terminé ! kubectl est maintenant configuré pour utiliser "minikube" cluster et espace de noms "default" par défaut.
$ ./kubectl-gadget deploy
...
Inspektor Gadget successfully deployed
$ minikube ssh zgrep FANOTIFY /proc/config.gz
CONFIG_FANOTIFY=y
CONFIG_FANOTIFY_ACCESS_PERMISSIONS=y
$ kubectl logs -n gadget $(kubectl get pods -n gadget --no-headers -o custom-columns=":metadata.name")          main % u=
...
Starting the Gadget Tracer Manager...
time="2022-10-28T07:51:06Z" level=info msg="GadgetTracerManager: hook mode: fanotify (auto)"
...

I am sure this contribution can be of other use for other projects in the Kubernetes landscape and will empower other developers.

Of course, if you have any question and/or remark to make this contribution better, feel free to share :) !

Best regards and thank you in advance.

k8s-ci-robot · 2022-10-28T07:57:31Z

Hi @eiffel-fl. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2022-10-28T07:59:03Z

Can one of the admins verify this patch?

spowelljr · 2022-10-28T16:57:00Z

ok-to-build-iso

minikube-bot · 2022-10-28T22:01:14Z

Hi @eiffel-fl, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

spowelljr · 2022-10-28T22:03:35Z

@eiffel-fl Do you have your repo restricted from allowing others to push to your fork?

15:01:13 + git add Makefile pkg/minikube/download/iso.go site/content/en/docs/commands/start.md
15:01:13 + git commit -m 'Updating ISO to v1.27.0-1666976405-15232'
15:01:13 [detached HEAD ddbda57526] Updating ISO to v1.27.0-1666976405-15232
15:01:13  2 files changed, 2 insertions(+), 2 deletions(-)
15:01:13 + git push eiffel-fl HEAD:francis/fanotify-perm
15:01:13 ERROR: Permission to eiffel-fl/minikube.git denied to minikube-bot.
15:01:13 fatal: Could not read from remote repository.
15:01:13 
15:01:13 Please make sure you have the correct access rights
15:01:13 and the repository exists.

spowelljr · 2022-10-28T22:15:06Z

15:00:40 + git checkout -b eiffel-fl-francis/fanotify-perm eiffel-fl/francis/fanotify-perm
15:00:40 fatal: 'eiffel-fl/francis/fanotify-perm' is not a commit and a branch 'eiffel-fl-francis/fanotify-perm' cannot be created from it

Actually, it looks like the branch creation is failing. Looks like the bot assumes the repo is under your own user but I see you're using a fork under an org.

https://github.com/kinvolk/minikube/tree/francis/fanotify-perm

We'll need to look into making that work, but in the meantime could you run the following:

sed -i 's/ISO_VERSION ?= .*/ISO_VERSION ?= v1.27.0-1666976405-15232/' Makefile
sed -i 's|isoBucket := .*|isoBucket := "minikube-builds/iso/15232"|' pkg/minikube/download/iso.go
make generate-docs

eiffel-fl · 2022-10-31T09:22:35Z

Hi.

https://github.com/kinvolk/minikube/tree/francis/fanotify-perm

We'll need to look into making that work, but in the meantime could you run the following:
sed -i 's/ISO_VERSION ?= .*/ISO_VERSION ?= v1.27.0-1666976405-15232/' Makefile
sed -i 's|isoBucket := .*|isoBucket := "minikube-builds/iso/15232"|' pkg/minikube/download/iso.go
make generate-docs

I updated my branch to add "for test purpose only" commit which modifies the ISO reference, so you cant now run ok-to-test.
Rather than trying to modify people branch, wouldn't it be easier to patch people code right before running the test?
So, the modification are only local to the pipeline?

spowelljr · 2022-10-31T16:18:28Z

Rather than trying to modify people branch, wouldn't it be easier to patch people code right before running the test? So, the modification are only local to the pipeline?

We want those changes to get merged though, it's updating the ISO to use when starting minikube, and once we merge this PR we want to use the ISO built in this PR as it's the most up to date.

spowelljr · 2022-10-31T16:18:39Z

/ok-to-test

eiffel-fl · 2022-10-31T17:06:49Z

once we merge this PR we want to use the ISO built in this PR as it's the most up to date.

I understood, thank you for the clarification.
Should I squash my commit then?

minikube-pr-bot · 2022-10-31T17:27:40Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15232) |
+----------------+----------+---------------------+
| minikube start | 54.6s    | 54.9s               |
| enable ingress | 27.8s    | 28.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.3s 28.3s 28.8s 28.3s 25.3s
Times for minikube (PR 15232) ingress: 28.3s 28.8s 27.7s 28.7s 28.2s

Times for minikube start: 54.9s 55.1s 54.2s 54.2s 54.7s
Times for minikube (PR 15232) start: 54.8s 55.0s 56.1s 54.1s 54.8s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error downloading artifacts: artifact download start: exit status 90

spowelljr · 2022-10-31T17:36:07Z

Should I squash my commit then?

Feel free to squash your commit

This options enables fanotify to make permissions decisions on filesystem events. Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>

minikube-pr-bot · 2022-10-31T18:55:26Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Hyper-V_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	8.26 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/AddonExistsAfterStop (gopogh)	10.81 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/EnableAddonAfterStop (gopogh)	11.41 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/SecondStart (gopogh)	11.41 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/Stop (gopogh)	11.41 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/UserAppExistsAfterStop (gopogh)	11.41 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	14.05 (chart)
Docker_Windows	TestPause/serial/SecondStartNoReconfiguration (gopogh)	23.68 (chart)
Docker_Windows	TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh)	44.70 (chart)
Docker_Windows	TestStartStop/group/embed-certs/serial/Pause (gopogh)	47.73 (chart)
KVM_Linux	TestMultiNode/serial/RestartMultiNode (gopogh)	48.41 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/DNS (gopogh)	52.63 (chart)
Docker_Windows	TestNetworkPlugins/group/false/DNS (gopogh)	59.21 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/DNS (gopogh)	61.33 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	67.80 (chart)
Docker_Windows	TestStartStop/group/newest-cni/serial/Pause (gopogh)	73.48 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/bridge/DNS (gopogh)	74.80 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/calico/Start (gopogh)	83.19 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithStopK8s (gopogh)	98.39 (chart)
Docker_Linux_containerd	TestKubernetesUpgrade (gopogh)	100.00 (chart)
Docker_Linux_containerd	TestPreload (gopogh)	100.00 (chart)
Docker_Windows	TestFunctional/parallel/ServiceCmd (gopogh)	100.00 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	100.00 (chart)
Docker_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/RestartKeepsNodes (gopogh)	100.00 (chart)
KVM_Linux_containerd	TestPreload (gopogh)	100.00 (chart)
KVM_Linux_containerd	TestStoppedBinaryUpgrade/Upgrade (gopogh)	100.00 (chart)
KVM_Linux	TestNetworkPlugins/group/kubenet/HairPin (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2022-10-31T20:09:03Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15232) |
+----------------+----------+---------------------+
| minikube start | 54.6s    | 55.3s               |
| enable ingress | 27.8s    | 26.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.7s 29.3s 28.7s 25.1s 28.2s
Times for minikube (PR 15232) ingress: 25.2s 27.6s 28.2s 25.7s 25.7s

Times for minikube start: 53.7s 54.5s 54.8s 55.1s 54.7s
Times for minikube (PR 15232) start: 53.8s 55.4s 55.3s 54.5s 57.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15232) |
+----------------+----------+---------------------+
| minikube start | 27.3s    | 25.9s               |
| enable ingress | 46.0s    | 22.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 81.5s 22.5s 21.5s 22.5s 82.0s
Times for minikube (PR 15232) ingress: 22.0s 22.0s 21.5s 22.5s 23.0s

Times for minikube start: 29.2s 24.1s 28.1s 28.4s 26.4s
Times for minikube (PR 15232) start: 25.8s 27.1s 26.5s 25.2s 25.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15232) |
+----------------+----------+---------------------+
| minikube start | 23.8s    | 23.3s               |
| enable ingress | 26.6s    | 26.4s               |
+----------------+----------+---------------------+

Times for minikube start: 22.1s 25.7s 22.4s 25.8s 23.1s
Times for minikube (PR 15232) start: 21.7s 23.2s 23.1s 25.7s 22.7s

Times for minikube ingress: 27.0s 27.0s 27.0s 26.0s 26.0s
Times for minikube (PR 15232) ingress: 26.0s 26.0s 26.0s 27.0s 27.0s

minikube-pr-bot · 2022-10-31T21:26:02Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux	TestNetworkPlugins/group/kindnet/DNS (gopogh)	7.59 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/auto/DNS (gopogh)	8.20 (chart)
Docker_Windows	TestPause/serial/PauseAgain (gopogh)	9.09 (chart)
Docker_Linux_containerd	TestAddons/Setup (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestFunctional/parallel/DashboardCmd (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MountCmd/any-port (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MySQL (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmd (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmdConnect (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestFunctional/serial/ExtraConfig (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestFunctional/serial/SoftStart (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestFunctional/serial/StartWithProxy (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestJSONOutput/start/Command (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestMultiNode/serial/AddNode (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestMultiNode/serial/DeleteNode (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestMultiNode/serial/DeployApp2Nodes (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestMultiNode/serial/FreshStart2Nodes (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestMultiNode/serial/ProfileList (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestMultiNode/serial/StartAfterStop (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestMultiNode/serial/StopNode (gopogh)	27.85 (chart)
Docker_Linux_containerd	TestMultiNode/serial/RestartMultiNode (gopogh)	28.48 (chart)
Docker_Linux_containerd	TestMultiNode/serial/RestartKeepsNodes (gopogh)	29.75 (chart)
KVM_Linux	TestPause/serial/SecondStartNoReconfiguration (gopogh)	41.77 (chart)
Docker_Windows	TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh)	44.36 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

spowelljr · 2022-11-01T22:25:36Z

/retest-this-please

minikube-pr-bot · 2022-11-01T23:45:08Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15232) |
+----------------+----------+---------------------+
| minikube start | 54.6s    | 54.8s               |
| enable ingress | 28.7s    | 28.4s               |
+----------------+----------+---------------------+

Times for minikube start: 55.1s 54.2s 54.0s 54.2s 55.4s
Times for minikube (PR 15232) start: 55.1s 53.1s 56.0s 54.7s 55.0s

Times for minikube ingress: 28.7s 28.7s 28.6s 28.2s 29.2s
Times for minikube (PR 15232) ingress: 29.2s 30.2s 28.7s 28.2s 25.8s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15232) |
+-------------------+----------+---------------------+
| minikube start    | 27.4s    | 25.9s               |
| ⚠️  enable ingress | 23.8s    | 35.1s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 26.8s 25.8s 29.7s 25.6s 29.1s
Times for minikube (PR 15232) start: 27.5s 26.3s 24.9s 25.5s 25.5s

Times for minikube ingress: 23.0s 22.5s 26.0s 22.0s 25.5s
Times for minikube (PR 15232) ingress: 25.5s 82.0s 22.5s 23.5s 22.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15232) |
+----------------+----------+---------------------+
| minikube start | 23.2s    | 25.7s               |
| enable ingress | 33.1s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube start: 22.4s 22.3s 26.0s 22.6s 22.4s
Times for minikube (PR 15232) start: 25.3s 23.4s 22.5s 23.6s 33.5s

Times for minikube ingress: 27.0s 27.0s 27.5s 27.0s 57.0s
Times for minikube (PR 15232) ingress: 27.0s 27.0s 27.0s 27.0s 27.0s

minikube-pr-bot · 2022-11-02T02:46:51Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
KVM_Linux	TestPause/serial/SecondStartNoReconfiguration (gopogh)	46.36 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	66.67 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/bridge/DNS (gopogh)	72.65 (chart)
Docker_Linux	TestNetworkPlugins/group/calico/Start (gopogh)	79.56 (chart)
Docker_Linux	TestNetworkPlugins/group/bridge/DNS (gopogh)	81.75 (chart)
Docker_Linux	TestNetworkPlugins/group/false/DNS (gopogh)	81.75 (chart)
Docker_Linux	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	82.48 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/calico/Start (gopogh)	84.26 (chart)
Docker_Linux	TestNetworkPlugins/group/kubenet/DNS (gopogh)	86.13 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh)	98.86 (chart)
Docker_Linux_containerd	TestKubernetesUpgrade (gopogh)	100.00 (chart)
Docker_Linux_containerd	TestPreload (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	100.00 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestMissingContainerUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/HairPin (gopogh)	100.00 (chart)
Docker_macOS	TestRunningBinaryUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	100.00 (chart)
Docker_macOS	TestStoppedBinaryUpgrade/Upgrade (gopogh)	100.00 (chart)
Hyperkit_macOS	TestNetworkPlugins/group/kubenet/HairPin (gopogh)	100.00 (chart)
KVM_Linux_containerd	TestPreload (gopogh)	100.00 (chart)
KVM_Linux_containerd	TestStoppedBinaryUpgrade/Upgrade (gopogh)	100.00 (chart)
KVM_Linux	TestMultiNode/serial/ValidateNameConflict (gopogh)	100.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

k8s-ci-robot · 2022-11-02T14:15:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eiffel-fl, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

eiffel-fl · 2022-11-02T14:17:54Z

Thank you for the merge!

Bump minikube to include fanotity permission added to latest version. Details, kubernetes/minikube#15232.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 28, 2022

k8s-ci-robot requested review from afbjorklund and spowelljr October 28, 2022 07:57

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 28, 2022

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2022

spowelljr mentioned this pull request Oct 28, 2022

Make ISO/Kicbase commit pushing more robust #15239

Closed

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 31, 2022

Add FANOTIFY_ACCESS_PERMISSIONS to kernel configs.

0194cc3

This options enables fanotify to make permissions decisions on filesystem events. Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>

eiffel-fl force-pushed the francis/fanotify-perm branch from 42265a8 to 0194cc3 Compare October 31, 2022 17:51

spowelljr approved these changes Nov 2, 2022

View reviewed changes

spowelljr merged commit baa8bf0 into kubernetes:master Nov 2, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2022

eiffel-fl deleted the francis/fanotify-perm branch November 2, 2022 14:17

mqasimsarfraz added a commit to inspektor-gadget/inspektor-gadget that referenced this pull request Jan 17, 2023

Makefile: Bump minikube version

eefedbd

Bump minikube to include fanotity permission added to latest version. Details, kubernetes/minikube#15232.

mqasimsarfraz added a commit to inspektor-gadget/inspektor-gadget that referenced this pull request Jan 17, 2023

Makefile: Bump minikube version

3cd3255

Bump minikube to include fanotity permission added to latest version. Details, kubernetes/minikube#15232.

mqasimsarfraz added a commit to inspektor-gadget/inspektor-gadget that referenced this pull request Jan 17, 2023

Makefile: Bump minikube version

7298e65

Bump minikube to include fanotity permission added to latest version. Details, kubernetes/minikube#15232.

mqasimsarfraz added a commit to inspektor-gadget/inspektor-gadget that referenced this pull request Jan 17, 2023

Makefile: Bump minikube version

5478632

Bump minikube to include fanotity permission added to latest version. Details, kubernetes/minikube#15232.

mqasimsarfraz added a commit to inspektor-gadget/inspektor-gadget that referenced this pull request Jan 18, 2023

Makefile: Bump minikube version

7552118

Bump minikube to include fanotity permission added to latest version. Details, kubernetes/minikube#15232.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

iso: Add FANOTIFY_ACCESS_PERMISSIONS to kernel configs. #15232

iso: Add FANOTIFY_ACCESS_PERMISSIONS to kernel configs. #15232

eiffel-fl commented Oct 28, 2022

k8s-ci-robot commented Oct 28, 2022

minikube-bot commented Oct 28, 2022

spowelljr commented Oct 28, 2022

minikube-bot commented Oct 28, 2022

spowelljr commented Oct 28, 2022

spowelljr commented Oct 28, 2022 •

edited

Loading

eiffel-fl commented Oct 31, 2022

spowelljr commented Oct 31, 2022

spowelljr commented Oct 31, 2022

eiffel-fl commented Oct 31, 2022 •

edited

Loading

minikube-pr-bot commented Oct 31, 2022

spowelljr commented Oct 31, 2022

minikube-pr-bot commented Oct 31, 2022

minikube-pr-bot commented Oct 31, 2022

minikube-pr-bot commented Oct 31, 2022

spowelljr commented Nov 1, 2022

minikube-pr-bot commented Nov 1, 2022

minikube-pr-bot commented Nov 2, 2022

k8s-ci-robot commented Nov 2, 2022

eiffel-fl commented Nov 2, 2022

iso: Add FANOTIFY_ACCESS_PERMISSIONS to kernel configs. #15232

iso: Add FANOTIFY_ACCESS_PERMISSIONS to kernel configs. #15232

Conversation

eiffel-fl commented Oct 28, 2022

k8s-ci-robot commented Oct 28, 2022

minikube-bot commented Oct 28, 2022

spowelljr commented Oct 28, 2022

minikube-bot commented Oct 28, 2022

spowelljr commented Oct 28, 2022

spowelljr commented Oct 28, 2022 • edited Loading

eiffel-fl commented Oct 31, 2022

spowelljr commented Oct 31, 2022

spowelljr commented Oct 31, 2022

eiffel-fl commented Oct 31, 2022 • edited Loading

minikube-pr-bot commented Oct 31, 2022

spowelljr commented Oct 31, 2022

minikube-pr-bot commented Oct 31, 2022

minikube-pr-bot commented Oct 31, 2022

minikube-pr-bot commented Oct 31, 2022

spowelljr commented Nov 1, 2022

minikube-pr-bot commented Nov 1, 2022

minikube-pr-bot commented Nov 2, 2022

k8s-ci-robot commented Nov 2, 2022

eiffel-fl commented Nov 2, 2022

spowelljr commented Oct 28, 2022 •

edited

Loading

eiffel-fl commented Oct 31, 2022 •

edited

Loading