Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimental markings from QEMU driver #15556

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Remove experimental markings from QEMU driver #15556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
649b8ef
remove experimental markings from QEMU driver
spowelljr Dec 28, 2022
f4e0de7
change priority to default
spowelljr Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/minikube/registry/drvs/qemu2/qemu2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func init() {
Config: configure,
Status: status,
Default: true,
Priority: registry.Experimental,
Priority: registry.Default,
}); err != nil {
panic(fmt.Sprintf("register failed: %v", err))
}
Expand Down
4 changes: 2 additions & 2 deletions site/content/en/docs/drivers/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ To do so, we use the [Docker Machine](https://github.com/docker/machine) library
* [Docker]({{<ref "docker.md">}}) - container-based (preferred)
* [KVM2]({{<ref "kvm2.md">}}) - VM-based (preferred)
* [VirtualBox]({{<ref "virtualbox.md">}}) - VM
* [QEMU]({{<ref "qemu.md">}}) - VM (experimental)
* [QEMU]({{<ref "qemu.md">}}) - VM
* [None]({{<ref "none.md">}}) - bare-metal
* [Podman]({{<ref "podman.md">}}) - container (experimental)
* [SSH]({{<ref "ssh.md">}}) - remote ssh
Expand All @@ -30,7 +30,7 @@ To do so, we use the [Docker Machine](https://github.com/docker/machine) library
* [VirtualBox]({{<ref "virtualbox.md">}}) - VM
* [Parallels]({{<ref "parallels.md">}}) - VM
* [VMware Fusion]({{<ref "vmware.md">}}) - VM
* [QEMU]({{<ref "qemu.md">}}) - VM (experimental)
* [QEMU]({{<ref "qemu.md">}}) - VM
* [SSH]({{<ref "ssh.md">}}) - remote ssh

## Windows
Expand Down
8 changes: 4 additions & 4 deletions site/content/en/docs/drivers/qemu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,7 @@ minikube start supports some qemu specific flags:
The QEMU driver has two networking options, `user` & `socket_vmnet`.

{{% tabs %}}
{{% tab "user - limited functionality" %}}
The `user` network is not a dedicated network, it doesn't support some networking commands such as `minikube service` and `minikube tunnel`, and its IP address is not reachable from the host.
{{% /tab %}}
{{% tab "socket_vmnet - experimental/needs installation" %}}
{{% tab "socket_vmnet - needs installation" %}}

### Requirements

Expand All @@ -57,6 +54,9 @@ minikube start --driver qemu --network socket_vmnet

The `socket_vmnet` network is a dedicated network and supports the `minikube service` and `minikube tunnel` commands.
{{% /tab %}}
{{% tab "user - limited functionality" %}}
The `user` network is not a dedicated network, it doesn't support some networking commands such as `minikube service` and `minikube tunnel`, and its IP address is not reachable from the host.
{{% /tab %}}
{{% /tabs %}}

## Known Issues
Expand Down