Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO: Upgrade podman to 3.4.7 #15565

Merged
merged 2 commits into from
Jan 30, 2023
Merged

ISO: Upgrade podman to 3.4.7 #15565

merged 2 commits into from
Jan 30, 2023

Conversation

mqasimsarfraz
Copy link
Contributor

fixes #15561

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 30, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @mqasimsarfraz!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 30, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @mqasimsarfraz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 30, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@mqasimsarfraz
Copy link
Contributor Author

@afbjorklund Can you please have a look at the PR?

afbjorklund
afbjorklund approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@afbjorklund afbjorklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-build-iso

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2023
@afbjorklund
Copy link
Collaborator

ok-to-build-iso

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15565) |
+----------------+----------+---------------------+
| minikube start | 57.2s    | 57.3s               |
| enable ingress | 30.1s    | 30.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 15565) start: 57.7s 57.3s 57.3s 57.6s 56.5s
Times for minikube start: 56.9s 58.1s 56.0s 57.2s 57.8s

Times for minikube ingress: 29.9s 29.8s 29.9s 30.4s 30.3s
Times for minikube (PR 15565) ingress: 30.4s 31.4s 28.9s 30.4s 31.4s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error downloading artifacts: artifact download start: exit status 90

@afbjorklund
Copy link
Collaborator

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @mqasimsarfraz, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15565) |
+----------------+----------+---------------------+
| minikube start | 54.1s    | 54.6s               |
| enable ingress | 39.2s    | 26.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.1s 27.7s 28.2s 27.6s 84.6s
Times for minikube (PR 15565) ingress: 24.2s 25.6s 27.6s 27.1s 27.6s

Times for minikube start: 54.2s 54.6s 54.5s 54.4s 52.8s
Times for minikube (PR 15565) start: 55.6s 54.6s 55.1s 54.1s 53.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15565) |
+----------------+----------+---------------------+
| minikube start | 25.1s    | 25.6s               |
| enable ingress | 20.3s    | 21.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 19.4s 21.5s 19.9s 20.9s 19.5s
Times for minikube (PR 15565) ingress: 22.0s 20.5s 22.5s 22.0s 19.0s

Times for minikube start: 26.5s 25.1s 25.1s 24.5s 24.3s
Times for minikube (PR 15565) start: 25.0s 25.5s 25.1s 27.2s 25.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15565) |
+----------------+----------+---------------------+
| minikube start | 25.1s    | 25.3s               |
| enable ingress | 26.3s    | 26.9s               |
+----------------+----------+---------------------+

Times for minikube start: 20.9s 24.9s 23.0s 34.3s 22.6s
Times for minikube (PR 15565) start: 22.3s 36.2s 24.0s 21.7s 22.5s

Times for minikube ingress: 26.4s 26.5s 26.0s 26.5s 26.0s
Times for minikube (PR 15565) ingress: 26.5s 29.4s 25.9s 26.0s 26.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) n/a
Hyper-V_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 0.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/calico/Start (gopogh) 0.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 0.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/flannel/Start (gopogh) 0.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 0.00 (chart)
Hyper-V_Windows TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/serial/LogsFileCmd (gopogh) 2.94 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/DeployApp (gopogh) 12.90 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 12.90 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/FirstStart (gopogh) 13.60 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/SecondStart (gopogh) 13.60 (chart)
Hyperkit_macOS TestPause/serial/SecondStartNoReconfiguration (gopogh) 28.57 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 38.71 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 38.71 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 39.20 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 39.20 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh) 46.77 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh) 47.62 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh) 48.03 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh) 49.23 (chart)
Docker_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 53.46 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 71.31 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 76.38 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 77.44 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 83.61 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 84.43 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 84.43 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 87.70 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 98.39 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@mqasimsarfraz
Copy link
Contributor Author

Things are looking better with the new ISO. For example, no more segfaults with:

minikube start --container-runtime=cri-o --vm=true --preload=false --iso-url https://storage.googleapis.com/minikube-builds/iso/15565/minikube-v1.28.0-1673190013-15565-amd64.iso

@mqasimsarfraz
Copy link
Contributor Author

@afbjorklund can we please merge this? or we still have something blocking this?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15565) |
+----------------+----------+---------------------+
| minikube start | 53.4s    | 53.0s               |
| enable ingress | 27.7s    | 27.9s               |
+----------------+----------+---------------------+

Times for minikube start: 52.4s 52.9s 54.3s 53.4s 54.2s
Times for minikube (PR 15565) start: 53.1s 51.8s 53.4s 53.9s 52.8s

Times for minikube ingress: 28.7s 25.2s 27.7s 29.3s 27.8s
Times for minikube (PR 15565) ingress: 27.7s 25.7s 28.2s 27.2s 30.7s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15565) |
+-------------------+----------+---------------------+
| minikube start    | 26.1s    | 26.3s               |
| ⚠️  enable ingress | 33.8s    | 45.5s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube (PR 15565) ingress: 81.5s 81.5s 23.5s 21.0s 20.0s
Times for minikube ingress: 23.0s 21.0s 21.5s 81.5s 22.0s

Times for minikube (PR 15565) start: 24.3s 28.5s 28.4s 25.2s 25.0s
Times for minikube start: 24.6s 25.7s 28.5s 26.8s 24.9s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15565) |
+-------------------+----------+---------------------+
| minikube start    | 20.7s    | 21.2s               |
| ⚠️  enable ingress | 27.0s    | 41.6s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 20.9s 20.3s 21.3s 20.1s 20.8s
Times for minikube (PR 15565) start: 21.1s 22.2s 20.1s 21.5s 21.1s

Times for minikube ingress: 31.5s 33.0s 18.5s 32.5s 19.5s
Times for minikube (PR 15565) ingress: 81.0s 31.5s 31.5s 32.5s 31.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestMultiNode/serial/StartAfterStop (gopogh) 0.81 (chart)
KVM_Linux_containerd TestErrorSpam/setup (gopogh) 4.43 (chart)
KVM_Linux TestErrorSpam/setup (gopogh) 5.65 (chart)
Hyperkit_macOS TestErrorSpam/setup (gopogh) 5.92 (chart)
Docker_Windows TestRunningBinaryUpgrade (gopogh) 11.71 (chart)
Hyper-V_Windows TestRunningBinaryUpgrade (gopogh) 37.04 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 39.81 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 98.68 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr
Copy link
Member

ok-to-build-iso

@spowelljr spowelljr mentioned this pull request Jan 27, 2023
Merged
@spowelljr spowelljr changed the title Upgrade podman to 3.4.7 ISO: Upgrade podman to 3.4.7 Jan 27, 2023
@minikube-bot
Copy link
Collaborator

Hi @mqasimsarfraz, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15565) |
+----------------+----------+---------------------+
| minikube start | 53.7s    | 53.3s               |
| enable ingress | 25.2s    | 26.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 15565) start: 55.1s 53.6s 52.4s 52.3s 52.9s
Times for minikube start: 53.7s 54.4s 56.0s 52.3s 52.3s

Times for minikube (PR 15565) ingress: 28.2s 26.2s 24.3s 29.2s 24.7s
Times for minikube ingress: 23.6s 24.2s 29.2s 24.7s 24.2s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15565) |
+-------------------+----------+---------------------+
| minikube start    | 25.2s    | 24.8s               |
| ⚠️  enable ingress | 21.2s    | 27.9s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 25.4s 25.2s 25.0s 25.6s 24.7s
Times for minikube (PR 15565) start: 26.5s 24.1s 24.2s 24.1s 25.3s

Times for minikube (PR 15565) ingress: 50.5s 23.0s 21.0s 22.0s 23.0s
Times for minikube ingress: 21.5s 21.5s 22.0s 20.0s 21.0s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15565) |
+-------------------+----------+---------------------+
| minikube start    | 21.4s    | 21.0s               |
| ⚠️  enable ingress | 39.8s    | 52.3s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 21.1s 23.0s 21.2s 20.4s 21.1s
Times for minikube (PR 15565) start: 20.5s 19.8s 19.9s 21.1s 23.8s

Times for minikube ingress: 33.0s 32.0s 81.0s 32.5s 20.5s
Times for minikube (PR 15565) ingress: 82.0s 32.0s 82.0s 33.0s 32.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestNetworkPlugins/group/auto/Start (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/old-k8s-version/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Hyper-V_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 0.00 (chart)
Hyper-V_Windows TestStartStop/group/newest-cni/serial/SecondStart (gopogh) 0.00 (chart)
Hyper-V_Windows TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Hyperkit_macOS TestCertExpiration (gopogh) 0.64 (chart)
Hyper-V_Windows TestErrorSpam/setup (gopogh) 1.20 (chart)
Hyperkit_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 1.27 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 3.82 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/Pause (gopogh) 3.82 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/SecondStart (gopogh) 3.82 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 3.82 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/VerifyKubernetesImages (gopogh) 3.82 (chart)
KVM_Linux_containerd TestErrorSpam/setup (gopogh) 10.62 (chart)
KVM_Linux TestErrorSpam/setup (gopogh) 12.32 (chart)
Hyperkit_macOS TestErrorSpam/setup (gopogh) 12.74 (chart)
KVM_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 16.67 (chart)
Hyper-V_Windows TestRunningBinaryUpgrade (gopogh) 80.72 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 85.54 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 96.71 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15565) |
+----------------+----------+---------------------+
| minikube start | 53.1s    | 54.1s               |
| enable ingress | 25.3s    | 25.7s               |
+----------------+----------+---------------------+

Times for minikube start: 52.4s 52.9s 53.2s 53.9s 53.2s
Times for minikube (PR 15565) start: 53.9s 55.7s 54.1s 54.0s 52.9s

Times for minikube (PR 15565) ingress: 25.1s 23.7s 24.2s 27.7s 27.7s
Times for minikube ingress: 24.7s 24.2s 24.2s 28.7s 24.7s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15565) |
+-------------------+----------+---------------------+
| minikube start    | 25.4s    | 24.7s               |
| ⚠️  enable ingress | 33.6s    | 38.9s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube (PR 15565) ingress: 20.5s 49.5s 20.0s 82.5s 22.0s
Times for minikube ingress: 20.0s 21.5s 82.5s 23.0s 21.0s

Times for minikube start: 24.6s 27.0s 24.7s 24.7s 25.7s
Times for minikube (PR 15565) start: 24.4s 24.2s 24.6s 24.4s 26.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15565) |
+----------------+----------+---------------------+
| minikube start | 20.6s    | 21.7s               |
| enable ingress | 39.5s    | 30.0s               |
+----------------+----------+---------------------+

Times for minikube start: 20.7s 20.8s 20.7s 21.4s 19.5s
Times for minikube (PR 15565) start: 20.9s 23.1s 23.8s 21.0s 19.7s

Times for minikube ingress: 80.0s 33.0s 20.0s 32.5s 32.0s
Times for minikube (PR 15565) ingress: 20.5s 31.5s 32.5s 33.0s 32.5s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15565) |
+----------------+----------+---------------------+
| minikube start | 53.4s    | 54.0s               |
| enable ingress | 28.3s    | 26.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 15565) start: 53.4s 52.9s 53.1s 52.6s 57.9s
Times for minikube start: 52.9s 54.6s 52.4s 53.8s 53.1s

Times for minikube (PR 15565) ingress: 27.3s 28.3s 25.7s 25.3s 26.2s
Times for minikube ingress: 29.3s 25.7s 29.7s 28.7s 28.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15565) |
+----------------+----------+---------------------+
| minikube start | 24.6s    | 25.6s               |
| enable ingress | 33.2s    | 21.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.0s 20.0s 20.5s 81.5s 22.0s
Times for minikube (PR 15565) ingress: 21.5s 22.0s 20.5s 21.0s 22.0s

Times for minikube start: 25.0s 24.4s 24.0s 24.9s 24.6s
Times for minikube (PR 15565) start: 25.3s 26.3s 25.9s 25.4s 25.3s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15565) |
+-------------------+----------+---------------------+
| minikube start    | 20.8s    | 21.2s               |
| ⚠️  enable ingress | 27.5s    | 33.5s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 20.8s 20.9s 21.3s 20.9s 20.4s
Times for minikube (PR 15565) start: 20.8s 20.8s 22.6s 20.8s 21.2s

Times for minikube ingress: 19.5s 31.5s 34.0s 31.5s 21.0s
Times for minikube (PR 15565) ingress: 33.0s 47.5s 31.5s 34.0s 21.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestFunctional/parallel/ConfigCmd (gopogh) 2.53 (chart)
Docker_Linux TestMultiNode/serial/StartAfterStop (gopogh) 8.72 (chart)
Hyperkit_macOS TestHyperkitDriverSkipUpgrade/upgrade-v1.2.0-to-current (gopogh) 12.88 (chart)
Docker_macOS TestHyperkitDriverSkipUpgrade/upgrade-v1.2.0-to-current (gopogh) 13.38 (chart)
Docker_Windows TestRunningBinaryUpgrade (gopogh) 34.51 (chart)
Hyper-V_Windows TestRunningBinaryUpgrade (gopogh) 81.82 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 86.36 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 96.84 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@mqasimsarfraz
Copy link
Contributor Author

@spowelljr I had to rebase because of v1.29.0 release. I picked the ISO version from today (verified it has the latest iso changes). Please let me know what you think about it.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestNoKubernetes/serial/StartWithK8s (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/parallel/License (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/ConfigCmd (gopogh) 1.20 (chart)
KVM_Linux_containerd TestJSONOutput/stop/parallel/DistinctCurrentSteps (gopogh) 3.59 (chart)
KVM_Linux_containerd TestJSONOutput/stop/parallel/IncreasingCurrentSteps (gopogh) 3.59 (chart)
Docker_Linux_containerd TestErrorSpam/setup (gopogh) 4.76 (chart)
Docker_Linux TestErrorSpam/setup (gopogh) 5.33 (chart)
Docker_Linux_containerd TestFunctional/parallel/License (gopogh) 5.95 (chart)
KVM_Linux_containerd TestFunctional/parallel/License (gopogh) 5.99 (chart)
Docker_Cloud_Shell TestFunctional/parallel/License (gopogh) 6.06 (chart)
Hyperkit_macOS TestFunctional/parallel/License (gopogh) 6.10 (chart)
Docker_macOS TestFunctional/parallel/License (gopogh) 6.29 (chart)
Docker_Linux TestFunctional/parallel/License (gopogh) 6.67 (chart)
KVM_Linux TestFunctional/parallel/License (gopogh) 6.94 (chart)
Docker_macOS TestErrorSpam/setup (gopogh) 7.98 (chart)
Hyperkit_macOS TestHyperkitDriverSkipUpgrade/upgrade-v1.2.0-to-current (gopogh) 13.41 (chart)
Docker_macOS TestHyperkitDriverSkipUpgrade/upgrade-v1.2.0-to-current (gopogh) 13.92 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 86.52 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 96.86 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr
Copy link
Member

@spowelljr I had to rebase because of v1.29.0 release. I picked the ISO version from today (verified it has the latest iso changes). Please let me know what you think about it.

This looks fine to me, thanks for the rebase

spowelljr
spowelljr approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, mqasimsarfraz, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 1b423aa into kubernetes:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund afbjorklund approved these changes

@spowelljr spowelljr spowelljr approved these changes

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Podman broken in later versions of ISO
6 participants
@mqasimsarfraz @k8s-ci-robot @minikube-bot @afbjorklund @minikube-pr-bot @spowelljr